1. 03 Dec, 2014 1 commit
  2. 18 Jul, 2014 1 commit
    • antirez's avatar
      tryObjectEncoding(): use shared objects with maxmemory and non-LRU policy. · ab5f20d1
      antirez authored
      In order to make sure every object has its own private LRU counter, when
      maxmemory is enabled tryObjectEncoding() does not use the pool of shared
      integers. However when the policy is not LRU-based, it does not make
      sense to do so, and it is much better to save memory using shared
      integers.
      ab5f20d1
  3. 14 Jul, 2014 1 commit
    • michael-grunder's avatar
      Fix OBJECT arity · 3df2ab67
      michael-grunder authored
      Previously, the command definition for the OBJECT command specified
      a minimum of two args (and that it was variadic), which meant that
      if you sent this:
      
      OBJECT foo
      
      When cluster was enabled, it would result in an assertion/SEGFAULT
      when Redis was attempting to extract keys.
      
      It appears that OBJECT is not variadic, and only ever takes 3 args.
      
      https://gist.github.com/michael-grunder/25960ce1508396d0d36a
      3df2ab67
  4. 09 Jun, 2014 1 commit
  5. 16 Apr, 2014 1 commit
    • antirez's avatar
      String value unsharing refactored into proper function. · 9e178afa
      antirez authored
      All the Redis functions that need to modify the string value of a key in
      a destructive way (APPEND, SETBIT, SETRANGE, ...) require to make the
      object unshared (if refcount > 1) and encoded in raw format (if encoding
      is not already REDIS_ENCODING_RAW).
      
      This was cut & pasted many times in multiple places of the code. This
      commit puts the small logic needed into a function called
      dbUnshareStringValue().
      9e178afa
  6. 05 Dec, 2013 1 commit
  7. 27 Aug, 2013 2 commits
  8. 28 Jul, 2013 1 commit
    • antirez's avatar
      Remove dead variable bothsds from object.c. · 78644f5e
      antirez authored
      Thanks to @run and @badboy for spotting this.
      Triva: clang was not able to provide me a warning about that when
      compiling.
      
      This closes #1024 and #1207, committing the change myself as the pull
      requests no longer apply cleanly after other changes to the same
      function.
      78644f5e
  9. 16 Jul, 2013 1 commit
    • antirez's avatar
      Make sure that ZADD can accept the full range of double values. · 112e7636
      antirez authored
      This fixes issue #1194, that contains many details.
      
      However in short, it was possible for ZADD to not accept as score values
      that was however possible to obtain with multiple calls to ZINCRBY, like
      in the following example:
      
      redis 127.0.0.1:6379> zadd k 2.5e-308 m
      (integer) 1
      redis 127.0.0.1:6379> zincrby k -2.4e-308 m
      "9.9999999999999694e-310"
      redis 127.0.0.1:6379> zscore k m
      "9.9999999999999694e-310"
      redis 127.0.0.1:6379> zadd k 9.9999999999999694e-310 m1
      (error) ERR value is not a valid float
      
      The problem was due to strtod() returning ERANGE in the following case
      specified by POSIX:
      
      "If the correct value would cause an underflow, a value whose magnitude
      is no greater than the smallest normalized positive number in the return
      type shall be returned and errno set to [ERANGE].".
      
      Now instead the returned value is accepted even when ERANGE is returned
      as long as the return value of the function is not negative or positive
      HUGE_VAL or zero.
      112e7636
  10. 12 Jul, 2013 1 commit
    • antirez's avatar
      Fixed compareStringObject() and introduced collateStringObject(). · d8fcbb66
      antirez authored
      compareStringObject was not always giving the same result when comparing
      two exact strings, but encoded as integers or as sds strings, since it
      switched to strcmp() when at least one of the strings were not sds
      encoded.
      
      For instance the two strings "123" and "123\x00456", where the first
      string was integer encoded, would result into the old implementation of
      compareStringObject() to return 0 as if the strings were equal, while
      instead the second string is "greater" than the first in a binary
      comparison.
      
      The same compasion, but with "123" encoded as sds string, would instead
      return a value < 0, as it is correct. It is not impossible that the
      above caused some obscure bug, since the comparison was not always
      deterministic, and compareStringObject() is used in the implementation
      of skiplists, hash tables, and so forth.
      
      At the same time, collateStringObject() was introduced by this commit, so
      that can be used by SORT command to return sorted strings usign
      collation instead of binary comparison. See next commit.
      d8fcbb66
  11. 28 Jan, 2013 2 commits
  12. 19 Jan, 2013 1 commit
    • guiquanz's avatar
      Fixed many typos. · 1caf0939
      guiquanz authored
      Conflicts fixed, mainly because 2.8 has no cluster support / files:
      	00-RELEASENOTES
      	src/cluster.c
      	src/crc16.c
      	src/redis-trib.rb
      	src/redis.h
      1caf0939
  13. 08 Nov, 2012 1 commit
  14. 05 Apr, 2012 1 commit
  15. 27 Mar, 2012 1 commit
  16. 22 Mar, 2012 2 commits
  17. 03 Jan, 2012 1 commit
  18. 14 Nov, 2011 1 commit
  19. 12 Nov, 2011 1 commit
  20. 08 Nov, 2011 1 commit
  21. 04 Oct, 2011 1 commit
  22. 13 Jul, 2011 1 commit
  23. 25 Jun, 2011 1 commit
  24. 03 Jun, 2011 1 commit
  25. 05 May, 2011 1 commit
  26. 06 Apr, 2011 3 commits
  27. 08 Mar, 2011 2 commits
  28. 01 Jan, 2011 1 commit
  29. 30 Dec, 2010 1 commit
  30. 29 Dec, 2010 1 commit
  31. 28 Dec, 2010 1 commit
  32. 04 Nov, 2010 1 commit
  33. 15 Oct, 2010 1 commit
  34. 14 Oct, 2010 1 commit