- 29 Apr, 2018 1 commit
-
-
Itamar Haber authored
An implementation of the [Ze POP Redis Module](https://github.com/itamarhaber/zpop) as core Redis commands. Fixes #1861.
-
- 19 Apr, 2018 2 commits
- 18 Apr, 2018 1 commit
-
-
antirez authored
-
- 17 Apr, 2018 2 commits
- 13 Apr, 2018 4 commits
-
-
Salvatore Sanfilippo authored
Modules Timer API: fix wrong raxInsert() usage
-
zhaozhao.zz authored
-
antirez authored
This is useful in the reply and timeout callback, if the module wants to do some cleanup of the blocked client handle that may be stored around in the module-private data structures.
-
antirez authored
-
- 12 Apr, 2018 2 commits
- 11 Apr, 2018 3 commits
- 09 Apr, 2018 5 commits
-
-
antirez authored
Plus freeMemoryIfNeeded() refactoring to improve legibility. Please review this commit for sanity.
-
antirez authored
-
antirez authored
-
antirez authored
This way it is possible to use conditional compilation to be compatible with a larger amount of Redis versions, however note that this breaks binary compatibiltiy, so the module must be compiled with the corresponding redismodule.h file depending on the version of Redis targeted.
-
antirez authored
Note that this was an experimental API that can only be enabled with REIDSMODULE_EXPERIMENTAL_API, so it is subject to change until its promoted to stable API. Sorry for the breakage, it is trivial to resolve btw. This change will not be back ported to Redis 4.0.
-
- 05 Apr, 2018 1 commit
-
-
antirez authored
-
- 01 Apr, 2018 2 commits
- 31 Mar, 2018 3 commits
- 30 Mar, 2018 10 commits
- 29 Mar, 2018 1 commit
-
-
antirez authored
-
- 28 Mar, 2018 1 commit
-
-
antirez authored
While this feature is not used by Redis, ae.c implements the ability for a timer to call a finalizer callback when an timer event is deleted. This feature was bugged since the start, and because it was never used we never noticed a problem. However Anthony LaTorre was using the same library in order to implement a different system: he found a bug that he describes as follows, and which he fixed with the patch in this commit, sent me by private email: --- Anthony email --- 've found one bug in the current implementation of the timed events. It's possible to lose track of a timed event if an event is added in the finalizerProc of another event. For example, suppose you start off with three timed events 1, 2, and 3. Then the linked list looks like: 3 -> 2 -> 1 Then, you run processTimeEvents and events 2 and 3 finish, so now the list looks like: -1 -> -1 -> 2 Now, on the next iteration of processTimeEvents it starts by deleting the first event, and suppose this finalizerProc creates a new event, so that the list looks like this: 4 -> -1 -> 2 On the next iteration of the while loop, when it gets to the second event, the variable prev is still set to NULL, so that the head of the event loop after the next event will be set to 2, i.e. after deleting the next event the event loop will look like: 2 and the event with id 4 will be lost. I've attached an example program to illustrate the issue. If you run it you will see that it prints: ``` foo id = 0 spam! ``` But if you uncomment line 29 and run it again it won't print "spam!". --- End of email --- Test.c source code is as follows: #include "ae.h" #include <stdio.h> aeEventLoop *el; int foo(struct aeEventLoop *el, long long id, void *data) { printf("foo id = %lld\n", id); return AE_NOMORE; } int spam(struct aeEventLoop *el, long long id, void *data) { printf("spam!\n"); return AE_NOMORE; } void bar(struct aeEventLoop *el, void *data) { aeCreateTimeEvent(el, 0, spam, NULL, NULL); } int main(int argc, char **argv) { el = aeCreateEventLoop(100); //aeCreateTimeEvent(el, 0, foo, NULL, NULL); aeCreateTimeEvent(el, 0, foo, NULL, bar); aeMain(el); return 0; } Anthony fixed the problem by using a linked list for the list of timers, and sent me back this patch after he tested the code in production for some time. The code looks sane to me, so committing it to Redis.
-
- 26 Mar, 2018 1 commit
-
-
antirez authored
-
- 25 Mar, 2018 1 commit
-
-
antirez authored
-