1. 24 Mar, 2014 2 commits
    • Matt Stancliff's avatar
      Cluster: Restore proper trib master iteration · 4af72d32
      Matt Stancliff authored
      This got removed in 2e5c394f during a new feature addition.
      
      The prior commit had "break if masters.length == masters_count"
      but we are guaranteed to aready have that condition met since
      otherwise we would haven't gotten this far.
      
      Without this break statement, it's possible some masters may
      be forgotten and have zero replicas while other masters have
      more than their requested number of replicas.
      
      Thanks to carlos for pointing out this regression at:
      https://groups.google.com/forum/#!topic/redis-db/_WVVqDw5B7c
      4af72d32
    • Matt Stancliff's avatar
      Cluster: Fix trib create when masters==replicas · ee18135a
      Matt Stancliff authored
      This bug was introduced in 2e5c394f during a refactor.
      
      It took me a while to understand what was going on with
      the code, so I've refactored it further by:
        - Replacing boolean values with meaningful symbols
        - Replacing 'i' with a meaningful variable name
        - Adding the proper abort check
        - Factoring out now duplicated conditionals
        - Adding optional verbose logging (we're inside *four*
          different looping constructs, so it takes a while to
          figure out where all the moving parts are)
        - Updating comment for the section
      
      This fixes a problem when the number of master instances
      equaled the number of replica instances.  Before, when
      there were equal numbers of both, nodes_count would go to
      zero, but the while loop would spin in i < @replicas because
      i would never be updated (because the nodes_list of each ip
      was length == 0, which triggered an endless loop of
      next -> i = 0 -> 0 < 1? -> true -> next -> i = 0 ...)
      
      Thanks to carlo who found this problem at:
      https://groups.google.com/forum/#!topic/redis-db/_WVVqDw5B7c
      ee18135a
  2. 15 Mar, 2014 1 commit
  3. 11 Mar, 2014 2 commits
  4. 11 Feb, 2014 1 commit
  5. 10 Feb, 2014 6 commits
  6. 24 Jan, 2014 1 commit
  7. 17 Jan, 2014 5 commits
  8. 16 Jan, 2014 2 commits
  9. 17 Dec, 2013 1 commit
  10. 07 Nov, 2013 1 commit
  11. 05 Nov, 2013 1 commit
  12. 11 Oct, 2013 1 commit
  13. 25 Sep, 2013 2 commits
  14. 26 Mar, 2013 1 commit
  15. 25 Mar, 2013 3 commits
  16. 22 Mar, 2013 6 commits
  17. 21 Mar, 2013 4 commits