- 22 Jan, 2014 2 commits
- 20 Jan, 2014 2 commits
-
-
antirez authored
One of the simple heuristics used by Redis Cluster in order to avoid losing data in the typical failure modes created by the asynchronous replication with the slaves (a master is unable, when accepting a write, to immediately tell if it should be really accepted or refused because of a configuration change), is to wait some time before to rejoin the cluster after being partitioned away from the majority of instances. A similar condition happens when a master is restarted. It does not know if it was already failed over, nor if all the clients have already an updated configuration about the cluster map, so it is possible that clients will try to write to stale masters that were restarted. In a similar way this commit changes masters behavior so they wait 2000 milliseconds before accepting writes after a reboot. There is nothing special about 2 seconds if not to be a value supposedly larger a few orders of magnitude compared to the cluster bus communication latencies.
-
antirez authored
These were committed for error after being inserted in order to fix an issue.
-
- 17 Jan, 2014 1 commit
-
-
antirez authored
The code was doing checks for slaves that should be done only when the instance is currently a master. Switching a slave from a master to another one should just work.
-
- 16 Jan, 2014 2 commits
- 15 Jan, 2014 9 commits
-
-
antirez authored
CLUSTER FORGET is not useful if we can't remove a node from all the nodes of our cluster because of the Gossip protocol that keeps adding a given node to nodes where we already tried to remove it. So now CLUSTER FORGET implements a nodes blacklist that is set and checked by the Gossip section processing function. This way before a node is re-added at least 60 seconds must elapse since the FORGET execution. This means that redis-trib has some time to remove a node from a whole cluster. It is possible that in the future it will be uesful to raise the 60 sec figure to something bigger.
-
antirez authored
The hash table value should be set to now + 60 seconds otherwise it expires immediately.
-
antirez authored
We can't lookup by node->name that's not an SDS string but a plain C array in the node structure.
-
antirez authored
-
antirez authored
The rejoin delay usually is the node timeout. However if the node timeout is too small, we set it to 500 milliseconds, that is a value chosen to be greater than most setups RTT / instances latency figures so that likely communication with other nodes happen before rejoining.
-
antirez authored
Usually we update the cluster state (to understand if we should accept queries or reply with an error) only when there is a change in the state of the nodes. However for the "delayed rejoin" feature to work, that is, for a master to wait some time before accepting queries again after it rejoins the majority, we need to periodically update the last time when the node was partitioned away from the majority. With this commit if the cluster is down we update the state ten times per second.
-
antirez authored
See issue #1426 on Github.
-
antirez authored
Even without the user messing manually with the file, it is still possible to have blank lines (just a single "\n" per line) because of how the nodes.conf update/write process works.
-
antirez authored
The way the file was generated was unsafe and leaded to nodes.conf file corruption (zero length file) on server stop/crash during the creation of the file. The previous file update method was as simple as open with O_TRUNC followed by the write call. While the write call was a single one with the full payload, ensuring no half-written files for POSIX semantics, stopping the server just after the open call resulted into a zero-length file (all the nodes information lost!).
-
- 14 Jan, 2014 1 commit
-
-
antirez authored
A client can enter a special cluster read-only mode using the READONLY command: if the client read from a slave instance after this command, for slots that are actually served by the instance's master, the queries will be processed without redirection, allowing clients to read from slaves (but without any kind fo read-after-write guarantee). The READWRITE command can be used in order to exit the readonly state.
-
- 09 Jan, 2014 1 commit
-
-
antirez authored
long was used instead of long long in order to handle a 64 bit resolution millisecond timestamp. This fixes issue #1483.
-
- 25 Dec, 2013 1 commit
-
-
antirez authored
The function actually needs to be split into sub-functions at some point in the future.
-
- 22 Dec, 2013 1 commit
-
-
antirez authored
When the configured node timeout is very small, the data validity time (maximum data age for a slave to try a failover) is too little (ten times the configured node timeout) when the replication link with the master is mostly idle. In this case we'll receive some data from the master only every server.repl_ping_slave_period to refresh the last interaction with the master. This commit adds to the max data validity time the slave ping period to avoid this problem of slaves sensing too old data without a good reason. However this max data validity time is likely a setting that should be configurable by the Redis Cluster user in a way completely independent from the node timeout.
-
- 20 Dec, 2013 5 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
This commit makes it simple to start an handshake with a specific node address, and uses this in order to detect a node IP change and start a new handshake in order to fix the IP if possible.
-
antirez authored
As specified in the Redis Cluster specification, when a node can reach the majority again after a period in which it was partitioend away with the minorty of masters, wait some time before accepting queries, to provide a reasonable amount of time for other nodes to upgrade its configuration. This lowers the probabilities of both a client and a master with not updated configuration to rejoin the cluster at the same time, with a stale master accepting writes.
-
- 17 Dec, 2013 6 commits
-
-
antirez authored
The value was otherwise undefined, so next time the node was promoted again from slave to master, adding a slave to the list of slaves would likely crash the server or result into undefined behavior.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
This prevented 32bit cluster instances from clearing the FAIL flag when needed.
-
antirez authored
Ping sent and pong received fields need to be casted to long long to be printed correctly into 32 bit systems.
-
- 05 Dec, 2013 1 commit
-
-
antirez authored
-
- 02 Dec, 2013 1 commit
-
-
antirez authored
-
- 29 Nov, 2013 2 commits
- 08 Nov, 2013 5 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
Now there is a function that handles the update of the local slot configuration every time we have some new info about a node and its set of served slots and configEpoch. Moreoever the UPDATE packets are now processed when received (it was a work in progress in the previous commit).
-
antirez authored
-