- 31 May, 2018 1 commit
-
-
antirez authored
-
- 27 May, 2018 1 commit
-
-
zhaozhao.zz authored
-
- 20 Mar, 2018 1 commit
-
-
antirez authored
-
- 12 Mar, 2018 1 commit
-
-
Oran Agra authored
other fixes / improvements: - LUA script memory isn't taken from zmalloc (taken from libc malloc) so it can cause high fragmentation ratio to be displayed (which is false) - there was a problem with "fragmentation" info being calculated from RSS and used_memory sampled at different times (now sampling them together) other details: - adding a few more allocator info fields to INFO and MEMORY commands - improve defrag test to measure defrag latency of big keys - increasing the accuracy of the defrag test (by looking at real grag info) this way we can use an even lower threshold and still avoid false positives - keep the old (total) "fragmentation" field unchanged, but add new ones for spcific things - add these the MEMORY DOCTOR command - deduct LUA memory from the rss in case of non jemalloc allocator (one for which we don't "allocator active/used") - reduce sampling rate of the rss and allocator info
-
- 23 Feb, 2018 1 commit
-
-
gechunlin authored
-
- 05 Jan, 2018 1 commit
-
-
gnuhpc authored
-
- 06 Dec, 2017 1 commit
-
-
antirez authored
The main change introduced by this commit is pretending that help arrays are more text than code, thus indenting them at level 0. This improves readability, and is an old practice when defining arrays of C strings describing text. Additionally a few useless return statements are removed, and the HELP subcommand capitalized when printed to the user.
-
- 01 Dec, 2017 3 commits
- 28 Nov, 2017 1 commit
-
-
Itamar Haber authored
This adds a new `addReplyHelp` helper that's used by commands when returning a help text. The following commands have been touched: DEBUG, OBJECT, COMMAND, PUBSUB, SCRIPT and SLOWLOG. WIP Fix entry command table entry for OBJECT for HELP option. After #4472 the command may have just 2 arguments. Improve OBJECT HELP descriptions. See #4472. WIP 2 WIP 3
-
- 27 Nov, 2017 2 commits
-
-
zhaozhao.zz authored
Firstly, use access time to replace the decreas time of LFU. For function LFUDecrAndReturn, it should only try to get decremented counter, not update LFU fields, we will update it in an explicit way. And we will times halve the counter according to the times of elapsed time than server.lfu_decay_time. Everytime a key is accessed, we should update the LFU including update access time, and increment the counter after call function LFUDecrAndReturn. If a key is overwritten, the LFU should be also updated. Then we can use `OBJECT freq` command to get a key's frequence, and LFUDecrAndReturn should be called in `OBJECT freq` command in case of the key has not been accessed for a long time, because we update the access time only when the key is read or overwritten.
-
antirez authored
See #4472.
-
- 24 Nov, 2017 2 commits
-
-
Itamar Haber authored
-
Itamar Haber authored
When maxmemory is set to noeviction, idletime is implicitly kept. This renders access frequency nonsensical.
-
- 23 Nov, 2017 1 commit
-
-
Oran Agra authored
getLongLongFromObject calls string2ll which has this line: /* Return if not all bytes were used. */ so if you pass an sds with 3 characters "1\01" it will fail. but getLongDoubleFromObject calls strtold, and considers it ok if eptr[0]==`\0` i.e. if the end of the string found by strtold ends with null terminator 127.0.0.1:6379> set a 1 OK 127.0.0.1:6379> setrange a 2 2 (integer) 3 127.0.0.1:6379> get a "1\x002" 127.0.0.1:6379> incrbyfloat a 2 "3" 127.0.0.1:6379> get a "3"
-
- 08 Nov, 2017 1 commit
-
-
Itamar Haber authored
Fixes #4430
-
- 30 Oct, 2017 1 commit
-
-
antirez authored
Certain checks were useless, at the same time certain malformed inputs were accepted without problems (emtpy strings parsed as zero). Cases where strtod() returns ERANGE but we still want to parse the input where ok in getDoubleFromObject() but not in the long variant. As a side effect of these fixes, this commit fixes #4391.
-
- 28 Jul, 2017 1 commit
-
-
antirez authored
-
- 23 Feb, 2017 1 commit
-
-
oranagra authored
this commit also contains small bugfix in rdbLoadLzfStringObject a bug that currently has no implications.
-
- 27 Jan, 2017 1 commit
-
-
Jan-Erik Rediger authored
Previously Redis crashed on `MEMORY DOCTOR` when it has no slaves attached. Fixes #3783
-
- 26 Jan, 2017 1 commit
-
-
miter authored
-
- 12 Jan, 2017 1 commit
-
-
antirez authored
As a side effect of supporting it, we no longer crash when MEMORY USAGE is called against a module data type. Close #3637.
-
- 11 Jan, 2017 1 commit
-
-
Guy Benoish authored
-
- 06 Dec, 2016 1 commit
-
-
wangshaonan authored
is 0 or empty is 1
-
- 31 Oct, 2016 1 commit
-
-
Guy Benoish authored
-
- 21 Sep, 2016 1 commit
-
-
Dvir Volk authored
-
- 16 Sep, 2016 6 commits
- 15 Sep, 2016 5 commits
-
-
antirez authored
The size of the node depends on the node level, however it is not stored into the node itself, is an implicit information, so we use zmalloc_size() in order to compute the sorted set size.
-
antirez authored
-
antirez authored
The new SAMPLES option is added, defaulting to 5, and with 0 being a special value to scan the whole set of elements. Fixes to the object size computation were made since the original PR assumed data structures still contaning robj structures, while now after the lazyfree changes, are all SDS strings.
-
antirez authored
-
antirez authored
-
- 13 Sep, 2016 2 commits
-
-
antirez authored
This code was extracted from @oranagra PR #3223 and modified in order to provide only certain amounts of information compared to the original code. It was also moved from DEBUG to the newly introduced MEMORY command. Thanks to Oran for the implementation and the PR. It implements detailed memory usage stats that can be useful in both provisioning and troubleshooting memory usage in Redis.
-
antirez authored
For most tasks, we need the memory estimation to be O(1) by default. This commit also implements an initial MEMORY command. Note that objectComputeSize() takes the number of samples to check as argument, so MEMORY should be able to get the sample size as option to make precision VS CPU tradeoff tunable. Related to: PR #3223.
-