1. 16 Apr, 2014 12 commits
  2. 25 Mar, 2014 2 commits
    • Matt Stancliff's avatar
      Add REDIS_MIN_RESERVED_FDS define for open fds · 01fe750c
      Matt Stancliff authored
      Also update the original REDIS_EVENTLOOP_FDSET_INCR to
      include REDIS_MIN_RESERVED_FDS. REDIS_EVENTLOOP_FDSET_INCR
      exists to make sure more than (maxclients+RESERVED) entries
      are allocated, but we can only guarantee that if we include
      the current value of REDIS_MIN_RESERVED_FDS as a minimum
      for the INCR size.
      01fe750c
    • Matt Stancliff's avatar
      Fix maxclients error handling · 49b576cb
      Matt Stancliff authored
      Everywhere in the Redis code base, maxclients is treated
      as an int with (int)maxclients or `maxclients = atoi(source)`,
      so let's make maxclients an int.
      
      This fixes a bug where someone could specify a negative maxclients
      on startup and it would work (as well as set maxclients very high)
      because:
      
          unsigned int maxclients;
          char *update = "-300";
          maxclients = atoi(update);
          if (maxclients < 1) goto fail;
      
      But, (maxclients < 1) can only catch the case when maxclients
      is exactly 0.  maxclients happily sets itself to -300, which isn't
      -300, but rather 4294966996, which isn't < 1, so... everything
      "worked."
      
      maxclients config parsing checks for the case of < 1, but maxclients
      CONFIG SET parsing was checking for case of < 0 (allowing
      maxclients to be set to 0).  CONFIG SET parsing is now updated to
      match config parsing of < 1.
      
      It's tempting to add a MINIMUM_CLIENTS define, but... I didn't.
      
      These changes were inspired by antirez#356, but this doesn't
      fix that issue.
      49b576cb
  3. 24 Mar, 2014 1 commit
    • antirez's avatar
      Sample and cache RSS in serverCron(). · 2dd8c462
      antirez authored
      Obtaining the RSS (Resident Set Size) info is slow in Linux and OSX.
      This slowed down the generation of the INFO 'memory' section.
      
      Since the RSS does not require to be a real-time measurement, we
      now sample it with server.hz frequency (10 times per second by default)
      and use this value both to show the INFO rss field and to compute the
      fragmentation ratio.
      
      Practically this does not make any difference for memory profiling of
      Redis but speeds up the INFO call significantly.
      2dd8c462
  4. 21 Mar, 2014 9 commits
    • antirez's avatar
      The default maxmemory policy is now noeviction. · 7f274e3b
      antirez authored
      This is safer as by default maxmemory should just set a memory limit
      without any key to be deleted, unless the policy is set to something
      more relaxed.
      7f274e3b
    • antirez's avatar
      Use 24 bits for the lru object field and improve resolution. · a219339e
      antirez authored
      There were 2 spare bits inside the Redis object structure that are now
      used in order to enlarge 4x the range of the LRU field.
      
      At the same time the resolution was improved from 10 to 1 second: this
      still provides 194 days before the LRU counter overflows (restarting from
      zero).
      
      This is not a problem since it only causes lack of eviction precision for
      objects not touched for a very long time, and the lack of precision is
      only temporary.
      a219339e
    • antirez's avatar
      Default LRU samples is now 5. · 9928b531
      antirez authored
      9928b531
    • antirez's avatar
      LRU eviction pool implementation. · c641074a
      antirez authored
      This is an improvement over the previous eviction algorithm where we use
      an eviction pool that is persistent across evictions of keys, and gets
      populated with the best candidates for evictions found so far.
      
      It allows to approximate LRU eviction at a given number of samples
      better than the previous algorithm used.
      c641074a
    • antirez's avatar
      Obtain LRU clock in a resolution dependent way. · 205c2ccc
      antirez authored
      For testing purposes it is handy to have a very high resolution of the
      LRU clock, so that it is possible to experiment with scripts running in
      just a few seconds how the eviction algorithms works.
      
      This commit allows Redis to use the cached LRU clock, or a value
      computed on demand, depending on the resolution. So normally we have the
      good performance of a precomputed value, and a clock that wraps in many
      days using the normal resolution, but if needed, changing a define will
      switch behavior to an high resolution LRU clock.
      205c2ccc
    • antirez's avatar
      Specify lruclock in redisServer structure via REDIS_LRU_BITS. · 561e7934
      antirez authored
      The padding field was totally useless: removed.
      561e7934
    • antirez's avatar
      Specify LRU resolution in milliseconds. · 8f0b7491
      antirez authored
      8f0b7491
    • antirez's avatar
      Set LRU parameters via REDIS_LRU_BITS define. · 63aacbe8
      antirez authored
      63aacbe8
    • antirez's avatar
      Unify stats reset for CONFIG RESETSTAT / initServer(). · 8b6a674a
      antirez authored
      Now CONFIG RESETSTAT makes sure to reset all the fields, and in the
      future it will be simpler to avoid missing new fields.
      8b6a674a
  5. 11 Mar, 2014 4 commits
  6. 27 Feb, 2014 1 commit
    • antirez's avatar
      Initial implementation of BITPOS. · 1f8005ca
      antirez authored
      It appears to work but more stress testing, and both unit tests and
      fuzzy testing, is needed in order to ensure the implementation is sane.
      1f8005ca
  7. 13 Feb, 2014 1 commit
    • antirez's avatar
      Update cached time in rdbLoad() callback. · 3c1672da
      antirez authored
      server.unixtime and server.mstime are cached less precise timestamps
      that we use every time we don't need an accurate time representation and
      a syscall would be too slow for the number of calls we require.
      
      Such an example is the initialization and update process of the last
      interaction time with the client, that is used for timeouts.
      
      However rdbLoad() can take some time to load the DB, but at the same
      time it did not updated the time during DB loading. This resulted in the
      bug described in issue #1535, where in the replication process the slave
      loads the DB, creates the redisClient representation of its master, but
      the timestamp is so old that the master, under certain conditions, is
      sensed as already "timed out".
      
      Thanks to @yoav-steinberg and Redis Labs Inc for the bug report and
      analysis.
      3c1672da
  8. 12 Feb, 2014 1 commit
    • antirez's avatar
      AOF: don't abort on write errors unless fsync is 'always'. · dd73a7bf
      antirez authored
      A system similar to the RDB write error handling is used, in which when
      we can't write to the AOF file, writes are no longer accepted until we
      are able to write again.
      
      For fsync == always we still abort on errors since there is currently no
      easy way to avoid replying with success to the user otherwise, and this
      would violate the contract with the user of only acknowledging data
      already secured on disk.
      dd73a7bf
  9. 04 Feb, 2014 1 commit
    • antirez's avatar
      CLIENT PAUSE and related API implemented. · 4919a13f
      antirez authored
      The API is one of the bulding blocks of CLUSTER FAILOVER command that
      executes a manual failover in Redis Cluster. However exposed as a
      command that the user can call directly, it makes much simpler to
      upgrade a standalone Redis instance using a slave in a safer way.
      
      The commands works like that:
      
          CLIENT PAUSE <milliesconds>
      
      All the clients that are not slaves and not in MONITOR state are paused
      for the specified number of milliesconds. This means that slaves are
      normally served in the meantime.
      
      At the end of the specified amount of time all the clients are unblocked
      and will continue operations normally. This command has no effects on
      the population of the slow log, since clients are not blocked in the
      middle of operations but only when there is to process new data.
      
      Note that while the clients are unblocked, still new commands are
      accepted and queued in the client buffer, so clients will likely not
      block while writing to the server while the pause is active.
      4919a13f
  10. 03 Feb, 2014 1 commit
  11. 31 Jan, 2014 3 commits
  12. 29 Jan, 2014 1 commit
    • antirez's avatar
      Cluster: function clusterGetSlaveRank() added. · 6f540320
      antirez authored
      Return the number of slaves for the same master having a better
      replication offset of the current slave, that is, the slave "rank" used
      to pick a delay before the request for election.
      6f540320
  13. 14 Jan, 2014 2 commits
    • antirez's avatar
      Cluster: support to read from slave nodes. · 28273394
      antirez authored
      A client can enter a special cluster read-only mode using the READONLY
      command: if the client read from a slave instance after this command,
      for slots that are actually served by the instance's master, the queries
      will be processed without redirection, allowing clients to read from
      slaves (but without any kind fo read-after-write guarantee).
      
      The READWRITE command can be used in order to exit the readonly state.
      28273394
    • antirez's avatar
      Set REDIS_AOF_REWRITE_MIN_SIZE to 64mb. · 51894856
      antirez authored
      64mb is the default value in redis.conf. For some reason instead the
      hard-coded default was 1mb that is too small.
      51894856
  14. 08 Jan, 2014 1 commit
    • antirez's avatar
      Don't send REPLCONF ACK to old masters. · 90a81b4e
      antirez authored
      Masters not understanding REPLCONF ACK will reply with errors to our
      requests causing a number of possible issues.
      
      This commit detects a global replication offest set to -1 at the end of
      the replication, and marks the client representing the master with the
      REDIS_PRE_PSYNC flag.
      
      Note that this flag was called REDIS_PRE_PSYNC_SLAVE but now it is just
      REDIS_PRE_PSYNC as it is used for both slaves and masters starting with
      this commit.
      
      This commit fixes issue #1488.
      90a81b4e