1. 28 Mar, 2013 3 commits
  2. 27 Mar, 2013 4 commits
  3. 26 Mar, 2013 7 commits
    • antirez's avatar
      redis-trib: ClusterNode #info_string output modified. · 4fa30b78
      antirez authored
      The hope is that the new one is more readable.
      4fa30b78
    • antirez's avatar
      Allow SELECT while loading the DB. · df69155e
      antirez authored
      Fixes issue #1024.
      df69155e
    • antirez's avatar
      TTL / PTTL commands: two bugs fixed. · 873f328f
      antirez authored
      This commit fixes two corner cases for the TTL command.
      
      1) When the key was already logically expired (expire time older
      than current time) the command returned -1 instead of -2.
      
      2) When the key was existing and the expire was found to be exactly 0
      (the key was just about to expire), the command reported -1 (that is, no
      expire) instead of a TTL of zero (that is, about to expire).
      873f328f
    • antirez's avatar
      Flag PUBLISH as read-only in the command table. · 8bb5eb73
      antirez authored
      8bb5eb73
    • antirez's avatar
      Transactions: propagate MULTI/EXEC only when needed. · 71f3e743
      antirez authored
      MULTI/EXEC is now propagated to the AOF / Slaves only once we encounter
      the first command that is not a read-only one inside the transaction.
      
      The old behavior was to always propagate an empty MULTI/EXEC block when
      the transaction was composed just of read only commands, or even
      completely empty. This created two problems:
      
      1) It's a bandwidth waste in the replication link and a space waste
         inside the AOF file.
      
      2) We used to always increment server.dirty to force the propagation of
         the EXEC command, resulting into triggering RDB saves more often
         than needed.
      
      Note: even read-only commands may also trigger writes that will be
      propagated, when we access a key that is found expired and Redis will
      synthesize a DEL operation. However there is no need for this to stay
      inside the transaction itself, but only to be ordered.
      
      So for instance something like:
      
          MULTI
          GET foo
          SET key zap
          EXEC
      
      May be propagated into:
      
          DEL foo
          MULTI
          SET key zap
          EXEC
      
      While the DEL is outside the transaction, the commands are delivered in
      the right order and it is not possible for other commands to be inserted
      between DEL and MULTI.
      71f3e743
    • antirez's avatar
      02c269e2
    • antirez's avatar
      Transactions: use the propagate() API to propagate MULTI. · 2f497340
      antirez authored
      The behavior is the same, but the code is now cleaner and uses the
      proper interface instead of dealing directly with AOF/replication
      functions.
      2f497340
  4. 25 Mar, 2013 7 commits
  5. 22 Mar, 2013 7 commits
  6. 21 Mar, 2013 6 commits
  7. 20 Mar, 2013 4 commits
    • antirez's avatar
      Cluster: clear the PROMOTED slave directly into clusterSetMaster(). · 8c1bc8e8
      antirez authored
      This way we make sure every time a master is turned into a replica
      the flag will be cleared.
      8c1bc8e8
    • antirez's avatar
      Cluster: master node must clear its hash slots when turning into a slave. · e006407f
      antirez authored
      When a master turns into a slave after a failover event, make sure to
      clear the assigned slots before setting up the replication, as a slave
      should never claim slots in an explicit way, but just take over the
      master slots when replacing its master.
      e006407f
    • antirez's avatar
      Cluster: new flag PROMOTED introduced. · 506f9a42
      antirez authored
      A slave node set this flag for itself when, after receiving authorization
      from the majority of nodes, it turns itself into a master.
      
      At the same time now this flag is tested by nodes receiving a PING
      message before reconfiguring after a failover event. This makes the
      system more robust: even if currently there is no way to manually turn
      a slave into a master it is possible that we'll have such a feature in
      the future, or that simply because of misconfiguration a node joins the
      cluster as master while others believe it's a slave. This alone is now
      no longer enough to trigger reconfiguration as other nodes will check
      for the PROMOTED flag.
      
      The PROMOTED flag is cleared every time the node is turned back into a
      replica of some other node.
      506f9a42
    • antirez's avatar
      Cluster: add sender flags in cluster bus messages header. · 026b9483
      antirez authored
      Sender flags were not propagated for the sender, but only for nodes in
      the gossip section. This is odd and in the next commits we'll need to
      get updated flags for the sender node, so this commit adds a new field
      in the cluster messages header.
      
      The message header is the same size as we reused some free space that
      was marked as 'unused' because of alignment concerns.
      026b9483
  8. 19 Mar, 2013 2 commits
    • antirez's avatar
      Cluster: turn old master into a replica of node that failed over. · d15b027d
      antirez authored
      So when the failing master node is back in touch with the cluster,
      instead of remaining unused it is converted into a replica of the
      new master, ready to perform the fail over if the new master node
      will fail at some point.
      
      Note that as a side effect clients with stale configuration are now
      not an issue as well, as the node converted into a slave will not
      accept queries but will redirect clients accordingly.
      d15b027d
    • antirez's avatar
      Cluster: node replication role change handle improved. · 4d626230
      antirez authored
      The code handling a master that turns into a slave or the contrary was
      improved in order to avoid repeating the same operations. Also
      the readability and conceptual simplicity was improved.
      4d626230