1. 22 Nov, 2020 1 commit
    • Oran Agra's avatar
      Fix oom-score-adj-values range, abs options, and bug when used in config file (#8046) · 61954951
      Oran Agra authored
      Fix: When oom-score-adj-values is provided in the config file after
      oom-score-adj yes, it'll take an immediate action, before
      readOOMScoreAdj was acquired, resulting in an error (out of range score
      due to uninitialized value. delay the reaction the real call is made by
      main().
      
      Since the values are clamped to -1000..1000, and they're
      applied as an offset from the value at startup (which may be -1000), we
      need to allow the offsets to reach to +2000 so that a value of +1000 is
      achievable in case the value at startup was -1000.
      
      Adding an option for absolute values rather than relative ones.
      61954951
  2. 20 Nov, 2020 1 commit
  3. 18 Nov, 2020 1 commit
    • guybe7's avatar
      EXISTS should not alter LRU, OBJECT should not reveal expired keys on replica (#8016) · f8ae9917
      guybe7 authored
      The bug was introduced by #5021 which only attempted avoid EXIST on an
      already expired key from returning 1 on a replica.
      
      Before that commit, dbExists was used instead of
      lookupKeyRead (which had an undesired effect to "touch" the LRU/LFU)
      
      Other than that, this commit fixes OBJECT to also come empty handed on
      expired keys in replica.
      
      And DEBUG DIGEST-VALUE to behave like DEBUG OBJECT (get the data from
      the key regardless of it's expired state)
      f8ae9917
  4. 17 Nov, 2020 4 commits
    • Meir Shpilraien (Spielrein)'s avatar
      Unified MULTI, LUA, and RM_Call with respect to blocking commands (#8025) · d87a0d02
      Meir Shpilraien (Spielrein) authored
      Blocking command should not be used with MULTI, LUA, and RM_Call. This is because,
      the caller, who executes the command in this context, expects a reply.
      
      Today, LUA and MULTI have a special (and different) treatment to blocking commands:
      
      LUA   - Most commands are marked with no-script flag which are checked when executing
      and command from LUA, commands that are not marked (like XREAD) verify that their
      blocking mode is not used inside LUA (by checking the CLIENT_LUA client flag).
      MULTI - Command that is going to block, first verify that the client is not inside
      multi (by checking the CLIENT_MULTI client flag). If the client is inside multi, they
      return a result which is a match to the empty key with no timeout (for example blpop
      inside MULTI will act as lpop)
      For modules that perform RM_Call with blocking command, the returned results type is
      REDISMODULE_REPLY_UNKNOWN and the caller can not really know what happened....
      d87a0d02
    • thomaston's avatar
      ZREVRANGEBYSCORE Optimization for out of range offset (#5773) · 39f716a1
      thomaston authored
      
      
      ZREVRANGEBYSCORE key max min [WITHSCORES] [LIMIT offset count]
      When the offset is too large, the query is very slow. Especially when the offset is greater than the length of zset it is easy to determine whether the offset is greater than the length of zset at first, and If it exceed the length of zset, then return directly.
      Co-authored-by: default avatarOran Agra <oran@redislabs.com>
      39f716a1
    • Yossi Gottlieb's avatar
      Improve and clean up supervised process support. (#8036) · d638b058
      Yossi Gottlieb authored
      * Configuration file default should now be "auto".
      * Expose "process_supervised" as an info field.
      * Log messages improvements (clarify required systemd config, report
        auto-detected supervision mode, etc.)
      * Set server.supervised properly, so it can take precedence of
        "daemonize" configuration.
      * Produce clear warning if systemd is detected/requested but executable
        is compiled without support for it, instead of silently ignoring.
      * Handle systemd notification error on startup, and turn off supervised
        mode if it failed.
      d638b058
    • swamp0407's avatar
      Add COPY command (#7953) · ea7cf737
      swamp0407 authored
      
      
      Syntax:
      COPY <key> <new-key> [DB <dest-db>] [REPLACE]
      
      No support for module keys yet.
      
      Co-authored-by: tmgauss
      Co-authored-by: default avatarItamar Haber <itamar@redislabs.com>
      Co-authored-by: default avatarOran Agra <oran@redislabs.com>
      ea7cf737
  5. 16 Nov, 2020 2 commits
    • Oran Agra's avatar
      Fix memory leaks in newly added ZDIFF (#8056) · 9812e889
      Oran Agra authored
      9812e889
    • chenyangyang's avatar
      Modules callbacks for lazy free effort, and unlink (#7912) · c1aaad06
      chenyangyang authored
      Add two optional callbacks to the RedisModuleTypeMethods structure, which is `free_effort`
      and `unlink`. the `free_effort` callback indicates the effort required to free a module memory.
      Currently, if the effort exceeds LAZYFREE_THRESHOLD, the module memory may be released
      asynchronously. the `unlink` callback indicates the key has been removed from the DB by redis, and
      may soon be freed by a background thread.
      
      Add `lazyfreed_objects` info field, which represents the number of objects that have been
      lazyfreed since redis was started.
      
      Add `RM_GetTypeMethodVersion` API, which return the current redis-server runtime value of
      `REDISMODULE_TYPE_METHOD_VERSION`. You can use that when calling `RM_CreateDataType` to know
      which fields of RedisModuleTypeMethods are gonna be supported and which will be ignored.
      c1aaad06
  6. 15 Nov, 2020 1 commit
  7. 13 Nov, 2020 1 commit
  8. 12 Nov, 2020 2 commits
    • Itamar Haber's avatar
      Adds user parsing to redis-cli URIs (#8048) · 92ec5925
      Itamar Haber authored
      92ec5925
    • Yash Ladha's avatar
      cleanup: move list pop logic to single function (#7997) · c170365d
      Yash Ladha authored
      BLPOP when there are elements in the list works in the same way as LPOP
      does. Due to this they also does the same repetitive action and logic
      for the same is written at two different places. This is a bad code
      practice as the one needs the context to change the BLPOP list pop code
      as well when the LPOP code gets changed.
      
      Separated the generic logic from LPOP to a function that is being used
      by the BLPOP code as well.
      c170365d
  9. 11 Nov, 2020 4 commits
  10. 10 Nov, 2020 3 commits
  11. 09 Nov, 2020 2 commits
    • nitaicaro's avatar
      Extend client tracking tests (#7998) · 19c29b60
      nitaicaro authored
      Test support for the new map, null and push message types. Map objects are parsed as a list of lists of key value pairs.
      for instance: user => john password => 123
      
      will be parsed to the following TCL list:
      
      {{user john} {password 123}}
      
      Also added the following tests:
      
      Redirection still works with RESP3
      
      Able to use a RESP3 client as a redirection client
      
      No duplicate invalidation messages when turning BCAST mode on after normal tracking
      
      Server is able to evacuate enough keys when num of keys surpasses limit by more than defined initial effort
      
      Different clients using different protocols can track the same key
      
      OPTOUT tests
      
      OPTIN tests
      
      Clients can redirect to the same connection
      
      tracking-redir-broken test
      
      HELLO 3 checks
      
      Invalidation messages still work when using RESP3, with and without redirection
      
      Switching to RESP3 doesn't disturb previous tracked keys
      
      Tracking info is correct
      
      Flushall and flushdb produce invalidation messages
      
      These tests achieve 100% line coverage for tracking.c using lcov.
      19c29b60
    • Meir Shpilraien (Spielrein)'s avatar
      Moved RMAPI_FUNC_SUPPORTED location such that it will be visible to modules (#8037) · 97d647a1
      Meir Shpilraien (Spielrein) authored
      The RMAPI_FUNC_SUPPORTED was defined in the wrong place on redismodule.h
      and was not visible to modules.
      97d647a1
  12. 08 Nov, 2020 3 commits
  13. 05 Nov, 2020 4 commits
    • Wen Hui's avatar
      Debug Populate: Avoid server crash when passing negative value for key and value size (#8018) · 25436778
      Wen Hui authored
      * Debug Populate: Add checks for count and keysize to avoid crash
      
      * provide getRangeLongFromObjectOrReply and getPositiveLongFromObjectOrReply for range check
      25436778
    • Yossi Gottlieb's avatar
      Fix crash log output on ARM. (#8020) · 7e4325cb
      Yossi Gottlieb authored
      7e4325cb
    • Oran Agra's avatar
      Better INFO fields to track diskless and disk-based replication progress (#7981) · 7ace7231
      Oran Agra authored
      Expose new `loading_rdb_used_mem` showing the used memory of the server
      that saved the RDB file we're currently using.
      This is useful in diskless replication when the total size of the rdb is
      unkown, and can be used as a rought estimation of progres.
      
      Use that new field to calculate the "user friendly"
      `loading_loaded_perc` and `loading_eta_seconds`.
      
      Expose `master_sync_total_bytes` and `master_sync_total_bytes` to complement
      on the existing `master_sync_total_bytes` (which cannot be used on its own
      to calculate progress).
      
      Add "user friendly" field for `master_sync_perc`
      7ace7231
    • Yossi Gottlieb's avatar
      Add RESET command. (#7982) · 1fd456f9
      Yossi Gottlieb authored
      
      
      Perform full reset of all client connection states, is if the client was
      disconnected and re-connected. This affects:
      
      * MULTI state
      * Watched keys
      * MONITOR mode
      * Pub/Sub subscription
      * ACL/Authenticated state
      * Client tracking state
      * Cluster read-only/asking state
      * RESP version (reset to 2)
      * Selected database
      * CLIENT REPLY state
      
      The response is +RESET to make it easily distinguishable from other
      responses.
      Co-authored-by: default avatarOran Agra <oran@redislabs.com>
      Co-authored-by: default avatarItamar Haber <itamar@redislabs.com>
      1fd456f9
  14. 04 Nov, 2020 8 commits
  15. 03 Nov, 2020 3 commits