1. 20 Mar, 2015 2 commits
    • antirez's avatar
      Cluster: better cluster state transiction handling. · 62893f5b
      antirez authored
      Before we relied on the global cluster state to make sure all the hash
      slots are linked to some node, when getNodeByQuery() is called. So
      finding the hash slot unbound was checked with an assertion. However
      this is fragile. The cluster state is often updated in the
      clusterBeforeSleep() function, and not ASAP on state change, so it may
      happen to process clients with a cluster state that is 'ok' but yet
      certain hash slots set to NULL.
      
      With this commit the condition is also checked in getNodeByQuery() and
      reported with a identical error code of -CLUSTERDOWN but slightly
      different error message so that we have more debugging clue in the
      future.
      
      Root cause of issue #2288.
      62893f5b
    • antirez's avatar
      Cluster: move clusterBeforeSleep() call before unblocked clients processing. · 585f68ac
      antirez authored
      Related to issue #2288.
      585f68ac
  2. 18 Mar, 2015 1 commit
  3. 11 Feb, 2015 3 commits
  4. 23 Dec, 2014 1 commit
    • antirez's avatar
      INFO loading stats: three fixes. · 1e8f1577
      antirez authored
      1. Server unxtime may remain not updated while loading AOF, so ETA is
      not updated correctly.
      
      2. Number of processed byte was not initialized.
      
      3. Possible division by zero condition (likely cause of issue #1932).
      1e8f1577
  5. 19 Dec, 2014 1 commit
  6. 13 Dec, 2014 2 commits
  7. 04 Dec, 2014 1 commit
  8. 03 Dec, 2014 2 commits
  9. 02 Dec, 2014 1 commit
    • antirez's avatar
      Mark PFCOUNT as read-only, even if not true. · 69efb59a
      antirez authored
      PFCOUNT is technically speaking a write command, since the cached value
      of the HLL is exposed in the data structure (design error, mea culpa), and
      can be modified by PFCOUNT.
      
      However if we flag PFCOUNT as "w", read only slaves can't execute the
      command, which is a problem since there are environments where slaves
      are used to scale PFCOUNT reads.
      
      Nor it is possible to just prevent PFCOUNT to modify the data structure
      in slaves, since without the cache we lose too much efficiency.
      
      So while this commit allows slaves to create a temporary inconsistency
      (the strings representing the HLLs in the master and slave can be
      different in certain moments) it is actually harmless.
      
      In the long run this should be probably fixed by turning the HLL into a
      more opaque representation, for example by storing the cached value in
      the part of the string which is not exposed (this should be possible
      with SDS strings).
      69efb59a
  10. 12 Nov, 2014 1 commit
  11. 29 Oct, 2014 5 commits
  12. 06 Oct, 2014 2 commits
  13. 19 Sep, 2014 1 commit
  14. 17 Sep, 2014 1 commit
    • antirez's avatar
      Don't propagate SAVE. · ef61ab63
      antirez authored
      This is a general fix (check that dirty delta is positive) but actually
      should have as the only effect fixing the SAVE propagation to
      AOF and slaves.
      ef61ab63
  15. 08 Sep, 2014 1 commit
  16. 26 Aug, 2014 9 commits
  17. 28 Jul, 2014 1 commit
  18. 18 Jul, 2014 5 commits
    • antirez's avatar
      29e1c431
    • antirez's avatar
      Variadic PING with support for Pub/Sub. · 2264b981
      antirez authored
      PING can now be called with an additional arugment, behaving exactly
      like the ECHO command. PING can now also be called in Pub/Sub mode (with
      one more more subscriptions to channels / patterns) in order to trigger
      the delivery of an asynchronous pong message with the optional payload.
      
      This fixes issue #420.
      2264b981
    • antirez's avatar
      PubSub clients refactoring and new PUBSUB flag. · 23c14089
      antirez authored
      The code tested many times if a client had active Pub/Sub subscriptions
      by checking the length of a list and dictionary where the patterns and
      channels are stored. This was substituted with a client flag called
      REDIS_PUBSUB that is simpler to test for. Moreover in order to manage
      this flag some code was refactored.
      
      This commit is believed to have no effects in the behavior of the
      server.
      23c14089
    • michael-grunder's avatar
      Fix OBJECT arity · d75fc093
      michael-grunder authored
      Previously, the command definition for the OBJECT command specified
      a minimum of two args (and that it was variadic), which meant that
      if you sent this:
      
      OBJECT foo
      
      When cluster was enabled, it would result in an assertion/SEGFAULT
      when Redis was attempting to extract keys.
      
      It appears that OBJECT is not variadic, and only ever takes 3 args.
      
      https://gist.github.com/michael-grunder/25960ce1508396d0d36a
      d75fc093
    • antirez's avatar
      LATENCY DOCTOR first implementation complete. · a117fd2a
      antirez authored
      a117fd2a