1. 22 Jun, 2017 1 commit
  2. 16 Jun, 2017 1 commit
  3. 18 Apr, 2017 1 commit
  4. 20 Feb, 2017 1 commit
  5. 09 Nov, 2016 1 commit
    • antirez's avatar
      PSYNC2: different improvements to Redis replication. · 2669fb83
      antirez authored
      The gist of the changes is that now, partial resynchronizations between
      slaves and masters (without the need of a full resync with RDB transfer
      and so forth), work in a number of cases when it was impossible
      in the past. For instance:
      
      1. When a slave is promoted to mastrer, the slaves of the old master can
      partially resynchronize with the new master.
      
      2. Chained slalves (slaves of slaves) can be moved to replicate to other
      slaves or the master itsef, without requiring a full resync.
      
      3. The master itself, after being turned into a slave, is able to
      partially resynchronize with the new master, when it joins replication
      again.
      
      In order to obtain this, the following main changes were operated:
      
      * Slaves also take a replication backlog, not just masters.
      
      * Same stream replication for all the slaves and sub slaves. The
      replication stream is identical from the top level master to its slaves
      and is also the same from the slaves to their sub-slaves and so forth.
      This means that if a slave is later promoted to master, it has the
      same replication backlong, and can partially resynchronize with its
      slaves (that were previously slaves of the old master).
      
      * A given replication history is no longer identified by the `runid` of
      a Redis node. There is instead a `replication ID` which changes every
      time the instance has a new history no longer coherent with the past
      one. So, for example, slaves publish the same replication history of
      their master, however when they are turned into masters, they publish
      a new replication ID, but still remember the old ID, so that they are
      able to partially resynchronize with slaves of the old master (up to a
      given offset).
      
      * The replication protocol was slightly modified so that a new extended
      +CONTINUE reply from the master is able to inform the slave of a
      replication ID change.
      
      * REPLCONF CAPA is used in order to notify masters that a slave is able
      to understand the new +CONTINUE reply.
      
      * The RDB file was extended with an auxiliary field that is able to
      select a given DB after loading in the slave, so that the slave can
      continue receiving the replication stream from the point it was
      disconnected without requiring the master to insert "SELECT" statements.
      This is useful in order to guarantee the "same stream" property, because
      the slave must be able to accumulate an identical backlog.
      
      * Slave pings to sub-slaves are now sent in a special form, when the
      top-level master is disconnected, in order to don't interfer with the
      replication stream. We just use out of band "\n" bytes as in other parts
      of the Redis protocol.
      
      An old design document is available here:
      
      https://gist.github.com/antirez/ae068f95c0d084891305
      
      However the implementation is not identical to the description because
      during the work to implement it, different changes were needed in order
      to make things working well.
      2669fb83
  6. 06 Oct, 2016 1 commit
    • antirez's avatar
      Module: Ability to get context from IO context. · 152c1b68
      antirez authored
      It was noted by @dvirsky that it is not possible to use string functions
      when writing the AOF file. This sometimes is critical since the command
      rewriting may need to be built in the context of the AOF callback, and
      without access to the context, and the limited types that the AOF
      production functions will accept, this can be an issue.
      
      Moreover there are other needs that we can't anticipate regarding the
      ability to use Redis Modules APIs using the context in order to build
      representations to emit AOF / RDB.
      
      Because of this a new API was added that allows the user to get a
      temporary context from the IO context. The context is auto released
      if obtained when the RDB / AOF callback returns.
      
      Calling multiple time the function to get the context, always returns
      the same one, since it is invalid to have more than a single context.
      152c1b68
  7. 19 Sep, 2016 2 commits
  8. 11 Aug, 2016 1 commit
  9. 09 Aug, 2016 2 commits
  10. 21 Jul, 2016 1 commit
    • antirez's avatar
      Avoid simultaneous RDB and AOF child process. · 0a628e51
      antirez authored
      This patch, written in collaboration with Oran Agra (@oranagra) is a companion
      to 780a8b1d. Together the two patches should avoid that the AOF and RDB saving
      processes can be spawned at the same time. Previously conditions that
      could lead to two saving processes at the same time were:
      
      1. When AOF is enabled via CONFIG SET and an RDB saving process is
         already active.
      
      2. When the SYNC command decides to start an RDB saving process ASAP in
         order to serve a new slave that cannot partially resynchronize (but
         only if we have a disk target for replication, for diskless
         replication there is not such a problem).
      
      Condition "1" is not very severe but "2" can happen often and is
      definitely good at degrading Redis performances in an unexpected way.
      
      The two commits have the effect of always spawning RDB savings for
      replication in replicationCron() instead of attempting to start an RDB
      save synchronously. Moreover when a BGSAVE or AOF rewrite must be
      performed, they are instead just postponed using flags that will try to
      perform such operations ASAP.
      
      Finally the BGSAVE command was modified in order to accept a SCHEDULE
      option so that if an AOF rewrite is in progress, when this option is
      given, the command no longer returns an error, but instead schedules an
      RDB rewrite operation for when it will be possible to start it.
      0a628e51
  11. 03 Jun, 2016 1 commit
  12. 25 Apr, 2016 1 commit
  13. 15 Feb, 2016 1 commit
  14. 17 Nov, 2015 1 commit
  15. 13 Nov, 2015 1 commit
  16. 01 Oct, 2015 2 commits
  17. 27 Jul, 2015 2 commits
  18. 26 Jul, 2015 6 commits
  19. 17 Jul, 2015 1 commit
  20. 21 Jan, 2015 1 commit
    • antirez's avatar
      AOF rewrite: set iterator var to NULL when freed. · 4433f5a7
      antirez authored
      The cleanup code expects that if 'di' is not NULL, it is a valid
      iterator that should be freed.
      
      The result of this bug was a crash of the AOF rewriting process if an
      error occurred after the DBs data are written and the iterator is no
      longer valid.
      4433f5a7
  21. 02 Jan, 2015 1 commit
  22. 29 Sep, 2014 3 commits
    • Matt Stancliff's avatar
      Clean up text throughout project · 12d0195b
      Matt Stancliff authored
        - Remove trailing newlines from redis.conf
        - Fix comment misspelling
        - Clarifies zipEncodeLength usage and a C API mention (#1243, #1242)
        - Fix cluster typos (inspired by @papanikge #1507)
        - Fix rewite -> rewrite in a few places (inspired by #682)
      
      Closes #1243, #1242, #1507
      12d0195b
    • zionwu's avatar
      Fix incorrect comments · a2583466
      zionwu authored
      error != success; and 0 != number of bytes written
      
      Closes #1806
      a2583466
    • Jan-Erik Rediger's avatar
      Fix many small typos · 0cb87481
      Jan-Erik Rediger authored
      Closes #1871
      0cb87481
  23. 16 Sep, 2014 2 commits
    • antirez's avatar
      Seek at the end of AOF after truncate call. · 878c089e
      antirez authored
      It is not clear if files open in append only mode will automatically fix
      their offset after a truncate(2) operation. This commit makes sure that
      we reposition the AOF file descriptor offset at the end of the file
      after a truncated AOF is loaded and trimmed to the last valid command.
      878c089e
    • antirez's avatar
      On AOF end of file, truncate the AOF to last valid command. · 0ba8fe1a
      antirez authored
      Recently we introduced the ability to load truncated AOFs, but
      unfortuantely the support was broken since the server, after loading the
      truncated AOF, continues appending to the file that is corrupted at the
      end. The problem is fixed only in the next AOF rewrite.
      
      This commit fixes the issue by truncating the AOF to the last valid
      opcode, and aborting if it is not possible to truncate the file
      correctly.
      0ba8fe1a
  24. 08 Sep, 2014 3 commits
  25. 13 Aug, 2014 1 commit
  26. 08 Jul, 2014 1 commit