1. 04 Oct, 2013 3 commits
    • antirez's avatar
      Replication: fix master timeout. · 6d8c2a48
      antirez authored
      Since we started sending REPLCONF ACK from slaves to masters, the
      lastinteraction field of the client structure is always refreshed as
      soon as there is room in the socket output buffer, so masters in timeout
      are detected with too much delay (the socket buffer takes a lot of time
      to be filled by small REPLCONF ACK <number> entries).
      
      This commit only counts data received as interactions with a master,
      solving the issue.
      6d8c2a48
    • antirez's avatar
      PSYNC: safer handling of PSYNC requests. · d62ae1ec
      antirez authored
      There was a bug that over-esteemed the amount of backlog available,
      however this could only happen when a slave was asking for an offset
      that was in the "future" compared to the master replication backlog.
      
      Now this case is handled well and logged as an incident in the master
      log file.
      d62ae1ec
    • antirez's avatar
      Add REWRITE to CONFIG subcommands help message. · 4f9a6939
      antirez authored
      4f9a6939
  2. 26 Sep, 2013 1 commit
  3. 20 Sep, 2013 2 commits
    • antirez's avatar
      Cluster: PFAIL -> FAIL transition allowed for slaves. · 3c9bb875
      antirez authored
      First change: now there is no need to be a master in order to detect a
      failure, however the majority of masters signaling PFAIL or FAIL is needed.
      
      This change is important because it allows slaves rejoining the cluster
      after a partition to sense the FAIL condition so that eventually all the
      nodes agree on failures.
      3c9bb875
    • antirez's avatar
      Cluster: added time field in cluster bus messages. · 925ea9f8
      antirez authored
      The time is sent in requests, and copied back in reply packets.
      This way the receiver can compare the time field in a reply with its
      local clock and check the age of the request associated with this reply.
      
      This is an easy way to discard delayed replies. Note that only a clock
      is used here, that is the one of the node sending the packet. The
      receiver only copies the field back into the reply, so no
      synchronization is needed between clocks of different hosts.
      925ea9f8
  4. 17 Sep, 2013 1 commit
  5. 04 Sep, 2013 6 commits
  6. 03 Sep, 2013 5 commits
  7. 30 Aug, 2013 1 commit
  8. 29 Aug, 2013 2 commits
    • antirez's avatar
      Test: added a memory efficiency test. · f79b1cb4
      antirez authored
      f79b1cb4
    • antirez's avatar
      Fixed critical memory leak from EVAL. · 41d31473
      antirez authored
      Multiple missing calls to lua_pop prevented the error handler function
      pushed on the stack for lua_pcall() to be popped before returning,
      causing a memory leak in almost all the code paths of EVAL (both
      successful calls and calls returning errors).
      
      This caused two issues: Lua leaking memory (and this was very visible
      from INFO memory output, as the 'used_memory_lua' field reported an
      always increasing amount of memory used), and as a result slower and
      slower GC cycles resulting in all the CPU being used.
      
      Thanks to Tanguy Le Barzic for noticing something was wrong with his 2.8
      slave, and for creating a testing EC2 environment where I was able to
      investigate the issue.
      41d31473
  9. 27 Aug, 2013 9 commits
  10. 26 Aug, 2013 1 commit
    • antirez's avatar
      Don't update node pong time via gossip. · 303dde37
      antirez authored
      This feature was implemented in the initial days of the Redis Cluster
      implementaiton but is not a good idea at all.
      
      1) It depends on clocks to be synchronized, that is already very bad.
      2) Moreover it adds a bug where the pong time is updated via gossip so
      no new PING is ever sent by the current node, with the effect of no PONG
      received, no update of tables, no clearing of PFAIL flag.
      
      In general to trust other nodes about the reachability of other nodes is
      a broken distributed programming model.
      303dde37
  11. 22 Aug, 2013 6 commits
  12. 21 Aug, 2013 3 commits