1. 09 Jul, 2014 2 commits
    • antirez's avatar
      Latency monitor: collect slow commands. · 72c84acc
      antirez authored
      We introduce the distinction between slow and fast commands since those
      are two different sources of latency. An O(1) or O(log N) command without
      side effects (can't trigger deletion of large objects as a side effect of
      its execution) if delayed is a symptom of inherent latency of the system.
      
      A non-fast command (commands that may run large O(N) computations) if
      delayed may just mean that the user is executing slow operations.
      
      The advices LATENCY should provide in this two different cases are
      different, so we log the two classes of commands in a separated way.
      72c84acc
    • antirez's avatar
      Latency monitor: basic samples collection. · 58ecc0bd
      antirez authored
      58ecc0bd
  2. 02 Jul, 2014 1 commit
  3. 30 Jun, 2014 1 commit
  4. 27 Jun, 2014 8 commits
    • antirez's avatar
      COMMAND COUNT subcommand added. · 63feb93a
      antirez authored
      63feb93a
    • antirez's avatar
      COMMAND: fix argument parsing. · 0a6649a7
      antirez authored
      This fixes detection of wrong subcommand (that resulted in the default
      all-commands output instead) and allows COMMAND INFO to be called
      without arguments (resulting into an empty array) which is useful in
      programmtically generated calls like the following (in Ruby):
      
          redis.commands("command","info",*mycommands)
      
      Note: mycommands may be empty.
      0a6649a7
    • antirez's avatar
      COMMANDS command renamed COMMAND. · 53377f8c
      antirez authored
      53377f8c
    • antirez's avatar
      COMMANDS command: remove static + aesthetic changes. · f3efd529
      antirez authored
      Static was removed since it is needed in order to get symbols in stack
      traces. Minor changes in the source code were operated to make it more
      similar to the existing Redis code base.
      f3efd529
    • Matt Stancliff's avatar
      Cluster: Add COMMANDS command · fdc5dbd5
      Matt Stancliff authored
      COMMANDS returns a nested multibulk reply for each
      command in the command table.  The reply for each
      command contains:
        - command name
        - arity
        - array of command flags
        - start key position
        - end key position
        - key offset step
        - optional: if the keys are not deterministic and
          Redis uses an internal key evaluation function,
          the 6th field appears and is defined as a status
          reply of: REQUIRES ARGUMENT PARSING
      
      Cluster clients need to know where the keys are in each
      command to implement proper routing to cluster nodes.
      
      Redis commands can have multiple keys, keys at offset steps, or other
      issues where you can't always assume the first element after
      the command name is the cluster routing key.
      
      Using the information exposed by COMMANDS, client implementations
      can have live, accurate key extraction details for all commands.
      
      Also implements COMMANDS INFO [commands...] to return only a
      specific set of commands instead of all 160+ commands live in Redis.
      fdc5dbd5
    • Matt Stancliff's avatar
      Allow __powerpc__ to define HAVE_ATOMIC too · cd4f0dc7
      Matt Stancliff authored
      From mailing list post https://groups.google.com/forum/#!topic/redis-db/D3k7KmJmYgM
      
      In the file “config.h”, the definition HAVE_ATOMIC is used to indicate
      if an architecture on which redis is implemented supports atomic
      synchronization primitives.  Powerpc  supports atomic synchronization
      primitives, however, it is not listed as one of the architectures
      supported in config.h. This patch  adds the __powerpc__ to the list of
      architectures supporting these primitives. The improvement of redis
      due to the atomic synchronization on powerpc is significant,
      around 30% to 40%, over the default implementation using pthreads.
      
      This proposal adds __powerpc__ to the list of architectures designated
      to support atomic builtins.
      cd4f0dc7
    • Matt Stancliff's avatar
      Allow atomic memory count update with C11 builtins · 58fea469
      Matt Stancliff authored
      From mailing list post https://groups.google.com/forum/#!topic/redis-db/QLjiQe4D7LA
      
      In zmalloc.c the following primitives are currently used
      to synchronize access to single global variable:
      __sync_add_and_fetch
      __sync_sub_and_fetch
      
      In some architectures such as powerpc these primitives are overhead
      intensive. More efficient C11 __atomic builtins are available with
      newer GCC versions, see
      http://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/_005f_005fatomic-Builtins.html#_005f_005fatomic-Builtins
      
      By substituting the following  __atomic… builtins:
      __atomic_add_fetch
      __atomic_sub_fetch
      
      the performance improvement on certain architectures such as powerpc can be significant,
      around 10% to 15%, over the implementation using __sync builtins while there is only slight uptick on
      Intel architectures because it was already enforcing Intel Strongly ordered memory semantics.
      
      The selection of __atomic built-ins can be predicated on the definition of ATOMIC_RELAXED
      which Is available on in gcc 4.8.2 and later versions.
      58fea469
    • Matt Stancliff's avatar
      ff3ca17b
  5. 26 Jun, 2014 2 commits
  6. 24 Jun, 2014 1 commit
  7. 23 Jun, 2014 6 commits
  8. 21 Jun, 2014 14 commits
    • antirez's avatar
      Allow to call ROLE in LOADING state. · 2b805ce1
      antirez authored
      2b805ce1
    • antirez's avatar
      ROLE command: array len fixed for slave output. · 8c460a28
      antirez authored
      8c460a28
    • antirez's avatar
      Sentinel: send SLAVEOF with MULTI, CLIENT KILL, CONFIG REWRITE. · 7d0992da
      antirez authored
      This implements the new Sentinel-Client protocol for the Sentinel part:
      now instances are reconfigured using a transaction that ensures that the
      config is rewritten in the target instance, and that clients lose the
      connection with the instance, in order to be forced to: ask Sentinel,
      reconnect to the instance, and verify the instance role with the new
      ROLE command.
      7d0992da
    • antirez's avatar
      CLIENT KILL API modified. · 674194ad
      antirez authored
      Added a new SKIPME option that is true by default, that prevents the
      client sending the command to be killed, unless SKIPME NO is sent.
      674194ad
    • antirez's avatar
      61d9a73d
    • antirez's avatar
      New features for CLIENT KILL. · 09dc6dad
      antirez authored
      09dc6dad
    • antirez's avatar
      Assign an unique non-repeating ID to each new client. · cad13223
      antirez authored
      This will be used by CLIENT KILL and is also a good way to ensure a
      given client is still the same across CLIENT LIST calls.
      
      The output of CLIENT LIST was modified to include the new ID, but this
      change is considered to be backward compatible as the API does not imply
      you can do positional parsing, since each filed as a different name.
      cad13223
    • antirez's avatar
      Client types generalized. · b6a26b52
      antirez authored
      Because of output buffer limits Redis internals had this idea of type of
      clients: normal, pubsub, slave. It is possible to set different output
      buffer limits for the three kinds of clients.
      
      However all the macros and API were named after output buffer limit
      classes, while the idea of a client type is a generic one that can be
      reused.
      
      This commit does two things:
      
      1) Rename the API and defines with more general names.
      2) Change the class of clients executing the MONITOR command from "slave"
         to "normal".
      
      "2" is a good idea because you want to have very special settings for
      slaves, that are not a good idea for MONITOR clients that are instead
      normal clients even if they are conceptually slave-alike (since it is a
      push protocol).
      
      The backward-compatibility breakage resulting from "2" is considered to
      be minimal to care, since MONITOR is a debugging command, and because
      anyway this change is not going to break the format or the behavior, but
      just when a connection is closed on big output buffer issues.
      b6a26b52
    • antirez's avatar
      ROLE output improved for slaves. · 8060de98
      antirez authored
      Info about the replication state with the master added.
      8060de98
    • antirez's avatar
      ROLE command added. · 41a15205
      antirez authored
      The new ROLE command is designed in order to provide a client with
      informations about the replication in a fast and easy to use way
      compared to the INFO command where the same information is also
      available.
      41a15205
    • antirez's avatar
      CLIENT LIST speedup via peerid caching + smart allocation. · d8d415e7
      antirez authored
      This commit adds peer ID caching in the client structure plus an API
      change and the use of sdsMakeRoomFor() in order to improve the
      reallocation pattern to generate the CLIENT LIST output.
      
      Both the changes account for a very significant speedup.
      d8d415e7
    • antirez's avatar
      52189cb9
    • antirez's avatar
      Added new sdscatfmt() %u and %U format specifiers. · 4acc3daa
      antirez authored
      This commit also fixes a bug in the implementation of sdscatfmt()
      resulting from stale references to the SDS string header after
      sdsMakeRoomFor() calls.
      4acc3daa
    • antirez's avatar
      sdscatfmt() added to SDS library. · 3a915ace
      antirez authored
      sdscatprintf() relies on printf() family libc functions and is sometimes
      too slow in critical code paths. sdscatfmt() is an alternative which is:
      
      1) Far less capable.
      2) Format specifier uncompatible.
      3) Faster.
      
      It is suitable to be used in those speed critical code paths such as
      CLIENT LIST output generation.
      3a915ace
  9. 19 Jun, 2014 2 commits
    • antirez's avatar
      Sentinel: send hello messages ASAP after config change. · 93ee0f26
      antirez authored
      Eventual configuration convergence is guaranteed by our periodic hello
      messages to all the instances, however when there are important notices
      to share, better make a phone call. With this commit we force an hello
      message to other Sentinal and Redis instances within the next 100
      milliseconds of a config update, which is practically better than
      waiting a few seconds.
      93ee0f26
    • antirez's avatar
      Sentinel: handle SRI_PROMOTED flag correctly. · 9b883974
      antirez authored
      Lack of check of the SRI_PROMOTED flag caused Sentienl to act with the
      promoted slave turned into a master during failover like if it was a
      normal instance.
      
      Normally this problem was not apparent because during real failovers the
      old master is down so the bugged code path was not entered, however with
      manual failovers via the SENTINEL FAILOVER command, the problem was
      easily triggered.
      
      This commit prevents promoted slaves from getting reconfigured, moreover
      we now explicitly check that during a failover the slave turning into a
      master is the one we selected for promotion and not a different one.
      9b883974
  10. 18 Jun, 2014 1 commit
  11. 17 Jun, 2014 1 commit
  12. 16 Jun, 2014 1 commit
    • antirez's avatar
      Fix semantics of Lua calls to SELECT. · ca6b95df
      antirez authored
      Lua scripts are executed in the context of the currently selected
      database (as selected by the caller of the script).
      
      However Lua scripts are also free to use the SELECT command in order to
      affect other DBs. When SELECT is called frm Lua, the old behavior, before
      this commit, was to automatically set the Lua caller selected DB to the
      last DB selected by Lua. See for example the following sequence of
      commands:
      
          SELECT 0
          SET x 10
          EVAL "redis.call('select','1')" 0
          SET x 20
      
      Before this commit after the execution of this sequence of commands,
      we'll have x=10 in DB 0, and x=20 in DB 1.
      
      Because of the problem above, there was a bug affecting replication of
      Lua scripts, because of the actual implementation of replication. It was
      possible to fix the implementation of Lua scripts in order to fix the
      issue, but looking closely, the bug is the consequence of the behavior
      of Lua ability to set the caller's DB.
      
      Under the old semantics, a script selecting a different DB, has no simple
      ways to restore the state and select back the previously selected DB.
      Moreover the script auhtor must remember that the restore is needed,
      otherwise the new commands executed by the caller, will be executed in
      the context of a different DB.
      
      So this commit fixes both the replication issue, and this hard-to-use
      semantics, by removing the ability of Lua, after the script execution,
      to force the caller to switch to the DB selected by the Lua script.
      
      The new behavior of the previous sequence of commadns is to just set
      X=20 in DB 0. However Lua scripts are still capable of writing / reading
      from different DBs if needed.
      
      WARNING: This is a semantical change that will break programs that are
      conceived to select the client selected DB via Lua scripts.
      
      This fixes issue #1811.
      ca6b95df