1. 02 Apr, 2020 2 commits
  2. 01 Apr, 2020 1 commit
    • Guy Benoish's avatar
      Fix memory corruption in moduleHandleBlockedClients · c4dc5b80
      Guy Benoish authored
      By using a "circular BRPOPLPUSH"-like scenario it was
      possible the get the same client on db->blocking_keys
      twice (See comment in moduleTryServeClientBlockedOnKey)
      
      The fix was actually already implememnted in
      moduleTryServeClientBlockedOnKey but it had a bug:
      the funxction should return 0 or 1 (not OK or ERR)
      
      Other changes:
      1. Added two commands to blockonkeys.c test module (To
         reproduce the case described above)
      2. Simplify blockonkeys.c in order to make testing easier
      3. cast raxSize() to avoid warning with format spec
      c4dc5b80
  3. 31 Mar, 2020 6 commits
  4. 30 Mar, 2020 4 commits
  5. 29 Mar, 2020 1 commit
  6. 28 Mar, 2020 2 commits
  7. 27 Mar, 2020 9 commits
  8. 26 Mar, 2020 1 commit
  9. 25 Mar, 2020 3 commits
    • Oran Agra's avatar
      AOFRW on an empty stream created with MKSTREAM loads badkly · 3b29556a
      Oran Agra authored
      the AOF will be loaded successfully, but the stream will be missing,
      i.e inconsistencies with the original db.
      
      this was because XADD with id of 0-0 would error.
      
      add a test to reproduce.
      3b29556a
    • antirez's avatar
      PSYNC2: meaningful offset implemented. · 57fa355e
      antirez authored
      A very commonly signaled operational problem with Redis master-replicas
      sets is that, once the master becomes unavailable for some reason,
      especially because of network problems, many times it wont be able to
      perform a partial resynchronization with the new master, once it rejoins
      the partition, for the following reason:
      
      1. The master becomes isolated, however it keeps sending PINGs to the
      replicas. Such PINGs will never be received since the link connection is
      actually already severed.
      2. On the other side, one of the replicas will turn into the new master,
      setting its secondary replication ID offset to the one of the last
      command received from the old master: this offset will not include the
      PINGs sent by the master once the link was already disconnected.
      3. When the master rejoins the partion and is turned into a replica, its
      offset will be too advanced because of the PINGs, so a PSYNC will fail,
      and a full synchronization will be required.
      
      Related to issue #7002 and other discussion we had in the past around
      this problem.
      57fa355e
    • antirez's avatar
      Explain why we allow transactions in -BUSY state. · f15042db
      antirez authored
      Related to #7022.
      f15042db
  10. 23 Mar, 2020 8 commits
  11. 22 Mar, 2020 3 commits