1. 03 Dec, 2019 1 commit
  2. 02 Dec, 2019 9 commits
  3. 01 Dec, 2019 2 commits
  4. 29 Nov, 2019 1 commit
  5. 28 Nov, 2019 2 commits
    • Oran Agra's avatar
      Converting more configs to use generic infra, and moving defaults to config.c · 18e72c5c
      Oran Agra authored
      Changes in behavior:
      - Change server.stream_node_max_entries from int64_t to long long, so that it can be used by the generic infra
      - standard error reply instead of "repl-backlog-size must be 1 or greater" and such
      - tls-port and a few TLS booleans were readable (config get) even when USE_OPENSSL was off (now they aren't)
      - syslog-enabled, syslog-ident, cluster-enabled, appendfilename, and supervised didn't have a get (now they do)
      - pidfile was initialized to NULL in InitServerConfig but had CONFIG_DEFAULT_PID_FILE in rewriteConfig (so the real default was "", but rewrite would cause it to be set), fixed the rewrite.
      - TLS config in server.h was uninitialized (if no tls config args were provided)
      
      Adding test for sanity and coverage
      18e72c5c
    • Oran Agra's avatar
      More improvements and fixes to generic config infra · 28beb05a
      Oran Agra authored
      - Adding is_valid_fn and update_fn, both return 1 for success and 0 for failure with an optional error message.
      - Bugfix in handling boundary check of unsigned numeric types (was boundaries as signed)
      - Adding more numeric types to generic mechanism: uint, ulonglong, long, time_t, off_t
      - More verbose error replies ("argument must be between" in out of range CONFIG SET (like config file parsing)
      28beb05a
  6. 26 Nov, 2019 1 commit
    • Oran Agra's avatar
      Additional config.c refactory and bugfixes · e0cc3c99
      Oran Agra authored
      - add capability for each config to have a callback to check if value is valid and return error string
        will enable converting many of the remaining custom configs into generic ones (reducing the x4 repetition for set,get,config,rewrite)
      - add capability for each config to  to run some update code after config is changed (only for CONFIG SET)
        will also enable converting many of the remaining custom configs into generic ones
      - add capability to move default values from server.h and server.c to config.c
        will reduce many excess lines in server.h and server.c (plus, no need to rebuild the entire code base when a default change 8-))
      
      other behavior changes:
      - fix bug in bool config get (always returning 'yes')
      - fix a bug in modifying jemalloc-bg-thread at runtime (didn't call set_jemalloc_bg_thread, due to bad merge conflict resolution (my fault))
      - side effect when a failed attempt to enable activedefrag at runtime, we now respond with -ERR and not with -DISABLED
      e0cc3c99
  7. 25 Nov, 2019 4 commits
  8. 22 Nov, 2019 6 commits
  9. 21 Nov, 2019 7 commits
  10. 20 Nov, 2019 4 commits
  11. 19 Nov, 2019 3 commits
    • Oran Agra's avatar
      try to fix an unstable test (module hook for loading progress) · ed226976
      Oran Agra authored
      there were two lssues, one is taht BGREWRITEAOF failed since the initial one was still in progress
      the solution for this one is to enable appendonly from the server startup so there's no initial aofrw.
      
      the other problem was 0 loading progress events, theory is that on some
      platforms a sleep of 1 will cause a much greater delay due to the context
      switch, but on other platform it doesn't. in theory a sleep of 100 micro
      for 1k keys whould take 100ms, and with hz of 500 we should be gettering
      50 events (one every 2ms). in practise it doesn't work like that, so trying
      to find a sleep that would be long enough but still not cause the test to take
      too long.
      ed226976
    • Salvatore Sanfilippo's avatar
      Merge pull request #6541 from artix75/module-long-double · 45025713
      Salvatore Sanfilippo authored
      Module API: add support for long double conversions and replies
      45025713
    • Salvatore Sanfilippo's avatar
      e7144fbe