- 26 Sep, 2013 4 commits
- 25 Sep, 2013 7 commits
- 20 Sep, 2013 2 commits
-
-
antirez authored
First change: now there is no need to be a master in order to detect a failure, however the majority of masters signaling PFAIL or FAIL is needed. This change is important because it allows slaves rejoining the cluster after a partition to sense the FAIL condition so that eventually all the nodes agree on failures.
-
antirez authored
The time is sent in requests, and copied back in reply packets. This way the receiver can compare the time field in a reply with its local clock and check the age of the request associated with this reply. This is an easy way to discard delayed replies. Note that only a clock is used here, that is the one of the node sending the packet. The receiver only copies the field back into the reply, so no synchronization is needed between clocks of different hosts.
-
- 17 Sep, 2013 1 commit
-
-
antirez authored
-
- 04 Sep, 2013 6 commits
-
-
antirez authored
-
antirez authored
Handshake nodes should turn into normal nodes or be freed in a reasonable amount of time, otherwise they'll keep accumulating if the address they are associated with is not reachable for some reason.
-
antirez authored
The code freed a reply object that was never created, resulting in a segfault every time randomkey returned a key that was deleted before we queried it for size.
-
antirez authored
-
antirez authored
-
antirez authored
-
- 03 Sep, 2013 5 commits
-
-
Maxim Zakharov authored
-
Maxim Zakharov authored
-
antirez authored
-
antirez authored
-
antirez authored
The code used to copy the header *after* the 'hdr' pointer was already switched to the new buffer. Of course we need to do the reverse.
-
- 30 Aug, 2013 1 commit
-
-
antirez authored
-
- 29 Aug, 2013 2 commits
-
-
antirez authored
-
antirez authored
Multiple missing calls to lua_pop prevented the error handler function pushed on the stack for lua_pcall() to be popped before returning, causing a memory leak in almost all the code paths of EVAL (both successful calls and calls returning errors). This caused two issues: Lua leaking memory (and this was very visible from INFO memory output, as the 'used_memory_lua' field reported an always increasing amount of memory used), and as a result slower and slower GC cycles resulting in all the CPU being used. Thanks to Tanguy Le Barzic for noticing something was wrong with his 2.8 slave, and for creating a testing EC2 environment where I was able to investigate the issue.
-
- 27 Aug, 2013 9 commits
-
-
yihuang authored
-
antirez authored
-
antirez authored
We are sure the string is large, since when the sds optimization branch is entered it means that it was not possible to encode it as EMBSTR for size concerns.
-
antirez authored
When no encoding is possible, at least try to reallocate the sds string with one that does not waste memory (with free space at the end of the buffer) when the string is large enough.
-
antirez authored
We are sure that a string that is longer than 21 chars cannot be represented by a 64 bit signed integer, as -(2^64) is 21 chars: strlen(-18446744073709551616) => 21
-
antirez authored
The call to sdsMakeRoomFor() did not accounted for the amount of data already present in the query buffer, resulting into over-allocation.
-
antirez authored
This command is only useful for low-level debugging of memory issues due to sds wasting memory as empty buffer at the end of the string.
-
antirez authored
-
antirez authored
-
- 26 Aug, 2013 1 commit
-
-
antirez authored
This feature was implemented in the initial days of the Redis Cluster implementaiton but is not a good idea at all. 1) It depends on clocks to be synchronized, that is already very bad. 2) Moreover it adds a bug where the pong time is updated via gossip so no new PING is ever sent by the current node, with the effect of no PONG received, no update of tables, no clearing of PFAIL flag. In general to trust other nodes about the reachability of other nodes is a broken distributed programming model.
-
- 22 Aug, 2013 2 commits