1. 08 May, 2014 2 commits
    • antirez's avatar
      DEBUG embstr-classes added. · 7c6b8ec6
      antirez authored
      7c6b8ec6
    • antirez's avatar
      Use a free list for EMBSTR objects creation / release. · 19f735ce
      antirez authored
      To my surprise, mantaining a small poll of objects provides a very big
      speedup even when the jemalloc allocator is used, which is supposed to
      have arenas doing mostly the same work.
      
      Probably this is a combination of different factors:
      
      1) No need to manage zmalloc total memory used.
      2) No locking of any kind because we can assume single thread, so
         maintaining the free list may be cheaper for us compared to
         jemalloc.
      3) More locality because of a different cache/reuse pattern?
      19f735ce
  2. 07 May, 2014 10 commits
  3. 29 Apr, 2014 1 commit
    • antirez's avatar
      CLUSTER SET-CONFIG-EPOCH implemented. · 11d9ecb7
      antirez authored
      Initially Redis Cluster accepted that after cluster creation all the
      nodes were at configEpoch 0, evolving from zero as failovers happen.
      
      However later the semantic was made more strict in order to make sure a
      cluster has always all the master nodes with a different configEpoch,
      which is more robust in some corner case (especially resulting from
      errors by the system administrator).
      
      To assign different configEpochs to different nodes at startup was a
      task performed naturally by the config conflicts resolution algorithm
      (see the Cluster specification). However this works well only for small
      clusters or when there are actually just a few collisions, since it is
      designed for exceptional cases.
      
      When a large cluster is created hundred of nodes can be at epoch 0, so
      the conflict resolution code is slow to provide an unique config to each
      node. For this reason this new command was introduced. It can be called
      only when a node is totally fresh: no other nodes known, and configEpoch
      set to zero, so it is safe even against misuses.
      
      redis-trib will use the new command in order to start the cluster
      already setting an incremental unique config to every node.
      11d9ecb7
  4. 28 Apr, 2014 4 commits
  5. 24 Apr, 2014 6 commits
    • antirez's avatar
      Process events with processEventsWhileBlocked() when blocked. · e29d3307
      antirez authored
      When we are blocked and a few events a processed from time to time, it
      is smarter to call the event handler a few times in order to handle the
      accept, read, write, close cycle of a client in a single pass, otherwise
      there is too much latency added for clients to receive a reply while the
      server is busy in some way (for example during the DB loading).
      e29d3307
    • antirez's avatar
      Accept multiple clients per iteration. · 3a3458ee
      antirez authored
      When the listening sockets readable event is fired, we have the chance
      to accept multiple clients instead of accepting a single one. This makes
      Redis more responsive when there is a mass-connect event (for example
      after the server startup), and in workloads where a connect-disconnect
      pattern is used often, so that multiple clients are waiting to be
      accepted continuously.
      
      As a side effect, this commit makes the LOADING, BUSY, and similar
      errors much faster to deliver to the client, making Redis more
      responsive when there is to return errors to inform the clients that the
      server is blocked in an not interruptible operation.
      3a3458ee
    • antirez's avatar
      AE_ERR -> ANET_ERR in acceptUnixHandler(). · cac4bae1
      antirez authored
      No actual changes since the value is the same.
      cac4bae1
    • antirez's avatar
      7d9b45b4
    • antirez's avatar
      clusterLoadConfig() REDIS_ERR retval semantics refined. · e3cf812c
      antirez authored
      We should return REDIS_ERR to signal we can't read the configuration
      because there is no config file only after checking errno, othewise
      we risk to rewrite an existing file that was not accessible for some
      other reason.
      e3cf812c
    • antirez's avatar
      Lock nodes.conf to avoid multiple processes using the same file. · db06108b
      antirez authored
      This was a common source of problems among users.
      The solution adopted is not bullet-proof as if the user deletes the
      nodes.conf file manually, and starts a new instance with the same
      nodes.conf file path, two instances will use the same file. However
      following this reasoning the user may drop a nuclear bomb into the
      datacenter as well.
      db06108b
  6. 23 Apr, 2014 2 commits
    • Glauber Costa's avatar
      fix null pointer access with no file pointer · 7dd44327
      Glauber Costa authored
      I happen to be working on a system that lacks urandom. While the code does try
      to handle this case and artificially create some bytes if the file pointer is
      empty, it does try to close it unconditionally, leading to a segfault.
      7dd44327
    • antirez's avatar
      Missing return REDIS_ERR added to processMultibulkBuffer(). · cb4e2ee9
      antirez authored
      When we set a protocol error we should return with REDIS_ERR to let the
      caller know it should stop processing the client.
      
      Bug found in a code auditing related to issue #1699.
      cb4e2ee9
  7. 22 Apr, 2014 2 commits
  8. 18 Apr, 2014 1 commit
  9. 17 Apr, 2014 7 commits
  10. 16 Apr, 2014 4 commits
  11. 15 Apr, 2014 1 commit