1. 25 Feb, 2014 18 commits
  2. 20 Feb, 2014 10 commits
  3. 18 Feb, 2014 2 commits
    • antirez's avatar
      Sentinel: SENTINEL_SLAVE_RECONF_RETRY_PERIOD -> RECONF_TIMEOUT · 6e4662e4
      antirez authored
      Rename define to match the new meaning.
      6e4662e4
    • antirez's avatar
      Sentinel: fix slave promotion timeout. · bd31fcf1
      antirez authored
      If we can't reconfigure a slave in time during failover, go forward as
      anyway the slave will be fixed by Sentinels in the future, once they
      detect it is misconfigured.
      
      Otherwise a failover in progress may never terminate if for some reason
      the slave is uncapable to sync with the master while at the same time
      it is not disconnected.
      bd31fcf1
  4. 17 Feb, 2014 5 commits
    • antirez's avatar
      Sentinel: initial testing framework. · 2a35abcf
      antirez authored
      Nothing tested at all so far... Just the infrastructure spawning N
      Sentinels and N Redis instances that the test will use again and again.
      2a35abcf
    • antirez's avatar
      Test: colorstr moved to util.tcl. · c1786693
      antirez authored
      c1786693
    • antirez's avatar
      Test: code to test server availability refactored. · 48af4d4f
      antirez authored
      Some inline test moved into server_is_up procedure.
      Also find_available_port was moved into util since it is going
      to be used for the Sentinel test as well.
      48af4d4f
    • antirez's avatar
      Get absoulte config file path before processig 'dir'. · 58b6dd9b
      antirez authored
      The code tried to obtain the configuration file absolute path after
      processing the configuration file. However if config file was a relative
      path and a "dir" statement was processed reading the config, the absolute
      path obtained was wrong.
      
      With this fix the absolute path is obtained before processing the
      configuration while the server is still in the original directory where
      it was executed.
      58b6dd9b
    • antirez's avatar
      Sentinel: better specify startup errors due to config file. · c36a5dce
      antirez authored
      Now it logs the file name if it is not accessible. Also there is a
      different error for the missing config file case, and for the non
      writable file case.
      c36a5dce
  5. 13 Feb, 2014 4 commits
    • antirez's avatar
      Update cached time in rdbLoad() callback. · 3c1672da
      antirez authored
      server.unixtime and server.mstime are cached less precise timestamps
      that we use every time we don't need an accurate time representation and
      a syscall would be too slow for the number of calls we require.
      
      Such an example is the initialization and update process of the last
      interaction time with the client, that is used for timeouts.
      
      However rdbLoad() can take some time to load the DB, but at the same
      time it did not updated the time during DB loading. This resulted in the
      bug described in issue #1535, where in the replication process the slave
      loads the DB, creates the redisClient representation of its master, but
      the timestamp is so old that the master, under certain conditions, is
      sensed as already "timed out".
      
      Thanks to @yoav-steinberg and Redis Labs Inc for the bug report and
      analysis.
      3c1672da
    • antirez's avatar
      Log when CONFIG REWRITE goes bad. · 116617c5
      antirez authored
      116617c5
    • antirez's avatar
      Test: regression for issue #1549. · 767846dc
      antirez authored
      It was verified that reverting the commit that fixes the bug, the test
      no longer passes.
      767846dc
    • antirez's avatar
      Fix script cache bug in the scripting engine. · 14143fbe
      antirez authored
      This commit fixes a serious Lua scripting replication issue, described
      by Github issue #1549. The root cause of the problem is that scripts
      were put inside the script cache, assuming that slaves and AOF already
      contained it, even if the scripts sometimes produced no changes in the
      data set, and were not actaully propagated to AOF/slaves.
      
      Example:
      
          eval "if tonumber(KEYS[1]) > 0 then redis.call('incr', 'x') end" 1 0
      
      Then:
      
          evalsha <sha1 step 1 script> 1 0
      
      At this step sha1 of the script is added to the replication script cache
      (the script is marked as known to the slaves) and EVALSHA command is
      transformed to EVAL. However it is not dirty (there is no changes to db),
      so it is not propagated to the slaves. Then the script is called again:
      
          evalsha <sha1 step 1 script> 1 1
      
      At this step master checks that the script already exists in the
      replication script cache and doesn't transform it to EVAL command. It is
      dirty and propagated to the slaves, but they fail to evaluate the script
      as they don't have it in the script cache.
      
      The fix is trivial and just uses the new API to force the propagation of
      the executed command regardless of the dirty state of the data set.
      
      Thank you to @minus-infinity on Github for finding the issue,
      understanding the root cause, and fixing it.
      14143fbe
  6. 12 Feb, 2014 1 commit