1. 26 Jan, 2016 4 commits
    • antirez's avatar
    • antirez's avatar
      Better address udpate strategy when processing gossip sections. · bd998b7d
      antirez authored
      The change covers the case where:
      
      1. There is a node we can't reach (in fail or pfail state).
      2. We see a different address for this node, in the gossip section sent
      to us by a node that, instead, is able to talk with the node we cannot
      talk to.
      
      In this case it's a good bet to switch to the address reported by this
      node, since there was an address switch and it is able to talk with the
      node and we are not.
      
      However previosuly this was done in a dangerous way, by initiating an
      handshake. The handshake, using the MEET packet, forces the receiver to
      join our cluster, and this is not a good idea. If the node in question
      really just switched address, but is the same node, it already knows about
      us, so we just need to perform an address update and a reconnection.
      
      So with this commit instead we just update the address of the node,
      release the node link if any, and attempt to reconnect in the next
      clusterCron() cycle.
      
      The commit also improves debugging messages printed by Cluster during
      address or ID switches.
      bd998b7d
    • antirez's avatar
      73e4e40e
    • Itamar Haber's avatar
      27be786c
  2. 25 Jan, 2016 16 commits
  3. 19 Jan, 2016 1 commit
  4. 08 Jan, 2016 8 commits
    • antirez's avatar
      Scripting: handle trailing comments. · 5fd61c95
      antirez authored
      This fix, provided by Paul Kulchenko (@pkulchenko), allows the Lua
      scripting engine to evaluate statements with a trailing comment like the
      following one:
      
          EVAL "print() --comment" 0
      
      Lua can't parse the above if the string does not end with a newline, so
      now a final newline is always added automatically. This does not change
      the SHA1 of scripts since the SHA1 is computed on the body we pass to
      EVAL, without the other code we add to register the function.
      
      Close #2951.
      5fd61c95
    • antirez's avatar
      Allow MIGRATE to always be called on local keys for open slots. · d975baa3
      antirez authored
      Extend the MIGRATE extra freedom to be able to be called in the context
      of the local slot, anytime there is a slot open in one or the other
      direction (importing or migrating). This is useful for redis-trib to fix
      the cluster when it has in an odd state.
      
      Thix fix allows "redis-trib fix" to make its work in certain cases where
      previously an error was reported.
      d975baa3
    • antirez's avatar
    • antirez's avatar
      Lua debugger: support direct calls to SCRIPT DEBUG in redis-cli. · 6cbd5596
      antirez authored
      Previously it was possible to activate a debugging session only using
      the --ldb option in redis-cli. Now calling SCRIPT DEBUG can also
      activate the debugging mode without putting the redis-cli in a
      desynchronized state.
      
      Related to #2952.
      6cbd5596
    • antirez's avatar
      Lua debugger: fix crash printing nested or deep objects. · 8cc1a49e
      antirez authored
      Example of offending code:
      
      > script debug yes
      OK
      > eval "local a = {1} a[1] = a\nprint(a)" 0
      1) * Stopped at 1, stop reason = step over
      2) -> 1   local a = {1} a[1] = a
      > next
      1) * Stopped at 2, stop reason = step over
      2) -> 2   print(a)
      > print
      
      ... server crash ...
      
      Close #2955.
      8cc1a49e
    • antirez's avatar
      Another typo in protected mode error message. · d256abe9
      antirez authored
      d256abe9
    • antirez's avatar
      Fix protected mode error message typo. · 06846152
      antirez authored
      06846152
    • antirez's avatar
      New security feature: Redis protected mode. · 273c49e7
      antirez authored
      An exposed Redis instance on the internet can be cause of serious
      issues. Since Redis, by default, binds to all the interfaces, it is easy
      to forget an instance without any protection layer, for error.
      
      Protected mode try to address this feature in a soft way, providing a
      layer of protection, but giving clues to Redis users about why the
      server is not accepting connections.
      
      When protected mode is enabeld (the default), and if there are no
      minumum hints about the fact the server is properly configured (no
      "bind" directive is used in order to restrict the server to certain
      interfaces, nor a password is set), clients connecting from external
      intefaces are refused with an error explaining what to do in order to
      fix the issue.
      
      Clients connecting from the IPv4 and IPv6 lookback interfaces are still
      accepted normally, similarly Unix domain socket connections are not
      restricted in any way.
      273c49e7
  5. 06 Jan, 2016 1 commit
    • antirez's avatar
      Cluster: don't send -ASK to MIGRATE. · b18e42b2
      antirez authored
      For non existing keys, we don't want to send -ASK redirections to
      MIGRATE, since when moving slots from the migrating node to the
      importing node, we want just to ignore keys that are no longer there.
      They may be expired or deleted between the GETKEYSINSLOT call and the
      MIGRATE call. Otherwise this causes an error during migrations with
      redis-trib (or equivalent cluster management tools).
      b18e42b2
  6. 02 Jan, 2016 2 commits
  7. 29 Dec, 2015 1 commit
  8. 23 Dec, 2015 3 commits
  9. 22 Dec, 2015 2 commits
  10. 18 Dec, 2015 2 commits