1. 18 Aug, 2014 2 commits
  2. 13 Aug, 2014 1 commit
  3. 08 Aug, 2014 1 commit
  4. 07 Aug, 2014 3 commits
    • Kashif Rasul's avatar
      Fix issues raised by clang analyzer · c49378fe
      Kashif Rasul authored
      Modified by @antirez since the original fix to genInfoString() looked
      weak. Probably the clang analyzer complained about `section` being
      possibly NULL, and strcasecmp() called with a NULL pointer. In the
      practice this can never happen, still for the sake of correctness
      the right fix is not to modify only the first call, but to set `section`
      to the value of "default" if it happens to be NULL.
      
      Closes #1660
      c49378fe
    • antirez's avatar
      Force quit when receiving a second SIGINT. · 7bb25f8a
      antirez authored
      Also quit ASAP when we are still loading a DB, since care is not needed
      in this special condition, especially for a SIGINT.
      7bb25f8a
    • Matt Stancliff's avatar
      Add graceful exit when Ctrl-C is received · d99a7246
      Matt Stancliff authored
      d99a7246
  5. 28 Jul, 2014 1 commit
  6. 18 Jul, 2014 1 commit
  7. 16 Jul, 2014 2 commits
    • antirez's avatar
      Variadic PING with support for Pub/Sub. · 27839e5e
      antirez authored
      PING can now be called with an additional arugment, behaving exactly
      like the ECHO command. PING can now also be called in Pub/Sub mode (with
      one more more subscriptions to channels / patterns) in order to trigger
      the delivery of an asynchronous pong message with the optional payload.
      
      This fixes issue #420.
      27839e5e
    • antirez's avatar
      PubSub clients refactoring and new PUBSUB flag. · 59cf0824
      antirez authored
      The code tested many times if a client had active Pub/Sub subscriptions
      by checking the length of a list and dictionary where the patterns and
      channels are stored. This was substituted with a client flag called
      REDIS_PUBSUB that is simpler to test for. Moreover in order to manage
      this flag some code was refactored.
      
      This commit is believed to have no effects in the behavior of the
      server.
      59cf0824
  8. 11 Jul, 2014 1 commit
    • michael-grunder's avatar
      Fix OBJECT arity · ce8a68b1
      michael-grunder authored
      Previously, the command definition for the OBJECT command specified
      a minimum of two args (and that it was variadic), which meant that
      if you sent this:
      
      OBJECT foo
      
      When cluster was enabled, it would result in an assertion/SEGFAULT
      when Redis was attempting to extract keys.
      
      It appears that OBJECT is not variadic, and only ever takes 3 args.
      
      https://gist.github.com/michael-grunder/25960ce1508396d0d36a
      ce8a68b1
  9. 08 Jul, 2014 1 commit
  10. 01 Jul, 2014 5 commits
  11. 27 Jun, 2014 6 commits
    • antirez's avatar
      DEBUG CMDKEYS moved to COMMAND GETKEYS. · 683f41ad
      antirez authored
      683f41ad
    • antirez's avatar
      COMMAND COUNT subcommand added. · 885b6fc5
      antirez authored
      885b6fc5
    • antirez's avatar
      COMMAND: fix argument parsing. · a92ae777
      antirez authored
      This fixes detection of wrong subcommand (that resulted in the default
      all-commands output instead) and allows COMMAND INFO to be called
      without arguments (resulting into an empty array) which is useful in
      programmtically generated calls like the following (in Ruby):
      
          redis.commands("command","info",*mycommands)
      
      Note: mycommands may be empty.
      a92ae777
    • antirez's avatar
      COMMANDS command renamed COMMAND. · 7fd0149d
      antirez authored
      7fd0149d
    • antirez's avatar
      COMMANDS command: remove static + aesthetic changes. · 9bf6921f
      antirez authored
      Static was removed since it is needed in order to get symbols in stack
      traces. Minor changes in the source code were operated to make it more
      similar to the existing Redis code base.
      9bf6921f
    • Matt Stancliff's avatar
      Cluster: Add COMMANDS command · 183458f7
      Matt Stancliff authored
      COMMANDS returns a nested multibulk reply for each
      command in the command table.  The reply for each
      command contains:
        - command name
        - arity
        - array of command flags
        - start key position
        - end key position
        - key offset step
        - optional: if the keys are not deterministic and
          Redis uses an internal key evaluation function,
          the 6th field appears and is defined as a status
          reply of: REQUIRES ARGUMENT PARSING
      
      Cluster clients need to know where the keys are in each
      command to implement proper routing to cluster nodes.
      
      Redis commands can have multiple keys, keys at offset steps, or other
      issues where you can't always assume the first element after
      the command name is the cluster routing key.
      
      Using the information exposed by COMMANDS, client implementations
      can have live, accurate key extraction details for all commands.
      
      Also implements COMMANDS INFO [commands...] to return only a
      specific set of commands instead of all 160+ commands live in Redis.
      183458f7
  12. 26 Jun, 2014 1 commit
  13. 23 Jun, 2014 1 commit
  14. 21 Jun, 2014 2 commits
  15. 16 Jun, 2014 2 commits
    • antirez's avatar
      Assign an unique non-repeating ID to each new client. · f26f79ea
      antirez authored
      This will be used by CLIENT KILL and is also a good way to ensure a
      given client is still the same across CLIENT LIST calls.
      
      The output of CLIENT LIST was modified to include the new ID, but this
      change is considered to be backward compatible as the API does not imply
      you can do positional parsing, since each filed as a different name.
      f26f79ea
    • antirez's avatar
      Client types generalized. · 56d26c23
      antirez authored
      Because of output buffer limits Redis internals had this idea of type of
      clients: normal, pubsub, slave. It is possible to set different output
      buffer limits for the three kinds of clients.
      
      However all the macros and API were named after output buffer limit
      classes, while the idea of a client type is a generic one that can be
      reused.
      
      This commit does two things:
      
      1) Rename the API and defines with more general names.
      2) Change the class of clients executing the MONITOR command from "slave"
         to "normal".
      
      "2" is a good idea because you want to have very special settings for
      slaves, that are not a good idea for MONITOR clients that are instead
      normal clients even if they are conceptually slave-alike (since it is a
      push protocol).
      
      The backward-compatibility breakage resulting from "2" is considered to
      be minimal to care, since MONITOR is a debugging command, and because
      anyway this change is not going to break the format or the behavior, but
      just when a connection is closed on big output buffer issues.
      56d26c23
  16. 07 Jun, 2014 1 commit
    • antirez's avatar
      ROLE command added. · d34c2fa3
      antirez authored
      The new ROLE command is designed in order to provide a client with
      informations about the replication in a fast and easy to use way
      compared to the INFO command where the same information is also
      available.
      d34c2fa3
  17. 05 Jun, 2014 1 commit
  18. 22 May, 2014 3 commits
  19. 12 May, 2014 1 commit
  20. 24 Apr, 2014 1 commit
    • antirez's avatar
      Accept multiple clients per iteration. · 3a3458ee
      antirez authored
      When the listening sockets readable event is fired, we have the chance
      to accept multiple clients instead of accepting a single one. This makes
      Redis more responsive when there is a mass-connect event (for example
      after the server startup), and in workloads where a connect-disconnect
      pattern is used often, so that multiple clients are waiting to be
      accepted continuously.
      
      As a side effect, this commit makes the LOADING, BUSY, and similar
      errors much faster to deliver to the client, making Redis more
      responsive when there is to return errors to inform the clients that the
      server is blocked in an not interruptible operation.
      3a3458ee
  21. 17 Apr, 2014 2 commits
  22. 16 Apr, 2014 1 commit