- 14 Apr, 2014 4 commits
- 
- 
antirez authored
- 
antirez authoredWe want to promote if the total string size exceeds the resulting size after the upgrade. 
- 
antirez authoredThe function checks if all the HLL_REGISTERS were processed during the convertion from sparse to dense encoding, returning REDIS_OK or REDIS_ERR to signal a corruption problem. A bug in PFDEBUG GETREG was fixed: when the object is converted to the dense representation we need to reassign the new pointer to the header structure pointer. 
- 
antirez authoredProvides a human readable description of the opcodes composing a run-length encoded HLL (sparse encoding). The command is only useful for debugging / development tasks. 
 
- 
- 13 Apr, 2014 3 commits
- 12 Apr, 2014 10 commits
- 
- 
antirez authoredsdsIncrLen() must be called anyway even if we are replacing the last oppcode of the sparse representation. 
- 
antirez authored
- 
antirez authored
- 
antirez authored
- 
antirez authored
- 
antirez authoredTwo vars initialized to wrong values in createHLLObject(). 
- 
antirez authored
- 
antirez authoredThe function didn't considered the fact that each XZERO opcode is two bytes. 
- 
antirez authored
- 
antirez authored
 
- 
- 11 Apr, 2014 4 commits
- 
- 
antirez authoredCode never tested, but the basic layout is shaped in this commit. Also missing: 1) Sparse -> Dense conversion function. 2) New HLL object creation using the sparse representation. 3) Implementation of PFMERGE for the sparse representation. 
- 
antirez authored
- 
antirez authoredAlso dense representation access macro renamed accordingly. 
- 
antirez authoredMetadata are now placed at the start of the representation as an header. There is a proper structure to access the representation. Still work to do in order to truly abstract the implementation from the representation, commands still work assuming dense representation. 
 
- 
- 10 Apr, 2014 1 commit
- 
- 
antirez authoredAfter running a few simulations with different alternative encodings, it was found that the VAL opcode performs better using 5 bits for the value and 2 bits for the run length, at least for cardinalities in the range of interest. 
 
- 
- 09 Apr, 2014 1 commit
- 
- 
antirez authored
 
- 
- 07 Apr, 2014 1 commit
- 
- 
antirez authoredadjustOpenFilesLimit() and clusterUpdateSlotsWithConfig() that were assuming uint64_t is the same as unsigned long long, which is true probably for all the systems out there that we target, but still GCC emitted a warning since technically they are two different types. 
 
- 
- 05 Apr, 2014 1 commit
- 
- 
antirez authored
 
- 
- 04 Apr, 2014 3 commits
- 
- 
antirez authoredThis will be a non-op most of the times since the object will be unshared / decoded, however it is more technically correct to start this way since the object may be decoded even in the read-only code path. 
- 
antirez authoredWe also avoid to re-create an object that is already in EMBSTR encoding. 
- 
antirez authoredUsing a seed of zero has the side effect of having the empty string hashing to what is a very special case in the context of HyperLogLog: a very long run of zeroes. This did not influenced the correctness of the result with 16k registers because of the harmonic mean, but still it is inconvenient that a so obvious value maps to a so special hash. The seed 0xadc83b19 is used instead, which is the first 64 bits of the SHA1 of the empty string. Reference: issue #1657. 
 
- 
- 03 Apr, 2014 8 commits
- 
- 
antirez authored
- 
antirez authored
- 
antirez authoredWe need to guarantee that the last bit is 1, otherwise an element may hash to just zeroes with probability 1/(2^64) and trigger an infinite loop. See issue #1657. 
- 
antirez authored
- 
antirez authored
- 
antirez authoredThe new command allows to get a dump of the registers stored into an HyperLogLog data structure for testing / debugging purposes. 
- 
antirez authored
- 
antirez authored
 
- 
- 02 Apr, 2014 3 commits
- 
- 
antirez authoredThe function to generate graphs is also more flexible as now includes step and max value. The step of the samples generation function is no longer limited to min step of 1000. 
- 
antirez authoredThis will allow future changes like compressed representations. Currently the magic is not checked for performance reasons but this may change in the future, for example if we add new types encoded in strings that may have the same size of HyperLogLogs. 
- 
Salvatore Sanfilippo authoredChange HLL* to PF* in a few spots 
 
- 
- 01 Apr, 2014 1 commit
- 
- 
Raymond Myers authored
 
-