1. 28 Oct, 2020 2 commits
    • yoav-steinberg's avatar
      Add local address to CLIENT LIST, and a CLIENT KILL filter. (#7913) · 84b3c18f
      yoav-steinberg authored
      Useful when you want to know through which bind address the client connected to
      the server in case of multiple bind addresses.
      
      - Adding `laddr` field to CLIENT list showing the local (bind) address.
      - Adding `LADDR` option to CLIENT KILL to kill all the clients connected
        to a specific local address.
      - Refactoring to share code.
      84b3c18f
    • Oran Agra's avatar
      Optionally (default) fail to start if requested bind address is not available (#7936) · 441bfa2d
      Oran Agra authored
      Background:
      #3467 (redis 4.0.0), started ignoring ENOPROTOOPT, but did that only for
      the default bind (in case bind config wasn't explicitly set).
      #5598 (redis 5.0.3), added that for bind addresses explicitly set
      (following bug reports in Debian for redis 4.0.9 and 5.0.1), it
      also ignored a bunch of other errors like EPROTONOSUPPORT which was
      requested in #3894, and also added EADDRNOTAVAIL (wasn't clear why).
      
      This (ignoring EADDRNOTAVAIL) makes redis start successfully, even if a
      certain network interface isn't up yet , in which case we rather redis
      fail and will be re-tried when the NIC is up, see #7933.
      
      However, it turns out that when IPv6 is disabled (supported but unused),
      the error we're getting is EADDRNOTAVAIL. and in many systems the
      default config file tries to bind to localhost for both v4 and v6 and
      would like to silently ignore the error on v6 if disabled.
      This means that we sometimes want to ignore EADDRNOTAVAIL and other times
      we wanna fail.
      
      So this commit changes these main things:
      1. Ignore all the errors we ignore for both explicitly requested bind
         address and a default implicit one.
      2. Add a '-' prefix to allow EADDRNOTAVAIL be ignored (by default that's
         different than the previous behavior).
      3. Restructure that function in a more readable and maintainable way see
         below.
      4. Make the default behavior of listening to all achievable by setting
        a bind config directive to * (previously only possible by omitting
        it)
      5. document everything.
      
      The old structure of this function was that even if there are no bind
      addresses requested, the loop that runs though the bind addresses runs
      at least once anyway!
      In that one iteration of the loop it binds to both v4 and v6 addresses,
      handles errors for each of them separately, and then eventually at the
      if-else chain, handles the error of the last bind attempt again!
      This was very hard to read and very error prone to maintain, instead now
      when the bind info is missing we create one with two entries, and run
      the simple loop twice.
      441bfa2d
  2. 07 Oct, 2019 1 commit
    • Yossi Gottlieb's avatar
      TLS: Connections refactoring and TLS support. · b087dd1d
      Yossi Gottlieb authored
      * Introduce a connection abstraction layer for all socket operations and
      integrate it across the code base.
      * Provide an optional TLS connections implementation based on OpenSSL.
      * Pull a newer version of hiredis with TLS support.
      * Tests, redis-cli updates for TLS support.
      b087dd1d
  3. 08 Jul, 2019 1 commit
    • Oran Agra's avatar
      diskless replication on slave side (don't store rdb to file), plus some other related fixes · 2de544cf
      Oran Agra authored
      The implementation of the diskless replication was currently diskless only on the master side.
      The slave side was still storing the received rdb file to the disk before loading it back in and parsing it.
      
      This commit adds two modes to load rdb directly from socket:
      1) when-empty
      2) using "swapdb"
      the third mode of using diskless slave by flushdb is risky and currently not included.
      
      other changes:
      --------------
      distinguish between aof configuration and state so that we can re-enable aof only when sync eventually
      succeeds (and not when exiting from readSyncBulkPayload after a failed attempt)
      also a CONFIG GET and INFO during rdb loading would have lied
      
      When loading rdb from the network, don't kill the server on short read (that can be a network error)
      
      Fix rdb check when performed on preamble AOF
      
      tests:
      run replication tests for diskless slave too
      make replication test a bit more aggressive
      Add test for diskless load swapdb
      2de544cf
  4. 21 Mar, 2018 2 commits
  5. 08 Aug, 2017 1 commit
  6. 18 Apr, 2017 2 commits
  7. 07 Mar, 2017 1 commit
  8. 09 Sep, 2016 1 commit
  9. 11 Jun, 2015 2 commits
    • antirez's avatar
      anet.c: new API anetTcpNonBlockBestEffortBindConnect() · a017b7ec
      antirez authored
      This performs a best effort source address binding attempt. If it is
      possible to bind the local address and still have a successful
      connect(), then this socket is returned. Otherwise the call is retried
      without source address binding attempt.
      
      Related to issues #2609 and #2612.
      a017b7ec
    • antirez's avatar
      anetTcpGenericConnect(), jump to error not end on error · 8fa8b251
      antirez authored
      Two code paths jumped to the "ok, return the socket to the user" code
      path to handle error conditions.
      
      Related to issues #2609 and #2612.
      8fa8b251
  10. 21 May, 2015 1 commit
  11. 19 Jan, 2015 1 commit
    • Matt Stancliff's avatar
      Improve networking type correctness · 53c082ec
      Matt Stancliff authored
      read() and write() return ssize_t (signed long), not int.
      
      For other offsets, we can use the unsigned size_t type instead
      of a signed offset (since our replication offsets and buffer
      positions are never negative).
      53c082ec
  12. 11 Dec, 2014 2 commits
  13. 22 Oct, 2014 1 commit
  14. 17 Oct, 2014 1 commit
  15. 18 Sep, 2014 3 commits
  16. 13 Aug, 2014 1 commit
  17. 07 Aug, 2014 1 commit
    • kingsumos's avatar
      cluster: fix node connection memory leak · 1a5e5b6b
      kingsumos authored
      Cluster leaks memory while connecting due to missing freeaddrinfo()
      
      (Commit modified by @antirez. The freeaddrinfo() call was misplaced so
       in case of no address was bound, the memory leak was still there).
      
      Closes #1801
      1a5e5b6b
  18. 26 Jun, 2014 1 commit
  19. 24 Apr, 2014 1 commit
  20. 04 Mar, 2014 1 commit
    • Matt Stancliff's avatar
      Bind source address for cluster communication · e5b1e7be
      Matt Stancliff authored
      The first address specified as a bind parameter
      (server.bindaddr[0]) gets used as the source IP
      for cluster communication.
      
      If no bind address is specified by the user, the
      behavior is unchanged.
      
      This patch allows multiple Redis Cluster instances
      to communicate when running on the same interface
      of the same host.
      e5b1e7be
  21. 31 Jan, 2014 1 commit
    • Nenad Merdanovic's avatar
      Add support for listen(2) backlog definition · d76aa96d
      Nenad Merdanovic authored
      In high RPS environments, the default listen backlog is not sufficient, so
      giving users the power to configure it is the right approach, especially
      since it requires only minor modifications to the code.
      d76aa96d
  22. 10 Jan, 2014 1 commit
    • antirez's avatar
      anetResolveIP() added to anet.c. · 774f0bd4
      antirez authored
      The new function is used when we want to normalize an IP address without
      performing a DNS lookup if the string to resolve is not a valid IP.
      
      This is useful every time only IPs are valid inputs or when we want to
      skip DNS resolution that is slow during runtime operations if we are
      required to block.
      774f0bd4
  23. 25 Dec, 2013 4 commits
  24. 10 Jul, 2013 2 commits
  25. 09 Jul, 2013 1 commit
  26. 08 Jul, 2013 4 commits