1. 02 Nov, 2021 1 commit
    • Oran Agra's avatar
      attempt to fix tracking test issue with external tests due to lazy free (#9722) · 87321deb
      Oran Agra authored
      The External tests started failing recently for unclear reason:
      ```
      *** [err]: Tracking invalidation message of eviction keys should be before response in tests/unit/tracking.tcl
      Expected '0' to be equal to 'invalidate volatile-key' (context: type eval line 21 cmd {assert_equal $res {invalidate volatile-key}} proc ::test)
      ```
      
      I suspect the issue is that the used_memory sample is taken while a lazy free is still being processed.
      87321deb
  2. 26 Oct, 2021 1 commit
  3. 22 Sep, 2021 1 commit
    • Oran Agra's avatar
      tune lazyfree test timeout (#9527) · 5f7789d3
      Oran Agra authored
      i've seen this CI failure a couple of times on MacOS:
      
      *** [err]: lazy free a stream with all types of metadata in tests/unit/lazyfree.tcl
      lazyfree isn't done
      
      only reason i can think of is that 500ms is sometimes not enough on slow systems.
      5f7789d3
  4. 09 Jun, 2021 1 commit
    • Yossi Gottlieb's avatar
      Improve test suite to handle external servers better. (#9033) · 8a86bca5
      Yossi Gottlieb authored
      This commit revives the improves the ability to run the test suite against
      external servers, instead of launching and managing `redis-server` processes as
      part of the test fixture.
      
      This capability existed in the past, using the `--host` and `--port` options.
      However, it was quite limited and mostly useful when running a specific tests.
      Attempting to run larger chunks of the test suite experienced many issues:
      
      * Many tests depend on being able to start and control `redis-server` themselves,
      and there's no clear distinction between external server compatible and other
      tests.
      * Cluster mode is not supported (resulting with `CROSSSLOT` errors).
      
      This PR cleans up many things and makes it possible to run the entire test suite
      against an external server. It also provides more fine grained controls to
      handle cases where the external server supports a subset of the Redis commands,
      limited number of databases, cluster mode, etc.
      
      The tests directory now contains a `README.md` file that describes how this
      works.
      
      This commit also includes additional cleanups and fixes:
      
      * Tests can now be tagged.
      * Tag-based selection is now unified across `start_server`, `tags` and `test`.
      * More information is provided about skipped or ignored tests.
      * Repeated patterns in tests have been extracted to common procedures, both at a
        global level and on a per-test file basis.
      * Cleaned up some cases where test setup was based on a previous test executing
        (a major anti-pattern that repeats itself in many places).
      * Cleaned up some cases where test teardown was not part of a test (in the
        future we should have dedicated teardown code that executes even when tests
        fail).
      * Fixed some tests that were flaky running on external servers.
      8a86bca5
  5. 19 May, 2021 1 commit
    • Oran Agra's avatar
      Fix race in new lazyfree test (#8965) · d67e66de
      Oran Agra authored
      I recently saw this failure:
      [err]: lazy free a stream with all types of metadata in tests/unit/lazyfree.tcl
      Expected '2' to be equal to '1' (context: type eval line 23 cmd {assert_equal [s lazyfreed_objects] 1} proc ::test)
      
      The only explanation for such a thing is that the async flushdb wasn't
      done before we did the resetstat
      d67e66de
  6. 17 May, 2021 1 commit
  7. 09 Oct, 2015 1 commit