1. 22 Feb, 2014 1 commit
    • antirez's avatar
      Sentinel test: framework improved and conf-update unit added. · 8c254415
      antirez authored
      It is now possible to kill and restart sentinel or redis instances for
      more real-world testing.
      
      The 01 unit tests the capability of Sentinel to update the configuration
      of Sentinels rejoining the cluster, however the test is pretty trivial
      and more tests should be added.
      8c254415
  2. 21 Feb, 2014 2 commits
  3. 20 Feb, 2014 3 commits
  4. 19 Feb, 2014 3 commits
  5. 18 Feb, 2014 8 commits
  6. 17 Feb, 2014 5 commits
    • antirez's avatar
      Sentinel: initial testing framework. · af788b58
      antirez authored
      Nothing tested at all so far... Just the infrastructure spawning N
      Sentinels and N Redis instances that the test will use again and again.
      af788b58
    • antirez's avatar
      Test: colorstr moved to util.tcl. · 34c404e0
      antirez authored
      34c404e0
    • antirez's avatar
      Test: code to test server availability refactored. · a1dca2ef
      antirez authored
      Some inline test moved into server_is_up procedure.
      Also find_available_port was moved into util since it is going
      to be used for the Sentinel test as well.
      a1dca2ef
    • antirez's avatar
      Get absoulte config file path before processig 'dir'. · ede33fb9
      antirez authored
      The code tried to obtain the configuration file absolute path after
      processing the configuration file. However if config file was a relative
      path and a "dir" statement was processed reading the config, the absolute
      path obtained was wrong.
      
      With this fix the absolute path is obtained before processing the
      configuration while the server is still in the original directory where
      it was executed.
      ede33fb9
    • antirez's avatar
      Sentinel: better specify startup errors due to config file. · e1b77b61
      antirez authored
      Now it logs the file name if it is not accessible. Also there is a
      different error for the missing config file case, and for the non
      writable file case.
      e1b77b61
  7. 13 Feb, 2014 4 commits
    • antirez's avatar
      Update cached time in rdbLoad() callback. · 51bd9da1
      antirez authored
      server.unixtime and server.mstime are cached less precise timestamps
      that we use every time we don't need an accurate time representation and
      a syscall would be too slow for the number of calls we require.
      
      Such an example is the initialization and update process of the last
      interaction time with the client, that is used for timeouts.
      
      However rdbLoad() can take some time to load the DB, but at the same
      time it did not updated the time during DB loading. This resulted in the
      bug described in issue #1535, where in the replication process the slave
      loads the DB, creates the redisClient representation of its master, but
      the timestamp is so old that the master, under certain conditions, is
      sensed as already "timed out".
      
      Thanks to @yoav-steinberg and Redis Labs Inc for the bug report and
      analysis.
      51bd9da1
    • antirez's avatar
      Log when CONFIG REWRITE goes bad. · 7e8abcf6
      antirez authored
      7e8abcf6
    • antirez's avatar
      Test: regression for issue #1549. · f2bdf601
      antirez authored
      It was verified that reverting the commit that fixes the bug, the test
      no longer passes.
      f2bdf601
    • antirez's avatar
      Fix script cache bug in the scripting engine. · 21e6b0fb
      antirez authored
      This commit fixes a serious Lua scripting replication issue, described
      by Github issue #1549. The root cause of the problem is that scripts
      were put inside the script cache, assuming that slaves and AOF already
      contained it, even if the scripts sometimes produced no changes in the
      data set, and were not actaully propagated to AOF/slaves.
      
      Example:
      
          eval "if tonumber(KEYS[1]) > 0 then redis.call('incr', 'x') end" 1 0
      
      Then:
      
          evalsha <sha1 step 1 script> 1 0
      
      At this step sha1 of the script is added to the replication script cache
      (the script is marked as known to the slaves) and EVALSHA command is
      transformed to EVAL. However it is not dirty (there is no changes to db),
      so it is not propagated to the slaves. Then the script is called again:
      
          evalsha <sha1 step 1 script> 1 1
      
      At this step master checks that the script already exists in the
      replication script cache and doesn't transform it to EVAL command. It is
      dirty and propagated to the slaves, but they fail to evaluate the script
      as they don't have it in the script cache.
      
      The fix is trivial and just uses the new API to force the propagation of
      the executed command regardless of the dirty state of the data set.
      
      Thank you to @minus-infinity on Github for finding the issue,
      understanding the root cause, and fixing it.
      21e6b0fb
  8. 12 Feb, 2014 2 commits
    • antirez's avatar
      AOF write error: retry with a frequency of 1 hz. · fc08c859
      antirez authored
      fc08c859
    • antirez's avatar
      AOF: don't abort on write errors unless fsync is 'always'. · fe835254
      antirez authored
      A system similar to the RDB write error handling is used, in which when
      we can't write to the AOF file, writes are no longer accepted until we
      are able to write again.
      
      For fsync == always we still abort on errors since there is currently no
      easy way to avoid replying with success to the user otherwise, and this
      would violate the contract with the user of only acknowledging data
      already secured on disk.
      fe835254
  9. 11 Feb, 2014 6 commits
  10. 10 Feb, 2014 6 commits
    • antirez's avatar
      Cluster: on resharding upgrade version of receiving node. · a1349728
      antirez authored
      The node receiving the hash slot needs to have a version that wins over
      the other versions in order to force the ownership of the slot.
      
      However the current code is far from perfect since a failover can happen
      during the manual resharding. The fix is a work in progress but the
      bottom line is that the new version must either be voted as usually,
      set by redis-trib manually after it makes sure can't be used by other
      nodes, or reserved configEpochs could be used for manual operations (for
      example odd versions could be never used by slaves and are always used
      by CLUSTER SETSLOT NODE).
      a1349728
    • antirez's avatar
      Cluster: fsync at every SETSLOT command puts too pressure on disks. · 6dc26795
      antirez authored
      During slots migration redis-trib can send a number of SETSLOT commands.
      Fsyncing every time is a bit too much in production as verified
      empirically.
      
      To make sure configs are fsynced on all nodes after a resharding
      redis-trib may send something like CLUSTER CONFSYNC.
      
      In this case fsyncs were not providing too much value since anyway
      processes can crash in the middle of the resharding of an hash slot, and
      redis-trib should be able to recover from this condition anyway.
      6dc26795
    • antirez's avatar
      Cluster: conditions to clear "migrating" on slot for SETSLOT ... NODE changed. · 218358bb
      antirez authored
      If the slot is manually assigned to another node, clear the migrating
      status regardless of the fact it was previously assigned to us or not,
      as long as we no longer have keys for this slot.
      
      This avoid a race during slots migration that may leave the slot in
      migrating status in the source node, since it received an update message
      from the destination node that is already claiming the slot.
      
      This way we are sure that redis-trib at the end of the slot migration is
      always able to close the slot correctly.
      218358bb
    • antirez's avatar
      Cluster: remove debugging xputs from redis-trib. · 3107e7ca
      antirez authored
      3107e7ca
    • antirez's avatar
      Cluster: redis-trib fix: cover new case of open slot. · 1ae50a9b
      antirez authored
      The case is the trivial one a single node claiming the slot as
      migrating, without nodes claiming it as importing.
      1ae50a9b
    • antirez's avatar
      59e03a8f