1. 08 Jan, 2014 2 commits
    • antirez's avatar
      Don't send REPLCONF ACK to old masters. · 90a81b4e
      antirez authored
      Masters not understanding REPLCONF ACK will reply with errors to our
      requests causing a number of possible issues.
      
      This commit detects a global replication offest set to -1 at the end of
      the replication, and marks the client representing the master with the
      REDIS_PRE_PSYNC flag.
      
      Note that this flag was called REDIS_PRE_PSYNC_SLAVE but now it is just
      REDIS_PRE_PSYNC as it is used for both slaves and masters starting with
      this commit.
      
      This commit fixes issue #1488.
      90a81b4e
    • antirez's avatar
      3f92e056
  2. 25 Dec, 2013 6 commits
  3. 23 Dec, 2013 2 commits
    • antirez's avatar
      Fix CONFIG REWRITE handling of unknown options. · e7893842
      antirez authored
      There were two problems with the implementation.
      
      1) "save" was not correctly processed when no save point was configured,
         as reported in issue #1416.
      2) The way the code checked if an option existed in the "processed"
         dictionary was wrong, as we add the element with as a key associated
         with a NULL value, so dictFetchValue() can't be used to check for
         existance, but dictFind() must be used, that returns NULL only if the
         entry does not exist at all.
      e7893842
    • antirez's avatar
      Configuring port to 0 disables IP socket as specified. · 7e9433ce
      antirez authored
      This was no longer the case with 2.8 becuase of a bug introduced with
      the IPv6 support. Now it is fixed.
      
      This fixes issue #1287 and #1477.
      7e9433ce
  4. 22 Dec, 2013 3 commits
    • antirez's avatar
      Make new masters inherit replication offsets. · 94e8c9e7
      antirez authored
      Currently replication offsets could be used into a limited way in order
      to understand, out of a set of slaves, what is the one with the most
      updated data. For example this comparison is possible of N slaves
      were replicating all with the same master.
      
      However the replication offset was not transferred from master to slaves
      (that are later promoted as masters) in any way, so for instance if
      there were three instances A, B, C, with A master and B and C
      replication from A, the following could happen:
      
      C disconnects from A.
      B is turned into master.
      A is switched to master of B.
      B receives some write.
      
      In this context there was no way to compare the offset of A and C,
      because B would use its own local master replication offset as
      replication offset to initialize the replication with A.
      
      With this commit what happens is that when B is turned into master it
      inherits the replication offset from A, making A and C comparable.
      In the above case assuming no inconsistencies are created during the
      disconnection and failover process, A will show to have a replication
      offset greater than C.
      
      Note that this does not mean offsets are always comparable to understand
      what is, in a set of instances, since in more complex examples the
      replica with the higher replication offset could be partitioned away
      when picking the instance to elect as new master. However this in
      general improves the ability of a system to try to pick a good replica
      to promote to master.
      94e8c9e7
    • antirez's avatar
      Slave disconnection is an event worth logging. · ba5eb44d
      antirez authored
      ba5eb44d
    • antirez's avatar
      Redis Cluster: add repl_ping_slave_period to slave data validity time. · 66ec1412
      antirez authored
      When the configured node timeout is very small, the data validity time
      (maximum data age for a slave to try a failover) is too little (ten
      times the configured node timeout) when the replication link with the
      master is mostly idle. In this case we'll receive some data from the
      master only every server.repl_ping_slave_period to refresh the last
      interaction with the master.
      
      This commit adds to the max data validity time the slave ping period to
      avoid this problem of slaves sensing too old data without a good reason.
      However this max data validity time is likely a setting that should be
      configurable by the Redis Cluster user in a way completely independent
      from the node timeout.
      66ec1412
  5. 20 Dec, 2013 6 commits
  6. 19 Dec, 2013 4 commits
  7. 17 Dec, 2013 7 commits
  8. 13 Dec, 2013 3 commits
    • antirez's avatar
      Makefile.dep updated. · 2dfc5e35
      antirez authored
      2dfc5e35
    • antirez's avatar
      SDIFF iterator misuse fixed in diff algorithm #1. · c00453da
      antirez authored
      The bug could be easily triggered by:
      
          SADD foo a b c 1 2 3 4 5 6
          SDIFF foo foo
      
      When the key was the same in two sets, an unsafe iterator was used to
      check existence of elements in the same set we were iterating.
      Usually this would just result into a wrong output, however with the
      dict.c API misuse protection we have in place, the result was actually
      an assertion failed that was triggered by the CI test, while creating
      random datasets for the "MASTER and SLAVE consistency" test.
      c00453da
    • antirez's avatar
      Sentinel: dead code removed. · 53201488
      antirez authored
      53201488
  9. 12 Dec, 2013 2 commits
  10. 11 Dec, 2013 2 commits
  11. 10 Dec, 2013 3 commits
    • antirez's avatar
      Slaves heartbeats during sync improved. · 11120689
      antirez authored
      The previous fix for false positive timeout detected by master was not
      complete. There is another blocking stage while loading data for the
      first synchronization with the master, that is, flushing away the
      current data from the DB memory.
      
      This commit uses the newly introduced dict.c callback in order to make
      some incremental work (to send "\n" heartbeats to the master) while
      flushing the old data from memory.
      
      It is hard to write a regression test for this issue unfortunately. More
      support for debugging in the Redis core would be needed in terms of
      functionalities to simulate a slow DB loading / deletion.
      11120689
    • antirez's avatar
      dict.c: added optional callback to dictEmpty(). · 2eb781b3
      antirez authored
      Redis hash table implementation has many non-blocking features like
      incremental rehashing, however while deleting a large hash table there
      was no way to have a callback called to do some incremental work.
      
      This commit adds this support, as an optiona callback argument to
      dictEmpty() that is currently called at a fixed interval (one time every
      65k deletions).
      2eb781b3
    • antirez's avatar
      2c4ab8a5