1. 30 Jan, 2015 2 commits
  2. 29 Jan, 2015 5 commits
  3. 22 Jan, 2015 6 commits
    • Matt Stancliff's avatar
      Fix cluster migrate memory leak · ebb07a0b
      Matt Stancliff authored
      Fixes valgrind error:
      48 bytes in 1 blocks are definitely lost in loss record 196 of 373
         at 0x4910D3: je_malloc (jemalloc.c:944)
         by 0x42807D: zmalloc (zmalloc.c:125)
         by 0x41FA0D: dictGetIterator (dict.c:543)
         by 0x41FA48: dictGetSafeIterator (dict.c:555)
         by 0x459B73: clusterHandleSlaveMigration (cluster.c:2776)
         by 0x45BF27: clusterCron (cluster.c:3123)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
      ebb07a0b
    • Matt Stancliff's avatar
      Fix potential invalid read past end of array · 98faed3a
      Matt Stancliff authored
      If array has N elements, we can't read +1 if we are already at N.
      
      Also, we need to move elements by their storage size in the array,
      not just by individual bytes.
      98faed3a
    • Matt Stancliff's avatar
      Fix cluster reset memory leak · 97ffeb7c
      Matt Stancliff authored
      [maybe] Fixes valgrind errors:
      32 bytes in 4 blocks are definitely lost in loss record 107 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80A9AFC: clusterSetMaster (cluster.c:801)
         by 0x80AEDC9: clusterCommand (cluster.c:3994)
         by 0x80682A5: call (redis.c:2049)
         by 0x8068A20: processCommand (redis.c:2309)
         by 0x8076497: processInputBuffer (networking.c:1143)
         by 0x8073BAF: readQueryFromClient (networking.c:1208)
         by 0x8060E98: aeProcessEvents (ae.c:412)
         by 0x806123B: aeMain (ae.c:455)
         by 0x806C3DB: main (redis.c:3832)
      
      64 bytes in 8 blocks are definitely lost in loss record 143 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x30000FF: ???
      
      80 bytes in 10 blocks are definitely lost in loss record 148 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x2FFFFFF: ???
      97ffeb7c
    • Matt Stancliff's avatar
      Fix sending uninitialized bytes · 4a36350d
      Matt Stancliff authored
      Fixes valgrind error:
      Syscall param write(buf) points to uninitialised byte(s)
         at 0x514C35D: ??? (syscall-template.S:81)
         by 0x456B81: clusterWriteHandler (cluster.c:1907)
         by 0x41D596: aeProcessEvents (ae.c:416)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Address 0x5f268e2 is 2,274 bytes inside a block of size 8,192 alloc'd
         at 0x4932D1: je_realloc (jemalloc.c:1297)
         by 0x428185: zrealloc (zmalloc.c:162)
         by 0x4269E0: sdsMakeRoomFor.part.0 (sds.c:142)
         by 0x426CD7: sdscatlen (sds.c:251)
         by 0x4579E7: clusterSendMessage (cluster.c:1995)
         by 0x45805A: clusterSendPing (cluster.c:2140)
         by 0x45BB03: clusterCron (cluster.c:2944)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Uninitialised value was created by a stack allocation
         at 0x457810: nodeUpdateAddressIfNeeded (cluster.c:1236)
      4a36350d
    • antirez's avatar
      Cluster: node deletion cleanup / centralization. · 0a3edcbe
      antirez authored
      0a3edcbe
    • antirez's avatar
      Cluster: set the slaves->slaveof filed to NULL when master is freed. · 5130c253
      antirez authored
      Related to issue #2289.
      5130c253
  4. 13 Jan, 2015 3 commits
    • antirez's avatar
      Cluster: fetch my IP even if msg is not MEET for the first time. · df1a7fc4
      antirez authored
      In order to avoid that misconfigured cluster nodes at some time may
      force an IP update on other nodes, it is required that nodes update
      their own address only on MEET messages. However it does not make sense
      to do this the first time a node is contacted and yet does not have an
      IP, we just risk that myself->ip remains not assigned if there are
      messages lost or cluster creation procedures that don't make sure
      everybody is targeted by at least one incoming MEET message.
      
      Also fix the logging of the IP switch avoiding the :-1 tail.
      df1a7fc4
    • antirez's avatar
      Cluster: clusterMsgDataGossip structure, explict padding + minor stuff. · 45e2a26d
      antirez authored
      Also explicitly set version to 0, add a protocol version define, improve
      comments in the gossip structure.
      
      Note that the structure layout is the same after the change, we are just
      making the padding explicit with an additional not used 16 bits field.
      So this commit is still able to talk with the previous versions of
      cluster nodes.
      45e2a26d
    • antirez's avatar
      Suppress valgrind error about write sending uninitialized data. · 799a3cca
      antirez authored
      Valgrind checks that the buffers we transfer via syscalls are all
      composed of bytes actually initialized. This is useful, it makes we able
      to avoid leaking informations in non initialized parts fo messages
      transferred to other hosts. This commit fixes one of such issues.
      799a3cca
  5. 12 Jan, 2015 1 commit
    • antirez's avatar
      Cluster: initialize mf_end. · 1584c7a3
      antirez authored
      Can't be initialized by resetManualFailover() since it's actual state
      the function uses, so we need to initialize it at startup time. Not
      really a bug in practical terms, but showed up into valgrind and is not
      technically correct anyway.
      1584c7a3
  6. 17 Dec, 2014 1 commit
    • Matt Stancliff's avatar
      Cluster: Notify user on accept error · 8bce6542
      Matt Stancliff authored
      If we woke up to accept a connection, but we can't
      accept it, inform the user of the error going on
      with their networking.
      
      (The previous message was the same for success or error!)
      8bce6542
  7. 16 Dec, 2014 1 commit
  8. 15 Dec, 2014 1 commit
  9. 09 Dec, 2014 1 commit
    • antirez's avatar
      Cluster PUBLISH message: fix totlen count. · 73996c86
      antirez authored
      bulk_data field size was not removed from the count. It is not possible
      to declare it simply as 'char bulk_data[]' since the structure is nested
      into another structure.
      73996c86
  10. 31 Oct, 2014 2 commits
    • Matt Stancliff's avatar
      Parse cluster state file in IPv6 compatible way · 75e68625
      Matt Stancliff authored
      We need to pick the port based on the _last_ colon, not the first one.
      75e68625
    • Matt Stancliff's avatar
      Networking: add more outbound IP binding fixes · f1a6f780
      Matt Stancliff authored
      Same as the original bind fixes (we just missed these the
      first time around).
      
      This helps Redis not automatically send
      connections from the first IP on an interface if we are bound
      to a specific IP address (e.g. with multiple IP aliases on one
      interface, you want to send from _your_ IP, not from the first IP
      on the interface).
      f1a6f780
  11. 09 Oct, 2014 2 commits
    • antirez's avatar
      Cluster: process gossip section only for known nodes. · c6226f26
      antirez authored
      With the exception of nodes sending MEET packets: we have to trust them
      since they can send us MEET packets only when the cluster is initially
      created or because sysadmin manual action.
      c6226f26
    • antirez's avatar
      Cluster: fix logic to detect we are among a minority. · 419eb185
      antirez authored
      In the cluster evaluation function we are supposed to set the cluster
      state as "fail" if we are among a minority, however the code was not
      detecting to be into a minority partition if exactly half the masters
      were reachable, which is a minority.
      419eb185
  12. 08 Oct, 2014 1 commit
  13. 06 Oct, 2014 1 commit
    • Matt Stancliff's avatar
      Clean up text throughout project · bd62c952
      Matt Stancliff authored
        - Remove trailing newlines from redis.conf
        - Fix comment misspelling
        - Clarifies zipEncodeLength usage and a C API mention (#1243, #1242)
        - Fix cluster typos (inspired by @papanikge #1507)
        - Fix rewite -> rewrite in a few places (inspired by #682)
      
      Closes #1243, #1242, #1507
      bd62c952
  14. 19 Sep, 2014 2 commits
  15. 26 Aug, 2014 7 commits
  16. 28 Jul, 2014 1 commit
    • antirez's avatar
      Cluster: don't migrate to a master that never had slaves. · c5bd330f
      antirez authored
      Replica migration algorithm modified so that slaves never try to migrate
      to masters that were never configured to have slaves in the past.
      We want the algorithm to take care of masters that remained without
      *working* slaves, but that used to have slaves according to the cluster
      configuration.
      c5bd330f
  17. 23 Jul, 2014 1 commit
    • antirez's avatar
      CLUSTER RESET: Flush dataset if node is a slave. · 955b2562
      antirez authored
      For non-empty masters, CLUSTER RESET is denied, and the user requires to
      start to reset a node by explicitly clearing it with FLUSHALL.
      However CLUSTER RESET when executed with slaves don't have this
      restrictions since data is just a replica of the master, and with
      read-only slaves it is also not possible to remove the data set. However
      the node was turned from slave to master after a reset, without touching
      the old slave data. This is 99.99% of times not appropriate and forces
      full resets to follow this path to work with both slave and master
      nodes:
      
          FLUSHALL
          CLUSTER RESET HARD
          FLUSHALL
      
      Since we need the first flushall for masters, and the second for slaves.
      
      This commit changes the behavior so that CLUSTER RESET removes the data set
      of a slave node during a reset, in the moment it gets turned into a master,
      so the new pattern is simply:
      
          FLUSHALL (that may fail for slaves)
          CLUSTER RESET
      955b2562
  18. 26 Jun, 2014 2 commits
    • antirez's avatar
      No more trailing spaces in Redis source code. · b4116786
      antirez authored
      b4116786
    • antirez's avatar
      CLUSTER SLOTS: don't output failing slaves. · a7bef1bb
      antirez authored
      While we have to output failing masters in order to provide an accurate
      map (that may be the one of a Redis Cluster in down state because not
      all slots are served by a working master), to provide slaves in FAIL
      state is not a good idea since those are not necesarely needed, and the
      client will likely incur into a latency penalty trying to connect with a
      slave which is down.
      
      Note that this means that CLUSTER SLOTS does not provide a *complete*
      map of slaves, however this would not be of any help since slaves may be
      added later, and a client that needs to scale reads and requires to
      stay updated with the list of slaves, need to do a refresh of the map
      from time to time, anyway.
      a7bef1bb