- 27 Oct, 2020 4 commits
-
-
Yossi Gottlieb authored
Avoid using a static buffer for short key index responses, and make it caller's responsibility to stack-allocate a result type. Responses that don't fit are still allocated on the heap. (cherry picked from commit 9b7f8ba8)
-
Madelyn Olson authored
(cherry picked from commit 2127f7c8)
-
Wang Yuan authored
Before this commit, we would have continued to add replies to the reply buffer even if client output buffer limit is reached, so the used memory would keep increasing over the configured limit. What's more, we shouldn’t write any reply to the client if it is set 'CLIENT_CLOSE_ASAP' flag because that doesn't conform to its definition and we will close all clients flagged with 'CLIENT_CLOSE_ASAP' in ‘beforeSleep’. Because of code execution order, before this, we may firstly write to part of the replies to the socket before disconnecting it, but in fact, we may can’t send the full replies to clients since OS socket buffer is limited. But this unexpected behavior makes some commands work well, for instance ACL DELUSER, if the client deletes the current user, we need to send reply to client and close the connection, but before, we close the client firstly and write the reply to reply buffer. secondly, we shouldn't do this despite the fact it works well in most cases. We add a flag 'CLIENT_CLOSE_AFTER_COMMAND' to mark clients, this flag means we will close the client after executing commands and send all entire replies, so that we can write replies to reply buffer during executing commands, send replies to clients, and close them later. We also fix some implicit problems. If client output buffer limit is enforced in 'multi/exec', all commands will be executed completely in redis and clients will not read any reply instead of partial replies. Even more, if the client executes 'ACL deluser' the using user in 'multi/exec', it will not read the replies after 'ACL deluser' just like before executing 'client kill' itself in 'multi/exec'. We added some tests for output buffer limit breach during multi-exec and using a pipeline of many small commands rather than one with big response. Co-authored-by:
Oran Agra <oran@redislabs.com> (cherry picked from commit 57709c4b)
-
Oran Agra authored
List of squashed commits or PRs =============================== commit 66801ea Author: hwware <wen.hui.ware@gmail.com> Date: Mon Jan 13 00:54:31 2020 -0500 typo fix in acl.c commit 46f55db Author: Itamar Haber <itamar@redislabs.com> Date: Sun Sep 6 18:24:11 2020 +0300 Updates a couple of comments Specifically: * RM_AutoMemory completed instead of pointing to docs * Updated link to custom type doc commit 61a2aa0 Author: xindoo <xindoo@qq.com> Date: Tue Sep 1 19:24:59 2020 +0800 Correct errors in code comments commit a5871d1 Author: yz1509 <pro-756@qq.com> Date: Tue Sep 1 18:36:06 2020 +0800 fix typos in module.c commit 41eede7 Author: bookug <bookug@qq.com> Date: Sat Aug 15 01:11:33 2020 +0800 docs: fix typos in comments commit c303c84 Author: lazy-snail <ws.niu@outlook.com> Date: Fri Aug 7 11:15:44 2020 +0800 fix spelling in redis.conf commit 1eb76bf Author: zhujian <zhujianxyz@gmail.com>...
-
- 01 Sep, 2020 1 commit
-
- 20 Jul, 2020 1 commit
-
- 06 Jun, 2020 1 commit
-
-
antirez authored
Now it is also possible for ACL SETUSER to accept empty strings as valid operations (doing nothing), so for instance ACL SETUSER myuser "" Will have just the effect of creating a user in the default state. This should fix #7329.
-
- 22 May, 2020 2 commits
-
-
hujie authored
in ACLSetUserCommandBit, when the command bit overflows, no operation is performed, so no need clear the USER_FLAG_ALLCOMMANDS flag. in ACLSetUser, when adding subcommand, we don't need to call ACLGetCommandID ahead since subcommand may be empty.
-
Madelyn Olson authored
-
- 24 Apr, 2020 4 commits
- 15 Apr, 2020 3 commits
- 08 Apr, 2020 1 commit
-
-
antirez authored
-
- 25 Mar, 2020 1 commit
-
-
antirez authored
Note that this as a side effect fixes Sentinel "requirepass" mode.
-
- 05 Mar, 2020 1 commit
-
-
ShooterIT authored
-
- 12 Feb, 2020 8 commits
- 10 Jan, 2020 1 commit
-
-
hwware authored
-
- 17 Dec, 2019 1 commit
-
-
Madelyn Olson authored
-
- 30 Sep, 2019 2 commits
-
-
antirez authored
Related to PR #6405
-
Madelyn Olson authored
-
- 12 Sep, 2019 2 commits
- 07 Jun, 2019 1 commit
-
-
Madelyn Olson authored
-
- 08 Apr, 2019 1 commit
-
-
antirez authored
This commit fixes bug reported at #5998. Thanks to @tomcat1102.
-
- 05 Mar, 2019 1 commit
-
-
antirez authored
-
- 27 Feb, 2019 1 commit
-
-
antirez authored
-
- 26 Feb, 2019 1 commit
-
-
Madelyn Olson authored
-
- 25 Feb, 2019 2 commits