1. 16 Jan, 2014 2 commits
  2. 15 Jan, 2014 9 commits
    • antirez's avatar
      Cluster: use the node blacklist in CLUSTER FORGET. · 3e948970
      antirez authored
      CLUSTER FORGET is not useful if we can't remove a node from all the
      nodes of our cluster because of the Gossip protocol that keeps adding
      a given node to nodes where we already tried to remove it.
      
      So now CLUSTER FORGET implements a nodes blacklist that is set and
      checked by the Gossip section processing function. This way before a
      node is re-added at least 60 seconds must elapse since the FORGET
      execution.
      
      This means that redis-trib has some time to remove a node from a whole
      cluster. It is possible that in the future it will be uesful to raise
      the 60 sec figure to something bigger.
      3e948970
    • antirez's avatar
      Cluster: fix clusterBlacklistAddNode() by setting right expire time. · ccf268fa
      antirez authored
      The hash table value should be set to now + 60 seconds otherwise it
      expires immediately.
      ccf268fa
    • antirez's avatar
      Cluster: clusterBlacklistAddNode() key lookup fixed. · 4e186115
      antirez authored
      We can't lookup by node->name that's not an SDS string but a plain C
      array in the node structure.
      4e186115
    • antirez's avatar
    • antirez's avatar
      Cluster: set a minimum rejoin delay if node_timeout is too small. · a81340ab
      antirez authored
      The rejoin delay usually is the node timeout. However if the node
      timeout is too small, we set it to 500 milliseconds, that is a value
      chosen to be greater than most setups RTT / instances latency figures
      so that likely communication with other nodes happen before rejoining.
      a81340ab
    • antirez's avatar
      Cluster: periodically call clusterUpdateState() when cluster is down. · a687cbc1
      antirez authored
      Usually we update the cluster state (to understand if we should accept
      queries or reply with an error) only when there is a change in the state
      of the nodes. However for the "delayed rejoin" feature to work, that is,
      for a master to wait some time before accepting queries again after it
      rejoins the majority, we need to periodically update the last time when
      the node was partitioned away from the majority.
      
      With this commit if the cluster is down we update the state ten times
      per second.
      a687cbc1
    • antirez's avatar
      Cluster: range checking in getSlotOrReply() fixed. · 25ddefde
      antirez authored
      See issue #1426 on Github.
      25ddefde
    • antirez's avatar
      Cluster: ignore empty lines in nodes.conf. · fb659cd3
      antirez authored
      Even without the user messing manually with the file, it is still
      possible to have blank lines (just a single "\n" per line) because of
      how the nodes.conf update/write process works.
      fb659cd3
    • antirez's avatar
      Cluster: atomic update of nodes.conf file. · 6c63df30
      antirez authored
      The way the file was generated was unsafe and leaded to nodes.conf file
      corruption (zero length file) on server stop/crash during the creation
      of the file.
      
      The previous file update method was as simple as open with O_TRUNC
      followed by the write call. While the write call was a single one with
      the full payload, ensuring no half-written files for POSIX semantics,
      stopping the server just after the open call resulted into a zero-length
      file (all the nodes information lost!).
      6c63df30
  3. 14 Jan, 2014 4 commits
  4. 13 Jan, 2014 3 commits
  5. 10 Jan, 2014 9 commits
  6. 09 Jan, 2014 1 commit
  7. 08 Jan, 2014 3 commits
  8. 25 Dec, 2013 6 commits
  9. 23 Dec, 2013 2 commits
    • antirez's avatar
      Fix CONFIG REWRITE handling of unknown options. · e7893842
      antirez authored
      There were two problems with the implementation.
      
      1) "save" was not correctly processed when no save point was configured,
         as reported in issue #1416.
      2) The way the code checked if an option existed in the "processed"
         dictionary was wrong, as we add the element with as a key associated
         with a NULL value, so dictFetchValue() can't be used to check for
         existance, but dictFind() must be used, that returns NULL only if the
         entry does not exist at all.
      e7893842
    • antirez's avatar
      Configuring port to 0 disables IP socket as specified. · 7e9433ce
      antirez authored
      This was no longer the case with 2.8 becuase of a bug introduced with
      the IPv6 support. Now it is fixed.
      
      This fixes issue #1287 and #1477.
      7e9433ce
  10. 22 Dec, 2013 1 commit
    • antirez's avatar
      Make new masters inherit replication offsets. · 94e8c9e7
      antirez authored
      Currently replication offsets could be used into a limited way in order
      to understand, out of a set of slaves, what is the one with the most
      updated data. For example this comparison is possible of N slaves
      were replicating all with the same master.
      
      However the replication offset was not transferred from master to slaves
      (that are later promoted as masters) in any way, so for instance if
      there were three instances A, B, C, with A master and B and C
      replication from A, the following could happen:
      
      C disconnects from A.
      B is turned into master.
      A is switched to master of B.
      B receives some write.
      
      In this context there was no way to compare the offset of A and C,
      because B would use its own local master replication offset as
      replication offset to initialize the replication with A.
      
      With this commit what happens is that when B is turned into master it
      inherits the replication offset from A, making A and C comparable.
      In the above case assuming no inconsistencies are created during the
      disconnection and failover process, A will show to have a replication
      offset greater than C.
      
      Note that this does not mean offsets are always comparable to understand
      what is, in a set of instances, since in more complex examples the
      replica with the higher replication offset could be partitioned away
      when picking the instance to elect as new master. However this in
      general improves the ability of a system to try to pick a good replica
      to promote to master.
      94e8c9e7