- 07 Aug, 2014 16 commits
-
-
ripcurld00d authored
Use constants to avoid magic numbers in `types`, which is an array that stores the names of `REDIS` types. Closes #1681
-
Kashif Rasul authored
Modified by @antirez since the original fix to genInfoString() looked weak. Probably the clang analyzer complained about `section` being possibly NULL, and strcasecmp() called with a NULL pointer. In the practice this can never happen, still for the sake of correctness the right fix is not to modify only the first call, but to set `section` to the value of "default" if it happens to be NULL. Closes #1660
-
antirez authored
Also quit ASAP when we are still loading a DB, since care is not needed in this special condition, especially for a SIGINT.
-
Matt Stancliff authored
-
Matt Stancliff authored
The classic (min+max)/2 is provably unsafe. Fixed as recommended in research: http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html Fix inspired by @wjin, but I used a different approach. (later, I found @kuebler fixed the same issue too). Fixes #1741, #1602
-
Matt Stancliff authored
We only want to use the last STORE key, but we have to record we actually found a STORE key so we can increment the final return key count. Test added to prevent further regression. Closes #1883, #1645, #1647
-
Jan-Erik Rediger authored
Previously the end was casted to a smaller type which resulted in a wrong check and failed with values larger than handled by unsigned. Closes #1847, #1844
-
Matt Stancliff authored
Negative key count causes segfault in Lua functions. Fixes #1842 Closes #1843
-
kingsumos authored
Cluster leaks memory while connecting due to missing freeaddrinfo() (Commit modified by @antirez. The freeaddrinfo() call was misplaced so in case of no address was bound, the memory leak was still there). Closes #1801
-
Jan-Erik Rediger authored
(Cleaned up a little by @mattsta) Closes #1774
-
Wei Jin authored
Fixes #1741
-
antirez authored
-
siahl authored
Closes #1900
-
Matt Stancliff authored
Some people need formatted output even when they have no interactive tty. Fixes #760
-
Matt Stancliff authored
Previously redis-cli would happily show "-1" or "99999" as valid DB choices. Now, if the SELECT call returned an error, we don't update the DB number in the CLI. Inspired by @anupshendkar in #1313 Fixes #566, #1313
-
Matt Stancliff authored
Previously, if you did SELECT then AUTH, redis-cli would show your SELECT'd db even though it didn't happen. Note: running into this situation is a (hopefully) very limited used case of people using multiple DBs and AUTH all at the same time. Fixes antirez#1639
-
- 28 Jul, 2014 8 commits
-
-
Salvatore Sanfilippo authored
Fail SYNC if background save child aborted due to a signal.
-
Yossi Gottlieb authored
-
vps authored
-
antirez authored
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
Fix spelling of "stand alone" in ascii art
-
Matt Robenolt authored
Also unified the logic to match `genRedisInfoString`
-
- 25 Jul, 2014 7 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
Replica migration algorithm modified so that slaves never try to migrate to masters that were never configured to have slaves in the past. We want the algorithm to take care of masters that remained without *working* slaves, but that used to have slaves according to the cluster configuration.
-
- 23 Jul, 2014 3 commits
-
-
antirez authored
-
antirez authored
Based on ideas documented in this blog post: https://www.facebook.com/notes/facebook-engineering/three-optimization-tips-for-c/10151361643253920 The original code was modified to handle signed integers, reformetted to fit inside the Redis code base, and was stress-tested with a program in order to validate the implementation against snprintf(). Redis was measured to be measurably faster from the point of view of clients in real-world operations because of this change, since sometimes number to string conversion is used extensively (for example every time a GET results into an integer encoded object to be returned to the user).
-
antirez authored
This is just a quickfix, for the nature of the test the right way to fix it is to average the error of N runs, since otherwise it is always possible to get a false positive with a bad run, or to minimize too much this possibility we may end testing with too much "large" error ranges.
-
- 22 Jul, 2014 5 commits
-
-
antirez authored
This is not a regression but issue #1786 showed the need for this test.
-
antirez authored
-
antirez authored
The user @kjmph provided excellent ideas to improve speed of ZUNIONSTORE (in certain cases by many order of magnitude), together with an implementation of the ideas. While the ideas were sounding, the implementation could be improved both in terms of speed and clearness, so that's my attempt at reimplementing the speedup proposed, trying to improve by directly using just a dictionary with an embedded score inside, and reusing the single-pass aggregate + order-later approach. Note that you can't apply this commit without applying the previous commit in this branch that adds a double in the dictEntry value union. Issue #1786.
-
antirez authored
-
antirez authored
For non-empty masters, CLUSTER RESET is denied, and the user requires to start to reset a node by explicitly clearing it with FLUSHALL. However CLUSTER RESET when executed with slaves don't have this restrictions since data is just a replica of the master, and with read-only slaves it is also not possible to remove the data set. However the node was turned from slave to master after a reset, without touching the old slave data. This is 99.99% of times not appropriate and forces full resets to follow this path to work with both slave and master nodes: FLUSHALL CLUSTER RESET HARD FLUSHALL Since we need the first flushall for masters, and the second for slaves. This commit changes the behavior so that CLUSTER RESET removes the data set of a slave node during a reset, in the moment it gets turned into a master, so the new pattern is simply: FLUSHALL (that may fail for slaves) CLUSTER RESET
-
- 21 Jul, 2014 1 commit
-
-
antirez authored
-