1. 24 Mar, 2015 1 commit
    • antirez's avatar
      Cluster: redirection refactoring + handling of blocked clients. · 9b7f8b1c
      antirez authored
      There was a bug in Redis Cluster caused by clients blocked in a blocking
      list pop operation, for keys no longer handled by the instance, or
      in a condition where the cluster became down after the client blocked.
      
      A typical situation is:
      
      1) BLPOP <somekey> 0
      2) <somekey> hash slot is resharded to another master.
      
      The client will block forever int this case.
      
      A symmentrical non-cluster-specific bug happens when an instance is
      turned from master to slave. In that case it is more serious since this
      will desynchronize data between slaves and masters. This other bug was
      discovered as a side effect of thinking about the bug explained and
      fixed in this commit, but will be fixed in a separated commit.
      9b7f8b1c
  2. 22 Mar, 2015 1 commit
  3. 21 Mar, 2015 5 commits
  4. 20 Mar, 2015 5 commits
    • antirez's avatar
    • antirez's avatar
      Cluster: separate unknown master check from the rest. · 230d1414
      antirez authored
      In no case we should try to attempt to failover if myself->slaveof is
      NULL.
      230d1414
    • antirez's avatar
      Cluster: refactoring around configEpoch handling. · 4f2555aa
      antirez authored
      This commit moves the process of generating a new config epoch without
      consensus out of the clusterCommand() implementation, in order to make
      it reusable for other reasons (current target is to have a CLUSTER
      FAILOVER option forcing the failover when no master majority is
      reachable).
      
      Moreover the commit moves other functions which are similarly related to
      config epochs in a new logical section of the cluster.c file, just for
      clarity.
      4f2555aa
    • antirez's avatar
      Cluster: better cluster state transiction handling. · 25c0f5ac
      antirez authored
      Before we relied on the global cluster state to make sure all the hash
      slots are linked to some node, when getNodeByQuery() is called. So
      finding the hash slot unbound was checked with an assertion. However
      this is fragile. The cluster state is often updated in the
      clusterBeforeSleep() function, and not ASAP on state change, so it may
      happen to process clients with a cluster state that is 'ok' but yet
      certain hash slots set to NULL.
      
      With this commit the condition is also checked in getNodeByQuery() and
      reported with a identical error code of -CLUSTERDOWN but slightly
      different error message so that we have more debugging clue in the
      future.
      
      Root cause of issue #2288.
      25c0f5ac
    • antirez's avatar
      Cluster: move clusterBeforeSleep() call before unblocked clients processing. · 2ecb5edf
      antirez authored
      Related to issue #2288.
      2ecb5edf
  5. 18 Mar, 2015 1 commit
  6. 13 Mar, 2015 2 commits
  7. 12 Mar, 2015 2 commits
  8. 11 Mar, 2015 4 commits
  9. 10 Mar, 2015 3 commits
  10. 08 Mar, 2015 1 commit
  11. 04 Mar, 2015 1 commit
    • antirez's avatar
      Fix iterator for issue #2438. · 509a6cc1
      antirez authored
      Itereator misuse due to analyzeLatencyForEvent() accessing the
      dictionary during the iteration, without the iterator being
      reclared as safe.
      509a6cc1
  12. 27 Feb, 2015 8 commits
  13. 26 Feb, 2015 2 commits
    • antirez's avatar
      Improvements to PR #2425 · 832b0c7c
      antirez authored
      1. Remove useless "cs" initialization.
      2. Add a "select" var to capture a condition checked multiple times.
      3. Avoid duplication of the same if (!copy) conditional.
      4. Don't increment dirty if copy is given (no deletion is performed),
         otherwise we propagate MIGRATE when not needed.
      832b0c7c
    • Tommy Wang's avatar
      Add last_dbid to migrateCachedSocket to avoid redundant SELECT · 7fda935a
      Tommy Wang authored
      Avoid redundant SELECT calls when continuously migrating keys to
      the same dbid within a target Redis instance.
      7fda935a
  14. 25 Feb, 2015 1 commit
  15. 24 Feb, 2015 1 commit
  16. 23 Feb, 2015 1 commit
  17. 21 Feb, 2015 1 commit