1. 05 Aug, 2015 2 commits
    • antirez's avatar
      PSYNC initial offset fix. · 9d297218
      antirez authored
      This commit attempts to fix a bug involving PSYNC and diskless
      replication (currently experimental) found by Yuval Inbar from Redis Labs
      and that was later found to have even more far reaching effects (the bug also
      exists when diskstore is off).
      
      The gist of the bug is that, a Redis master replies with +FULLRESYNC to
      a PSYNC attempt that fails and requires a full resynchronization.
      However, the baseline offset sent along with FULLRESYNC was always the
      current master replication offset. This is not ok, because there are
      many reasosn that may delay the RDB file creation. And... guess what,
      the master offset we communicate must be the one of the time the RDB
      was created. So for example:
      
      1) When the BGSAVE for replication is delayed since there is one
         already but is not good for replication.
      2) When the BGSAVE is not needed as we attach one currently ongoing.
      3) When because of diskless replication the BGSAVE is delayed.
      
      In all the above cases the PSYNC reply is wrong and the slave may
      reconnect later claiming to need a wrong offset: this may cause
      data curruption later.
      9d297218
    • antirez's avatar
      Test PSYNC with diskless replication. · 32e97980
      antirez authored
      Thanks to Oran Agra from Redis Labs for providing this patch.
      32e97980
  2. 17 Jul, 2015 5 commits
  3. 16 Jul, 2015 2 commits
    • antirez's avatar
      Client timeout handling improved. · b029ff11
      antirez authored
      The previos attempt to process each client at least once every ten
      seconds was not a good idea, because:
      
      1. Usually because of the past min iterations set to 50, you get much
      better processing period most of the times.
      
      2. However when there are many clients and a normal setting for
      server.hz, the edge case is triggered, and waiting 10 seconds for a
      BLPOP that asked for 1 second is not ok.
      
      3. Moreover, because of the high min-itereations limit of 50, when HZ
      was set to an high value, the actual behavior was to process a lot of
      clients per second.
      
      Also the function checking for timeouts called gettimeofday() at each
      iteration which can be costly.
      
      The new implementation will try to process each client once per second,
      gets the current time as argument, and does not attempt to process more
      than 5 clients per iteration if not needed.
      
      So now:
      
      1. The CPU usage of an idle Redis process is the same or better.
      2. The CPU usage of a busy Redis process is the same or better.
      3. However a non trivial amount of work may be performed per iteration
      when there are many many clients. In this particular case the user may
      want to raise the "HZ" value if needed.
      
      Btw with 4000 clients it was still not possible to noticy any actual
      latency created by processing 400 clients per second, since the work
      performed for each client is pretty small.
      b029ff11
    • antirez's avatar
      Clarify a comment in clientsCron(). · 5dcba26b
      antirez authored
      5dcba26b
  4. 13 Jul, 2015 1 commit
    • antirez's avatar
      EXISTS is now variadic. · 7ae1d4d6
      antirez authored
      The new return value is the number of keys existing, among the ones
      specified in the command line, counting the same key multiple times if
      given multiple times (and if it exists).
      
      See PR #2667.
      7ae1d4d6
  5. 29 Jun, 2015 1 commit
  6. 11 Jun, 2015 5 commits
    • linfangrong's avatar
      Update t_zset.c · d4a7c9e1
      linfangrong authored
      d4a7c9e1
    • antirez's avatar
      Use best effort address binding to connect to the master · 4e8759c6
      antirez authored
      We usually want to reach the master using the address of the interface
      Redis is bound to (via the "bind" config option). That's useful since
      the master will get (and publish) the slave address getting the peer
      name of the incoming socket connection from the slave.
      
      However, when this is not possible, for example because the slave is
      bound to the loopback interface but repliaces from a master accessed via
      an external interface, we want to still connect with the master even
      from a different interface: in this case it is not really important that
      the master will provide any other address, while it is vital to be able
      to replicate correctly.
      
      Related to issues #2609 and #2612.
      4e8759c6
    • antirez's avatar
      anet.c: new API anetTcpNonBlockBestEffortBindConnect() · a8d7f00e
      antirez authored
      This performs a best effort source address binding attempt. If it is
      possible to bind the local address and still have a successful
      connect(), then this socket is returned. Otherwise the call is retried
      without source address binding attempt.
      
      Related to issues #2609 and #2612.
      a8d7f00e
    • antirez's avatar
      anetTcpGenericConnect(), jump to error not end on error · af8a9de6
      antirez authored
      Two code paths jumped to the "ok, return the socket to the user" code
      path to handle error conditions.
      
      Related to issues #2609 and #2612.
      af8a9de6
    • antirez's avatar
      Don't try to bind the source address for MIGRATE · d815289d
      antirez authored
      Related to issues #2609 and #2612.
      d815289d
  7. 04 Jun, 2015 2 commits
  8. 03 Jun, 2015 3 commits
  9. 29 May, 2015 8 commits
  10. 25 May, 2015 1 commit
    • therealbill's avatar
      adding a sentinel command: "flushconfig" · e252e9f2
      therealbill authored
      This new command triggers a config flush to save the in-memory config to
      disk. This is useful for cases of a configuration management system or a
      package manager wiping out your sentinel config while the process is
      still running - and has not yet been restarted. It can also be useful
      for scripting a backup and migrate or clone of a running sentinel.
      e252e9f2
  11. 19 May, 2015 2 commits
  12. 15 May, 2015 5 commits
  13. 07 May, 2015 1 commit
  14. 05 May, 2015 2 commits