- 07 May, 2015 1 commit
-
-
antirez authored
Since with a previous commit Sentinels now persist their unique ID, we no longer need to detect duplicated Sentinels and re-add them. We remove and re-add back using different events only in the case of address switch of the same Sentinel, without generating a new +sentinel event.
-
- 06 May, 2015 1 commit
-
-
antirez authored
Previously Sentinels always changed unique ID across restarts, relying on the server.runid field. This is not a good idea, and forced Sentinel to rely on detection of duplicated Sentinels and a potentially dangerous clean-up and re-add operation of the Sentinel instance that was rebooted. Now the ID is generated at the first start and persisted in the configuration file, so that a given Sentinel will have its unique ID forever (unless the configuration is manually deleted or there is a filesystem corruption).
-
- 05 May, 2015 4 commits
- 04 May, 2015 6 commits
-
-
Salvatore Sanfilippo authored
fix sds.c
-
Salvatore Sanfilippo authored
update copyright year
-
therealbill authored
Originally, only the +slave event which occurs when a slave is reconfigured during sentinelResetMasterAndChangeAddress triggers a flush of the config to disk. However, newly discovered slaves don't apparently trigger this flush but do trigger the +slave event issuance. So if you start up a sentinel, add a master, then add a slave to the master (as a way to reproduce it) you'll see the +slave event issued, but the sentinel config won't be updated with the known-slave entry. This change makes sentinel do the flush of the config if a new slave is deteted in sentinelRefreshInstanceInfo.
-
antirez authored
To rewrite the config in the loop that adds slaves back after a master reset, in order to handle switching to another master, is useless: it just adds latency since there is an fsync call in the inner loop, without providing any additional guarantee, but the contrary, since if after the first loop iteration the server crashes we end with just a single slave entry losing all the other informations. It is wiser to rewrite the config at the end when the full new state is configured.
-
Salvatore Sanfilippo authored
Fix Redis server crash when Lua command exceeds client output buffer limit.
-
Salvatore Sanfilippo authored
fix sentinel memory leak
-
- 29 Apr, 2015 3 commits
-
-
antirez authored
-
antirez authored
As suggested in #2543.
-
Salvatore Sanfilippo authored
Fix spelling and grammatical errors in readme
-
- 28 Apr, 2015 4 commits
-
-
antirez authored
This fixes issue #2535, that was actually an hiredis library bug (I submitted an issue and fix to the redis/hiredis repo as well). When an asynchronous hiredis connection subscribes to a Pub/Sub channel and gets an error, and in other related conditions, the function redisProcessCallbacks() enters a code path where the link is disconnected, however the function returns before freeing the allocated reply object. This causes a memory leak. The memory leak was trivial to trigger in Redis Sentinel, which uses hiredis, every time we tried to subscribe to an instance that required a password, in case the Sentinel was configured either with the wrong password or without password at all. In this case, the -AUTH error caused the leaking code path to be executed. It was verified with Valgrind that after this change the leak no longer happens in Sentinel with a misconfigured authentication password.
-
clark.kang authored
-
Jan-Erik Rediger authored
-
Jan-Erik Rediger authored
Closes #2549
-
- 27 Apr, 2015 2 commits
- 26 Apr, 2015 2 commits
-
-
antirez authored
An user changed the behavior via a PR without upgrading the doc.
-
Yossi Gottlieb authored
limit.
-
- 24 Apr, 2015 1 commit
-
-
Salvatore Sanfilippo authored
Added reference to IANA ticket for port 6379
-
- 23 Apr, 2015 1 commit
-
-
Itamar Haber authored
Just so it's extra official
😄
-
- 21 Apr, 2015 1 commit
-
-
Itamar Haber authored
-
- 20 Apr, 2015 2 commits
-
-
FuGangqiang authored
-
FuGangqiang authored
-
- 19 Apr, 2015 1 commit
-
-
FuGangqiang authored
-
- 01 Apr, 2015 2 commits
-
-
antirez authored
When we fail to setup the write handler it does not make sense to take the client around, it is missing writes: whatever is a client or a slave anyway the connection should terminated ASAP. Moreover what the function does exactly with its return value, and in which case the write handler is installed on the socket, was not clear, so the functions comment are improved to make the goals of the function more obvious. Also related to #2485.
-
Salvatore Sanfilippo authored
fixes to diskless replication.
-
- 31 Mar, 2015 3 commits
-
-
antirez authored
This should likely fix a false positive when running with the --valgrind option.
-
Oran Agra authored
master was closing the connection if the RDB transfer took long time. and also sent PINGs to the slave before it got the initial ACK, in which case the slave wouldn't be able to find the EOF marker.
-
antirez authored
Segfault introduced during a refactoring / warning suppression a few commits away. This particular call assumed that it is safe to pass NULL to the object pointer argument when we are sure the set has a given encoding. This can't be assumed and is now guaranteed to segfault because of the new API of setTypeNext().
-
- 30 Mar, 2015 4 commits
-
-
antirez authored
-
antirez authored
This change fixes several warnings compiling at -O3 level with GCC 4.8.2, and at the same time, in case of misuse of the API, we have the pointer initialize to NULL or the integer initialized to the value -123456789 which is easy to spot by naked eye.
-
antirez authored
Another one just to avoid a warning. Slightly more defensive code anyway.
-
antirez authored
Change done in order to remove a warning and improve code robustness. No actual bug here.
-
- 27 Mar, 2015 2 commits