1. 07 May, 2015 1 commit
    • antirez's avatar
      Sentinel: don't detect duplicated Sentinels, just address switch · a0cd75cd
      antirez authored
      Since with a previous commit Sentinels now persist their unique ID, we
      no longer need to detect duplicated Sentinels and re-add them. We remove
      and re-add back using different events only in the case of address
      switch of the same Sentinel, without generating a new +sentinel event.
      a0cd75cd
  2. 06 May, 2015 1 commit
    • antirez's avatar
      Sentinel: persist its unique ID across restarts. · 794fc4c9
      antirez authored
      Previously Sentinels always changed unique ID across restarts, relying
      on the server.runid field. This is not a good idea, and forced Sentinel
      to rely on detection of duplicated Sentinels and a potentially dangerous
      clean-up and re-add operation of the Sentinel instance that was
      rebooted.
      
      Now the ID is generated at the first start and persisted in the
      configuration file, so that a given Sentinel will have its unique
      ID forever (unless the configuration is manually deleted or there is a
      filesystem corruption).
      794fc4c9
  3. 05 May, 2015 4 commits
  4. 04 May, 2015 6 commits
  5. 29 Apr, 2015 3 commits
  6. 28 Apr, 2015 4 commits
    • antirez's avatar
      Fix Sentinel memory leak (hiredis bug) · c806dd79
      antirez authored
      This fixes issue #2535, that was actually an hiredis library bug (I
      submitted an issue and fix to the redis/hiredis repo as well).
      
      When an asynchronous hiredis connection subscribes to a Pub/Sub channel
      and gets an error, and in other related conditions, the function
      redisProcessCallbacks() enters a code path where the link is
      disconnected, however the function returns before freeing the allocated
      reply object. This causes a memory leak. The memory leak was trivial to
      trigger in Redis Sentinel, which uses hiredis, every time we tried to
      subscribe to an instance that required a password, in case the Sentinel
      was configured either with the wrong password or without password at
      all. In this case, the -AUTH error caused the leaking code path to be
      executed.
      
      It was verified with Valgrind that after this change the leak no longer
      happens in Sentinel with a misconfigured authentication password.
      c806dd79
    • clark.kang's avatar
      fix sentinel memory leak · eff212ea
      clark.kang authored
      eff212ea
    • Jan-Erik Rediger's avatar
      One more small fix · fb532881
      Jan-Erik Rediger authored
      fb532881
    • Jan-Erik Rediger's avatar
      Fix spelling and grammatical errors in readme · 3ff49aff
      Jan-Erik Rediger authored
      Closes #2549
      3ff49aff
  7. 27 Apr, 2015 2 commits
  8. 26 Apr, 2015 2 commits
  9. 24 Apr, 2015 1 commit
  10. 23 Apr, 2015 1 commit
  11. 21 Apr, 2015 1 commit
  12. 20 Apr, 2015 2 commits
  13. 19 Apr, 2015 1 commit
  14. 01 Apr, 2015 2 commits
  15. 31 Mar, 2015 3 commits
    • antirez's avatar
      Test: be more patient waiting for servers to exit. · 38680424
      antirez authored
      This should likely fix a false positive when running with the --valgrind
      option.
      38680424
    • Oran Agra's avatar
      fixes to diskless replication. · 159875b5
      Oran Agra authored
      master was closing the connection if the RDB transfer took long time.
      and also sent PINGs to the slave before it got the initial ACK, in which case the slave wouldn't be able to find the EOF marker.
      159875b5
    • antirez's avatar
      Fix setTypeNext call assuming NULL can be passed. · 66f9393e
      antirez authored
      Segfault introduced during a refactoring / warning suppression a few
      commits away. This particular call assumed that it is safe to pass NULL
      to the object pointer argument when we are sure the set has a given
      encoding. This can't be assumed and is now guaranteed to segfault
      because of the new API of setTypeNext().
      66f9393e
  16. 30 Mar, 2015 4 commits
  17. 27 Mar, 2015 2 commits