- 22 May, 2021 1 commit
-
-
wuYin authored
Already verified that start < len, so if end >= len, then start cannot be > len.
-
- 20 May, 2021 3 commits
-
-
YaacovHazan authored
When test stop 'load handler' by killing the process that generating the load, some commands that already in the input buffer, still might be processed by the server. This may cause some instability in tests, that count on that no more commands processed after we stop the `load handler' In this commit, new proc 'wait_load_handlers_disconnected' added, to verify that no more cammands from any 'load handler' prossesed, by checking that the clients who genreate the load is disconnceted. Also, replacing check of dbsize with wait_for_ofs_sync before comparing debug digest, as it would fail in case the last key the workload wrote was an overridden key (not a new one). Affected tests Race fix: - failover command to specific replica works - Connect multiple replicas at the same time (issue #141), master diskless=$mdl, replica diskless=$sdl - AOF rewrite during write load: RDB preamble=$rdbpre Cleanup and speedup: - Test replication with blocking lists and sorted sets operations - Test replication with parallel clients writing in different DBs - Test replication partial resync: $descr (diskless: $mdl, $sdl, reconnect: $reconnect
-
Wang Yuan authored
In theory we should have used zmalloc_usable_size, but it may be slower, and now after #7875, there's no actual difference. So this change isn't making a dramatic change. Co-authored-by:
Oran Agra <oran@redislabs.com>
-
Wang Yuan authored
According jemalloc size classes, we may allocate much more memory than our setting of repl_backlog_size, but we don't make full use of it.
-
- 19 May, 2021 5 commits
-
-
Madelyn Olson authored
Redact commands that include sensitive data from slowlog and monitor
-
Oran Agra authored
I recently saw this failure: [err]: lazy free a stream with all types of metadata in tests/unit/lazyfree.tcl Expected '2' to be equal to '1' (context: type eval line 23 cmd {assert_equal [s lazyfreed_objects] 1} proc ::test) The only explanation for such a thing is that the async flushdb wasn't done before we did the resetstat
-
Huang Zhw authored
which make interleaved_len bigger and may access array out of range.
-
Bonsai authored
-
DarrenJiang13 authored
when string2ll was made to replace isStringRepresentableAsLongLong (which was similar to what rdbTryIntegerEncoding does), rdbTryIntegerEncoding was probably forgotten.
-
- 18 May, 2021 8 commits
-
-
Binbin authored
incrementing the defragged hits counter twice in activeDefragSdsListAndDict
-
Eduardo Felipe authored
Add documentation for `firstkey`, `lastkey` and `keystep` parameters of `RedisModule_CreateCommand` (#8883) These parameters of RedisModule_CreateCommand were previously undocumented but they are needed for ACL to check permission on keys and by Redis Cluster to figure our how to route the command. Co-authored-by:
Eduardo Felipe Castegnaro <edufelipe@onsign.tv> Co-authored-by:
Oran Agra <oran@redislabs.com>
-
Guy Korland authored
This parameter of type GeoHashRadius is 192 bytes - passing a `const` pointer instead.
-
Oran Agra authored
the test normally passes. but we saw one failure in a valgrind run in github actions
-
Oran Agra authored
As far as i can tell it shows up in redis-cli in both HELP, e.g. `help client list`, and also in the command completion tips, but it is unclear what it was needed for. It exists since the very first commit that added this mechanism.
-
Oran Agra authored
-
Huang Zhw authored
Currently in redis-cli only AUTH and ACL SETUSER bypass history file. We add CONFIG SET masterauth/masteruser/requirepass, HELLO with AUTH, MIGRATE with AUTH or AUTH2 to bypass history file too. The drawback is HELLO and MIGRATE's code is a mess. Someday if we change these commands, we have to change here too.
-
Binbin authored
There's an infinite loop when redis-cli fails to connect in cluster mode. This commit adds a 1 second sleep to prevent flooding the console with errors. It also adds a specific error print in a few places that could have error without printing anything. Co-authored-by:
Oran Agra <oran@redislabs.com>
-
- 17 May, 2021 3 commits
-
-
zhaozhao.zz authored
Improve performance by avoiding inefficiencies in the parent process during AOFRW. * AOF: record the latency of aofChildWriteDiffData * AOF: avoid memmove in aofChildWriteDiffData
-
Oran Agra authored
And also add tests to cover lazy free of streams with various types of metadata (see #8932)
-
Huang Zhw authored
There are two bugs in redis-cli hints: * The hints of commands with subcommands lack first params. * When search matching command of currently input, we should find the command with longest matching prefix. If not COMMAND INFO will always match COMMAND and display no hints.
-
- 15 May, 2021 1 commit
-
-
patpatbear authored
this patch fixes sinterstore by add missing keyspace del event when any source set not exists. Co-authored-by:
srzhao <srzhao@sysnew.com>
-
- 14 May, 2021 1 commit
-
-
Madelyn Olson authored
Moved security bugs and vulnerability policy to SECURITY.MD and extended security policy. Co-authored-by:
Yossi Gottlieb <yossigo@gmail.com>
-
- 13 May, 2021 1 commit
-
-
Raghav Muddur authored
* EVALSHA_RO and EVAL_RO Commands Added new readonly versions of EVAL and EVALSHA.
-
- 11 May, 2021 1 commit
-
-
George Anderson Guimarães authored
Check for errors in inet_ntop and snprintf rather than ignore them and return success (with garbage output). The check for ip_len == 0 seems like dead code, removed.
-
- 10 May, 2021 3 commits
-
-
Huang Zhw authored
-
Oran Agra authored
When estimating the effort for unlink, we try to compute the effort of the first group and extrapolate. If there's a groups rax that's empty, there'a an assertion. reproduce: xadd s * a b xgroup create s bla $ xgroup destroy s bla unlink s
-
Binbin authored
Also fixes a chance for compilation error if REDIS_TEST_VERBOSE would be used.
-
- 09 May, 2021 3 commits
- 07 May, 2021 1 commit
-
-
Binbin authored
-
- 06 May, 2021 3 commits
-
-
Huang Zhw authored
when SELECT fails, we should reset dbnum to 0, so the prompt will not display incorrectly. Additionally when SELECT and HELLO fail, we output message to inform it. Add config.input_dbnum which means the dbnum about to select. And config.dbnum means currently selected dbnum. When users succeed to select db, config.dbnum and config.input_dbnum will be the same. When users select db failed, config.input_dbnum will be kept. Next time if users auth success, config.input_dbnum will be automatically selected. When reconnect, we should select the origin dbnum. Co-authored-by:
Oran Agra <oran@redislabs.com>
-
Oran Agra authored
Redis Enterprise supports the CONFIG GET command, but it replies with am empty array since the save and appendonly configs are not supported. before this fix redis-benchmark would segfault for trying to access the error string on an array type reply. see #8869
-
Wang Yuan authored
Always 0 MB of memory used by copy-on-write, introduced in #8645.
-
- 05 May, 2021 1 commit
-
-
Zerong Yao authored
Minor code cleanup.
-
- 04 May, 2021 2 commits
-
-
Binbin authored
-
yoav-steinberg authored
When client breached the output buffer soft limit but then went idle, we didn't disconnect on soft limit timeout, now we do. Note this also resolves some sporadic test failures in due to Linux buffering data which caused tests to fail if during the test we went back under the soft COB limit. Co-authored-by:
Oran Agra <oran@redislabs.com> Co-authored-by:
sundb <sundbcn@gmail.com>
-
- 03 May, 2021 3 commits
-
-
Oran Agra authored
-
Oran Agra authored
An integer overflow bug in Redis version 6.0 or newer could be exploited using the STRALGO LCS command to corrupt the heap and potentially result with remote code execution.
-
Oran Agra authored
An integer overflow bug in Redis 6.2 could be exploited to corrupt the heap and potentially result with remote code execution. The vulnerability involves changing the default set-max-intset-entries configuration value, creating a large set key that consists of integer values and using the COPY command to duplicate it. The integer overflow bug exists in all versions of Redis starting with 2.6, where it could result with a corrupted RDB or DUMP payload, but not exploited through COPY (which did not exist before 6.2).
-