- 27 Aug, 2014 26 commits
-
-
charsyam authored
Closes #1129
-
Matt Stancliff authored
Previously, "MOVE key somestring" would move the key to DB 0 which is just unexpected and wrong. String as DB == error. Test added too. Modified by @antirez in order to use the getLongLongFromObject() API instead of strtol(). Fixes #1428
-
Matt Stancliff authored
Also adds test for numsub — due to tcl being tcl, it doesn't capture the "numberness" of the fix, but now we at least have one test case for numsub. Closes #1561
-
Xiaojie Zhang authored
Closes #1519
-
Samuel Chou authored
[I had to split out the clang check due to clang *really* not liking the __GLIBC_PREREQ macro; -matt] Closes #1456
-
Jim Howard authored
Reason: https://github.com/antirez/redis/pull/1450#issuecomment-30432925 Closes #1450
-
Xian Li authored
Closes #1614
-
Joshua Anderson authored
Closes #1610
-
cubicdaiya authored
According to the C standard, it is desirable to give the type 'void' to functions have no argument. Closes #1631
-
Matt Stancliff authored
dictAdd returns DICT_OK, not REDIS_OK. They both have the same underlying values, so it works even though the code is technically wrong. Fixes #1512
-
Jan-Erik Rediger authored
This was discovered by _bodya and reported in the IRC channel. Everything worked fine as these scripts are always executed as shell scripts. Closes #1728
-
Edgars Irmejs authored
According to unix manuals, "Connecting to the socket object requires read/write permission." -- mode 755 is useless for anybody other than the owner. Fixes #1696
-
ripcurld00d authored
Use constants to avoid magic numbers in `types`, which is an array that stores the names of `REDIS` types. Closes #1681
-
Kashif Rasul authored
Modified by @antirez since the original fix to genInfoString() looked weak. Probably the clang analyzer complained about `section` being possibly NULL, and strcasecmp() called with a NULL pointer. In the practice this can never happen, still for the sake of correctness the right fix is not to modify only the first call, but to set `section` to the value of "default" if it happens to be NULL. Closes #1660
-
antirez authored
Also quit ASAP when we are still loading a DB, since care is not needed in this special condition, especially for a SIGINT.
-
Matt Stancliff authored
-
Matt Stancliff authored
The classic (min+max)/2 is provably unsafe. Fixed as recommended in research: http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html Fix inspired by @wjin, but I used a different approach. (later, I found @kuebler fixed the same issue too). Fixes #1741, #1602
-
Jan-Erik Rediger authored
Previously the end was casted to a smaller type which resulted in a wrong check and failed with values larger than handled by unsigned. Closes #1847, #1844
-
Matt Stancliff authored
Negative key count causes segfault in Lua functions. Fixes #1842 Closes #1843
-
Jan-Erik Rediger authored
(Cleaned up a little by @mattsta) Closes #1774
-
Wei Jin authored
Fixes #1741
-
antirez authored
-
siahl authored
Closes #1900
-
Matt Stancliff authored
Some people need formatted output even when they have no interactive tty. Fixes #760
-
Matt Stancliff authored
Previously redis-cli would happily show "-1" or "99999" as valid DB choices. Now, if the SELECT call returned an error, we don't update the DB number in the CLI. Inspired by @anupshendkar in #1313 Fixes #566, #1313
-
Matt Stancliff authored
Previously, if you did SELECT then AUTH, redis-cli would show your SELECT'd db even though it didn't happen. Note: running into this situation is a (hopefully) very limited used case of people using multiple DBs and AUTH all at the same time. Fixes antirez#1639
-
- 28 Jul, 2014 3 commits
-
-
Yossi Gottlieb authored
-
Salvatore Sanfilippo authored
* fixed doc URL for keyspace events
-
vps authored
-
- 25 Jul, 2014 1 commit
-
-
antirez authored
-
- 23 Jul, 2014 3 commits
-
-
antirez authored
-
antirez authored
Based on ideas documented in this blog post: https://www.facebook.com/notes/facebook-engineering/three-optimization-tips-for-c/10151361643253920 The original code was modified to handle signed integers, reformetted to fit inside the Redis code base, and was stress-tested with a program in order to validate the implementation against snprintf(). Redis was measured to be measurably faster from the point of view of clients in real-world operations because of this change, since sometimes number to string conversion is used extensively (for example every time a GET results into an integer encoded object to be returned to the user).
-
antirez authored
This is just a quickfix, for the nature of the test the right way to fix it is to average the error of N runs, since otherwise it is always possible to get a false positive with a bad run, or to minimize too much this possibility we may end testing with too much "large" error ranges.
-
- 22 Jul, 2014 4 commits
-
-
antirez authored
This is not a regression but issue #1786 showed the need for this test.
-
antirez authored
-
antirez authored
The user @kjmph provided excellent ideas to improve speed of ZUNIONSTORE (in certain cases by many order of magnitude), together with an implementation of the ideas. While the ideas were sounding, the implementation could be improved both in terms of speed and clearness, so that's my attempt at reimplementing the speedup proposed, trying to improve by directly using just a dictionary with an embedded score inside, and reusing the single-pass aggregate + order-later approach. Note that you can't apply this commit without applying the previous commit in this branch that adds a double in the dictEntry value union. Issue #1786.
-
antirez authored
-
- 18 Jul, 2014 3 commits