- 17 Jan, 2014 3 commits
- 16 Jan, 2014 4 commits
- 15 Jan, 2014 9 commits
-
-
antirez authored
CLUSTER FORGET is not useful if we can't remove a node from all the nodes of our cluster because of the Gossip protocol that keeps adding a given node to nodes where we already tried to remove it. So now CLUSTER FORGET implements a nodes blacklist that is set and checked by the Gossip section processing function. This way before a node is re-added at least 60 seconds must elapse since the FORGET execution. This means that redis-trib has some time to remove a node from a whole cluster. It is possible that in the future it will be uesful to raise the 60 sec figure to something bigger.
-
antirez authored
The hash table value should be set to now + 60 seconds otherwise it expires immediately.
-
antirez authored
We can't lookup by node->name that's not an SDS string but a plain C array in the node structure.
-
antirez authored
-
antirez authored
The rejoin delay usually is the node timeout. However if the node timeout is too small, we set it to 500 milliseconds, that is a value chosen to be greater than most setups RTT / instances latency figures so that likely communication with other nodes happen before rejoining.
-
antirez authored
Usually we update the cluster state (to understand if we should accept queries or reply with an error) only when there is a change in the state of the nodes. However for the "delayed rejoin" feature to work, that is, for a master to wait some time before accepting queries again after it rejoins the majority, we need to periodically update the last time when the node was partitioned away from the majority. With this commit if the cluster is down we update the state ten times per second.
-
antirez authored
See issue #1426 on Github.
-
antirez authored
Even without the user messing manually with the file, it is still possible to have blank lines (just a single "\n" per line) because of how the nodes.conf update/write process works.
-
antirez authored
The way the file was generated was unsafe and leaded to nodes.conf file corruption (zero length file) on server stop/crash during the creation of the file. The previous file update method was as simple as open with O_TRUNC followed by the write call. While the write call was a single one with the full payload, ensuring no half-written files for POSIX semantics, stopping the server just after the open call resulted into a zero-length file (all the nodes information lost!).
-
- 14 Jan, 2014 4 commits
-
-
antirez authored
A client can enter a special cluster read-only mode using the READONLY command: if the client read from a slave instance after this command, for slots that are actually served by the instance's master, the queries will be processed without redirection, allowing clients to read from slaves (but without any kind fo read-after-write guarantee). The READWRITE command can be used in order to exit the readonly state.
-
antirez authored
-
antirez authored
64mb is the default value in redis.conf. For some reason instead the hard-coded default was 1mb that is too small.
-
antirez authored
-
- 13 Jan, 2014 3 commits
- 10 Jan, 2014 9 commits
-
-
antirez authored
The command totally removes a monitored master.
-
antirez authored
The claim about unlinking the instance from the connected hash tables was the opposite of the reality. Also the current actual behavior is safer in most cases, so it is better to manually unlink when needed.
-
antirez authored
-
antirez authored
-
antirez authored
It allows to add new masters to monitor at runtime.
-
antirez authored
The new function is used when we want to normalize an IP address without performing a DNS lookup if the string to resolve is not a valid IP. This is useful every time only IPs are valid inputs or when we want to skip DNS resolution that is slow during runtime operations if we are required to block.
-
antirez authored
With SENTINEL MASTERS it was already possible to list all the configured masters, but not a specific one.
-
antirez authored
Note: the auth password with the master is voluntarily not exposed.
-
antirez authored
-
- 09 Jan, 2014 2 commits
- 08 Jan, 2014 4 commits
-
-
antirez authored
Fixes issue #1491 on Github.
-
antirez authored
-
antirez authored
Masters not understanding REPLCONF ACK will reply with errors to our requests causing a number of possible issues. This commit detects a global replication offest set to -1 at the end of the replication, and marks the client representing the master with the REDIS_PRE_PSYNC flag. Note that this flag was called REDIS_PRE_PSYNC_SLAVE but now it is just REDIS_PRE_PSYNC as it is used for both slaves and masters starting with this commit. This commit fixes issue #1488.
-
antirez authored
-
- 25 Dec, 2013 2 commits