- 08 May, 2013 6 commits
-
-
antirez authored
-
antirez authored
The test checks both successful syncs and unsuccessful ones by changing the backlog size.
-
antirez authored
The test actually worked, but vars for master and slave were inverted and sometimes used incorrectly.
-
antirez authored
This reverts commit 2c75f2cf. After further analysis, it is very unlikely that we'll raise the string size limit to > 512MB, and at the same time such big strings will be used in 32 bit systems. Better to revert to size_t so that 32 bit processors will not be forced to use a 64 bit counter in normal operations, that is currently completely useless.
-
Salvatore Sanfilippo authored
in 32bit machine, popcount don't work with a input string length up to 5...
-
antirez authored
-
- 07 May, 2013 2 commits
-
-
Jiahao Huang authored
-
Jiahao Huang authored
bitcount commant may return negtive integer with string length more than 256 MB
-
- 03 May, 2013 5 commits
-
-
antirez authored
When the PONG delay is half the cluster node timeout, the link gets disconnected (and later automatically reconnected) in order to ensure that it's not just a dead connection issue. However this operation is only performed if the link is old enough, in order to avoid to disconnect the same link again and again (and among the other problems, never receive the PONG because of that). Note: when the link is reconnected, the 'ping_sent' field is not updated even if a new ping is sent using the new connection, so we can still reliably detect a node ping timeout.
-
antirez authored
-
antirez authored
-
antirez authored
Also clusterBroadcastPing() was renamed into clusterBroadcastPong() that's what the function is actually doing.
-
antirez authored
-
- 02 May, 2013 3 commits
-
-
antirez authored
This is just to make the code exactly like the above instance used for requirepass. No actual change nor the original code violated the Redis coding style.
-
Michel Martens authored
-
charsyam authored
There was a race condition in the AOF rewrite code that, with bad enough timing, could cause a volatile key just about to expire to be turned into a non-volatile key. The bug was never reported to cause actualy issues, but was found analytically by an user in the Redis mailing list: https://groups.google.com/forum/?fromgroups=#!topic/redis-db/Kvh2FAGK4Uk This commit fixes issue #1079.
-
- 30 Apr, 2013 2 commits
-
-
antirez authored
Tilt mode was too aggressive (not processing INFO output), this resulted in a few problems: 1) Redirections were not followed when in tilt mode. This opened a window to misinform clients about the current master when a Sentinel was in tilt mode and a fail over happened during the time it was not able to update the state. 2) It was possible for a Sentinel exiting tilt mode to detect a false fail over start, if a slave rebooted with a wrong configuration about at the same time. This used to happen since in tilt mode we lose the information that the runid changed (reboot). Now instead the Sentinel in tilt mode will still remove the instance from the list of slaves if it changes state AND runid at the same time. Both are edge conditions but the changes should overall improve the reliability of Sentinel.
-
antirez authored
-
- 29 Apr, 2013 1 commit
-
-
antirez authored
-
- 26 Apr, 2013 1 commit
-
-
antirez authored
We used to always turn a master into a slave if the DEMOTE flag was set, as this was a resurrecting master instance. However the following race condition is possible for a Sentinel that got partitioned or internal issues (tilt mode), and was not able to refresh the state in the meantime: 1) Sentinel X is running, master is instance "A". 3) "A" fails, sentinels will promote slave "B" as master. 2) Sentinel X goes down because of a network partition. 4) "A" returns available, Sentinels will demote it as a slave. 5) "B" fails, other Sentinels will promote slave "A" as master. 6) At this point Sentinel X comes back. When "X" comes back he thinks that: "B" is the master. "A" is the slave to demote. We want to avoid that Sentinel "X" will demote "A" into a slave. We also want that Sentinel "X" will detect that the conditions changed and will reconfigure itself to monitor the right master. There are two main ways for the Sentinel to reconfigure itself after this event: 1) If "B" is reachable and already configured as a slave by other sentinels, "X" will perform a redirection to "A". 2) If there are not the conditions to demote "A", the fact that "A" reports to be a master will trigger a failover detection in "X", that will end into a reconfiguraiton to monitor "A". However if the Sentinel was not reachable, its state may not be updated, so in case it titled, or was partiitoned from the master instance of the slave to demote, the new implementation waits some time (enough to guarantee we can detect the new INFO, and new DOWN conditions). If after some time still there are not the right condiitons to demote the instance, the DEMOTE flag is cleared.
-
- 24 Apr, 2013 4 commits
-
-
antirez authored
Sentinel redirected to the master if the instance changed runid or it was the first time we got INFO, and a role change was detected from master to slave. While this is a good idea in case of slave->master, since otherwise we could detect a failover without good reasons just after a reboot with a slave with a wrong configuration, in the case of master->slave transition is much better to always perform the redirection for the following reasons: 1) A Sentinel may go down for some time. When it is back online there is no other way to understand there was a failover. 2) Pointing clients to a slave seems to be always the wrong thing to do. 3) There is no good rationale about handling things differently once an instance is rebooted (runid change) in that case.
-
antirez authored
-
antirez authored
This prevents the kernel from putting too much stuff in the output buffers, doing too heavy I/O all at once. So the goal of this commit is to split the disk pressure due to the AOF rewrite process into smaller spikes. Please see issue #1019 for more information.
-
antirez authored
-
- 23 Apr, 2013 1 commit
-
-
antirez authored
When the test is executed using the root account, setting the permission to 222 does not work as expected, as root can read files with 222 permission. Now we skip the test if root is detected. This fixes issue #1034 and the duplicated #1040 issue. Thanks to Jan-Erik Rediger (@badboy on Github) for finding a way to reproduce the issue.
-
- 22 Apr, 2013 1 commit
-
-
antirez authored
-
- 19 Apr, 2013 3 commits
- 18 Apr, 2013 1 commit
-
-
antirez authored
Redis gitignore was too aggressive since simply broken. Jemalloc gitignore was too agressive because it is conceived to just keep the files that allow to generate all the rest in development environments (so for instance the "configure" file is excluded).
-
- 11 Apr, 2013 2 commits
-
-
antirez authored
Previously redis-cli never tried to raise an error when an unrecognized switch was encountered, as everything after the initial options is to be transmitted to the server. However this is too liberal, as there are no commands starting with "-". So the new behavior is to produce an error if there is an unrecognized switch starting with "-". This should not break past redis-cli usages but should prevent broken options to be silently discarded. As far the first token not starting with "-" is encountered, all the rest is considered to be part of the command, so you cna still use strings starting with "-" as values, like in: redis-cli --port 6380 set foo --my-value
-
antirez authored
-
- 09 Apr, 2013 4 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
We used to copy this value into the server.cluster structure, however this was not necessary. The reason why we don't directly use server.cluster->node_timeout is that things that can be configured via redis.conf need to be directly available in the server structure as server.cluster is allocated later only if needed in order to reduce the memory footprint of non-cluster instances.
-
antirez authored
-
- 08 Apr, 2013 1 commit
-
-
antirez authored
In commit d728ec6d it was introduced the concept of sending a ping to every node not receiving a ping since node_timeout/2 seconds. However the code was located in a place that was not executed because of a previous conditional causing the loop to re-iterate. This caused false positives in nodes availability detection. The current code is still not perfect as a node may be detected to be in PFAIL state even if it does not reply for just node_timeout/2 seconds that is not correct. There is a plan to improve this code ASAP.
-
- 04 Apr, 2013 3 commits