1. 08 Jan, 2016 1 commit
    • antirez's avatar
      Lua debugger: fix crash printing nested or deep objects. · a75aa4bf
      antirez authored
      Example of offending code:
      
      > script debug yes
      OK
      > eval "local a = {1} a[1] = a\nprint(a)" 0
      1) * Stopped at 1, stop reason = step over
      2) -> 1   local a = {1} a[1] = a
      > next
      1) * Stopped at 2, stop reason = step over
      2) -> 2   print(a)
      > print
      
      ... server crash ...
      
      Close #2955.
      a75aa4bf
  2. 07 Jan, 2016 3 commits
    • antirez's avatar
      Another typo in protected mode error message. · 1e7a8f82
      antirez authored
      1e7a8f82
    • antirez's avatar
      Fix protected mode error message typo. · 08c7bba3
      antirez authored
      08c7bba3
    • antirez's avatar
      New security feature: Redis protected mode. · edd4d555
      antirez authored
      An exposed Redis instance on the internet can be cause of serious
      issues. Since Redis, by default, binds to all the interfaces, it is easy
      to forget an instance without any protection layer, for error.
      
      Protected mode try to address this feature in a soft way, providing a
      layer of protection, but giving clues to Redis users about why the
      server is not accepting connections.
      
      When protected mode is enabeld (the default), and if there are no
      minumum hints about the fact the server is properly configured (no
      "bind" directive is used in order to restrict the server to certain
      interfaces, nor a password is set), clients connecting from external
      intefaces are refused with an error explaining what to do in order to
      fix the issue.
      
      Clients connecting from the IPv4 and IPv6 lookback interfaces are still
      accepted normally, similarly Unix domain socket connections are not
      restricted in any way.
      edd4d555
  3. 06 Jan, 2016 1 commit
    • antirez's avatar
      Cluster: don't send -ASK to MIGRATE. · 00d637f2
      antirez authored
      For non existing keys, we don't want to send -ASK redirections to
      MIGRATE, since when moving slots from the migrating node to the
      importing node, we want just to ignore keys that are no longer there.
      They may be expired or deleted between the GETKEYSINSLOT call and the
      MIGRATE call. Otherwise this causes an error during migrations with
      redis-trib (or equivalent cluster management tools).
      00d637f2
  4. 02 Jan, 2016 1 commit
  5. 18 Dec, 2015 2 commits
  6. 17 Dec, 2015 2 commits
    • antirez's avatar
      Fix a race that may lead to the active (slave) client to be freed. · bb215375
      antirez authored
      In issue #2948 a crash was reported in processCommand(). Later Oran Agra
      (@oranagra) traced the bug (in private chat) in the following sequence
      of events:
      
      1. Some maxmemory is set.
      2. The slave is the currently active client and is executing PING or
         REPLCONF or whatever a slave can send to its master.
      3. freeMemoryIfNeeded() is called since maxmemory is set.
      4. flushSlavesOutputBuffers() is called by freeMemoryIfNeeded().
      5. During slaves buffers flush, a write error could be encoutered in
         writeToClient() or sendReplyToClient() depending on the version of
         Redis. This will trigger freeClient() against the currently active
         client, so a segmentation fault will likely happen in
         processCommand() immediately after the call to freeMemoryIfNeeded().
      
      There are different possible fixes:
      
      1. Add flags to writeToClient() (recent versions code base) so that
         we can ignore the write errors, and use this flag in
         flushSlavesOutputBuffers(). However this is not simple to do in older
         versions of Redis.
      2. Use freeClientAsync() during write errors. This works but changes the
         current behavior of releasing clients ASAP when possible. Normally
         we write to clients during the normal event loop processing, in the
         writable client, where there is no active client, so no care must be
         taken.
      3. The fix of this commit: to detect that the current client is no
         longer valid. This fix is a bit "ad-hoc", but works across all the
         versions and has the advantage of not changing the remaining
         behavior. Only alters what happens during this race condition,
         hopefully.
      bb215375
    • antirez's avatar
      Fix processCommand() comment about return value. · 218e522c
      antirez authored
      218e522c
  7. 16 Dec, 2015 6 commits
  8. 15 Dec, 2015 4 commits
  9. 14 Dec, 2015 1 commit
  10. 11 Dec, 2015 8 commits
  11. 10 Dec, 2015 1 commit
  12. 09 Dec, 2015 2 commits
    • antirez's avatar
      69897f5f
    • antirez's avatar
      Fix replicas migration by adding a new flag. · e0f22df9
      antirez authored
      Some time ago I broken replicas migration (reported in #2924).
      The idea was to prevent masters without replicas from getting replicas
      because of replica migration, I remember it to create issues with tests,
      but there is no clue in the commit message about why it was so
      undesirable.
      
      However my patch as a side effect totally ruined the concept of replicas
      migration since we want it to work also for instances that, technically,
      never had slaves in the past: promoted slaves.
      
      So now instead the ability to be targeted by replicas migration, is a
      new flag "migrate-to". It only applies to masters, and is set in the
      following two cases:
      
      1. When a master gets a slave, it is set.
      2. When a slave turns into a master because of fail over, it is set.
      
      This way replicas migration targets are only masters that used to have
      slaves, and slaves of masters (that used to have slaves... obviously)
      and are promoted.
      
      The new flag is only internal, and is never exposed in the output nor
      persisted in the nodes configuration, since all the information to
      handle it are implicit in the cluster configuration we already have.
      e0f22df9
  13. 03 Dec, 2015 1 commit
    • antirez's avatar
      Centralize slave replication handshake aborting. · acc2336f
      antirez authored
      Now we have a single function to call in any state of the slave
      handshake, instead of using different functions for different states
      which is error prone. Change performed in the context of issue #2479 but
      does not fix it, since should be functionally identical to the past.
      Just an attempt to make replication.c simpler to follow.
      acc2336f
  14. 28 Nov, 2015 1 commit
    • antirez's avatar
      fix sprintf and snprintf format string · 96628cc4
      antirez authored
      There are some cases of printing unsigned integer with %d conversion
      specificator and vice versa (signed integer with %u specificator).
      
      Patch by Sergey Polovko. Backported to Redis from Disque.
      96628cc4
  15. 27 Nov, 2015 4 commits
  16. 18 Nov, 2015 1 commit
  17. 17 Nov, 2015 1 commit