1. 27 May, 2013 3 commits
  2. 15 May, 2013 1 commit
    • antirez's avatar
      Added a define for most configuration defaults. · 310dbba0
      antirez authored
      Also the logfile option was modified to always have an explicit value
      and to log to stdout when an empty string is used as log file.
      
      Previously there was special handling of the string "stdout" that set
      the logfile to NULL, this always required some special handling.
      310dbba0
  3. 13 May, 2013 2 commits
  4. 09 May, 2013 1 commit
  5. 08 May, 2013 1 commit
    • antirez's avatar
      Revert "use long long instead of size_t make it more safe" · 0ae1b5b0
      antirez authored
      This reverts commit 2c75f2cf.
      
      After further analysis, it is very unlikely that we'll raise the
      string size limit to > 512MB, and at the same time such big strings
      will be used in 32 bit systems.
      
      Better to revert to size_t so that 32 bit processors will not be
      forced to use a 64 bit counter in normal operations, that is currently
      completely useless.
      0ae1b5b0
  6. 07 May, 2013 2 commits
  7. 03 May, 2013 1 commit
    • antirez's avatar
      Cluster: link reconnection on delayed PONG reply. · 5c9f6d4f
      antirez authored
      When the PONG delay is half the cluster node timeout, the link gets
      disconnected (and later automatically reconnected) in order to ensure
      that it's not just a dead connection issue.
      
      However this operation is only performed if the link is old enough, in
      order to avoid to disconnect the same link again and again (and among
      the other problems, never receive the PONG because of that).
      
      Note: when the link is reconnected, the 'ping_sent' field is not updated
      even if a new ping is sent using the new connection, so we can still
      reliably detect a node ping timeout.
      5c9f6d4f
  8. 24 Apr, 2013 2 commits
  9. 09 Apr, 2013 2 commits
    • antirez's avatar
      Cluster: use server.cluster_node_timeout directly. · 68cf249f
      antirez authored
      We used to copy this value into the server.cluster structure, however this
      was not necessary.
      
      The reason why we don't directly use server.cluster->node_timeout is
      that things that can be configured via redis.conf need to be directly
      available in the server structure as server.cluster is allocated later
      only if needed in order to reduce the memory footprint of non-cluster
      instances.
      68cf249f
    • antirez's avatar
      ef4f25ff
  10. 04 Apr, 2013 3 commits
  11. 02 Apr, 2013 1 commit
    • antirez's avatar
      Throttle BGSAVE attempt on saving error. · b237de33
      antirez authored
      When a BGSAVE fails, Redis used to flood itself trying to BGSAVE at
      every next cron call, that is either 10 or 100 times per second
      depending on configuration and server version.
      
      This commit does not allow a new automatic BGSAVE attempt to be
      performed before a few seconds delay (currently 5).
      
      This avoids both the auto-flood problem and filling the disk with
      logs at a serious rate.
      
      The five seconds limit, considering a log entry of 200 bytes, will use
      less than 4 MB of disk space per day that is reasonable, the sysadmin
      should notice before of catastrofic events especially since by default
      Redis will stop serving write queries after the first failed BGSAVE.
      
      This fixes issue #849
      b237de33
  12. 27 Mar, 2013 1 commit
    • antirez's avatar
      DEBUG set-active-expire added. · 32a83c82
      antirez authored
      We need the ability to disable the activeExpireCycle() (active
      expired key collection) call for testing purposes.
      32a83c82
  13. 20 Mar, 2013 2 commits
    • antirez's avatar
      Cluster: new flag PROMOTED introduced. · 506f9a42
      antirez authored
      A slave node set this flag for itself when, after receiving authorization
      from the majority of nodes, it turns itself into a master.
      
      At the same time now this flag is tested by nodes receiving a PING
      message before reconfiguring after a failover event. This makes the
      system more robust: even if currently there is no way to manually turn
      a slave into a master it is possible that we'll have such a feature in
      the future, or that simply because of misconfiguration a node joins the
      cluster as master while others believe it's a slave. This alone is now
      no longer enough to trigger reconfiguration as other nodes will check
      for the PROMOTED flag.
      
      The PROMOTED flag is cleared every time the node is turned back into a
      replica of some other node.
      506f9a42
    • antirez's avatar
      Cluster: add sender flags in cluster bus messages header. · 026b9483
      antirez authored
      Sender flags were not propagated for the sender, but only for nodes in
      the gossip section. This is odd and in the next commits we'll need to
      get updated flags for the sender node, so this commit adds a new field
      in the cluster messages header.
      
      The message header is the same size as we reused some free space that
      was marked as 'unused' because of alignment concerns.
      026b9483
  14. 15 Mar, 2013 1 commit
    • antirez's avatar
      Cluster: slaves start failover with a small delay. · 1375b061
      antirez authored
      Redis Cluster can cope with a minority of nodes not informed about the
      failure of a master in time for some reason (netsplit or node not
      functioning properly, blocked, ...) however to wait a few seconds before
      to start the failover will make most "normal" failovers simpler as the
      FAIL message will propagate before the slave election happens.
      1375b061
  15. 14 Mar, 2013 1 commit
  16. 13 Mar, 2013 2 commits
  17. 09 Mar, 2013 1 commit
  18. 08 Mar, 2013 1 commit
  19. 06 Mar, 2013 2 commits
    • antirez's avatar
      Cluster: clusterUpdateState() function simplified. · 3dad8196
      antirez authored
      Also the NEEDHELP Cluster state was removed as it will no longer be
      used by Redis Cluster.
      3dad8196
    • antirez's avatar
      API to lookup commands with their original name. · 7b190a08
      antirez authored
      A new server.orig_commands table was added to the server structure, this
      contains a copy of the commant table unaffected by rename-command
      statements in redis.conf.
      
      A new API lookupCommandOrOriginal() was added that checks both tables,
      new first, old later, so that rewriteClientCommandVector() and friends
      can lookup commands with their new or original name in order to fix the
      client->cmd pointer when the argument vector is renamed.
      
      This fixes the segfault of issue #986, but does not fix a wider range of
      problems resulting from renaming commands that actually operate on data
      and are registered into the AOF file or propagated to slaves... That is
      command renaming should be handled with care.
      7b190a08
  20. 05 Mar, 2013 1 commit
    • antirez's avatar
      Cluster: new node field fail_time. · 1a02b744
      antirez authored
      This is the unix time at which we set the FAIL flag for the node.
      It is only valid if FAIL is set.
      
      The idea is to use it in order to make the cluster more robust, for
      instance in order to revert a FAIL state if it is long-standing but
      still slots are assigned to this node, that is, no one is going to fix
      these slots apparently.
      1a02b744
  21. 04 Mar, 2013 1 commit
  22. 28 Feb, 2013 1 commit
    • antirez's avatar
      Cluster: new field in cluster node structure, "numslots". · 4521115b
      antirez authored
      Before a relatively slow popcount() operation was needed every time we
      needed to get the number of slots served by a given cluster node.
      Now we just need to check an integer that is taken in sync with the
      bitmap.
      4521115b
  23. 27 Feb, 2013 1 commit
  24. 26 Feb, 2013 1 commit
    • antirez's avatar
      Set process name in ps output to make operations safer. · 6356cf68
      antirez authored
      This commit allows Redis to set a process name that includes the binding
      address and the port number in order to make operations simpler.
      
      Redis children processes doing AOF rewrites or RDB saving change the
      name into redis-aof-rewrite and redis-rdb-bgsave respectively.
      
      This in general makes harder to kill the wrong process because of an
      error and makes simpler to identify saving children.
      
      This feature was suggested by Arnaud GRANAL in the Redis Google Group,
      Arnaud also pointed me to the setproctitle.c implementation includeed in
      this commit.
      
      This feature should work on all the Linux, OSX, and all the three major
      BSD systems.
      6356cf68
  25. 25 Feb, 2013 4 commits
  26. 22 Feb, 2013 1 commit