1. 05 Aug, 2015 6 commits
    • antirez's avatar
      Test: csvdump now scans all DBs. · a89326f0
      antirez authored
      a89326f0
    • antirez's avatar
      b2ff48ef
    • antirez's avatar
      PSYNC test: also test the vanilla SYNC. · 7967f1bc
      antirez authored
      7967f1bc
    • antirez's avatar
      syncCommand() comments improved. · e684e726
      antirez authored
      e684e726
    • antirez's avatar
      PSYNC initial offset fix. · 4b010572
      antirez authored
      This commit attempts to fix a bug involving PSYNC and diskless
      replication (currently experimental) found by Yuval Inbar from Redis Labs
      and that was later found to have even more far reaching effects (the bug also
      exists when diskstore is off).
      
      The gist of the bug is that, a Redis master replies with +FULLRESYNC to
      a PSYNC attempt that fails and requires a full resynchronization.
      However, the baseline offset sent along with FULLRESYNC was always the
      current master replication offset. This is not ok, because there are
      many reasosn that may delay the RDB file creation. And... guess what,
      the master offset we communicate must be the one of the time the RDB
      was created. So for example:
      
      1) When the BGSAVE for replication is delayed since there is one
         already but is not good for replication.
      2) When the BGSAVE is not needed as we attach one currently ongoing.
      3) When because of diskless replication the BGSAVE is delayed.
      
      In all the above cases the PSYNC reply is wrong and the slave may
      reconnect later claiming to need a wrong offset: this may cause
      data curruption later.
      4b010572
    • antirez's avatar
      Test PSYNC with diskless replication. · dc4d2444
      antirez authored
      Thanks to Oran Agra from Redis Labs for providing this patch.
      dc4d2444
  2. 17 Jul, 2015 2 commits
  3. 16 Jul, 2015 1 commit
  4. 13 Jul, 2015 1 commit
  5. 04 Jun, 2015 2 commits
  6. 03 Jun, 2015 3 commits
  7. 25 May, 2015 1 commit
    • therealbill's avatar
      adding a sentinel command: "flushconfig" · 22ee2f9c
      therealbill authored
      This new command triggers a config flush to save the in-memory config to
      disk. This is useful for cases of a configuration management system or a
      package manager wiping out your sentinel config while the process is
      still running - and has not yet been restarted. It can also be useful
      for scripting a backup and migrate or clone of a running sentinel.
      22ee2f9c
  8. 19 May, 2015 2 commits
  9. 15 May, 2015 3 commits
  10. 05 May, 2015 2 commits
  11. 04 May, 2015 8 commits
    • FuGangqiang's avatar
      sdsfree x and y · 8db39699
      FuGangqiang authored
      8db39699
    • FuGangqiang's avatar
      fix doc example · 98756d4c
      FuGangqiang authored
      98756d4c
    • FuGangqiang's avatar
      fix typo · 7316fda3
      FuGangqiang authored
      7316fda3
    • Itamar Haber's avatar
      update copyright year · a5bada19
      Itamar Haber authored
      a5bada19
    • therealbill's avatar
      Making sentinel flush config on +slave · f0ab4fd6
      therealbill authored
      Originally, only the +slave event which occurs when a slave is
      reconfigured during sentinelResetMasterAndChangeAddress triggers a flush
      of the config to disk.  However, newly discovered slaves don't
      apparently trigger this flush but do trigger the +slave event issuance.
      
      So if you start up a sentinel, add a master, then add a slave to the
      master (as a way to reproduce it) you'll see the +slave event issued,
      but the sentinel config won't be updated with the known-slave entry.
      
      This change makes sentinel do the flush of the config if a new slave is
      deteted in sentinelRefreshInstanceInfo.
      f0ab4fd6
    • antirez's avatar
      Sentinel: remove useless sentinelFlushConfig() call · e4c54498
      antirez authored
      To rewrite the config in the loop that adds slaves back after a master
      reset, in order to handle switching to another master, is useless: it
      just adds latency since there is an fsync call in the inner loop,
      without providing any additional guarantee, but the contrary, since if
      after the first loop iteration the server crashes we end with just a
      single slave entry losing all the other informations.
      
      It is wiser to rewrite the config at the end when the full new
      state is configured.
      e4c54498
    • Yossi Gottlieb's avatar
    • clark.kang's avatar
      fix sentinel memory leak · c4d4c1ed
      clark.kang authored
      c4d4c1ed
  12. 28 Apr, 2015 1 commit
    • antirez's avatar
      Fix Sentinel memory leak (hiredis bug) · 081a0c94
      antirez authored
      This fixes issue #2535, that was actually an hiredis library bug (I
      submitted an issue and fix to the redis/hiredis repo as well).
      
      When an asynchronous hiredis connection subscribes to a Pub/Sub channel
      and gets an error, and in other related conditions, the function
      redisProcessCallbacks() enters a code path where the link is
      disconnected, however the function returns before freeing the allocated
      reply object. This causes a memory leak. The memory leak was trivial to
      trigger in Redis Sentinel, which uses hiredis, every time we tried to
      subscribe to an instance that required a password, in case the Sentinel
      was configured either with the wrong password or without password at
      all. In this case, the -AUTH error caused the leaking code path to be
      executed.
      
      It was verified with Valgrind that after this change the leak no longer
      happens in Sentinel with a misconfigured authentication password.
      081a0c94
  13. 27 Apr, 2015 1 commit
  14. 01 Apr, 2015 1 commit
    • Oran Agra's avatar
      fixes to diskless replication. · c72253ec
      Oran Agra authored
      master was closing the connection if the RDB transfer took long time.
      and also sent PINGs to the slave before it got the initial ACK, in which case the slave wouldn't be able to find the EOF marker.
      c72253ec
  15. 27 Mar, 2015 1 commit
  16. 24 Mar, 2015 1 commit
    • antirez's avatar
      Replication: disconnect blocked clients when switching to slave role. · 96aa6106
      antirez authored
      Bug as old as Redis and blocking operations. It's hard to trigger since
      only happens on instance role switch, but the results are quite bad
      since an inconsistency between master and slave is created.
      
      How to trigger the bug is a good description of the bug itself.
      
      1. Client does "BLPOP mylist 0" in master.
      2. Master is turned into slave, that replicates from New-Master.
      3. Client does "LPUSH mylist foo" in New-Master.
      4. New-Master propagates write to slave.
      5. Slave receives the LPUSH, the blocked client get served.
      
      Now Master "mylist" key has "foo", Slave "mylist" key is empty.
      
      Highlights:
      
      * At step "2" above, the client remains attached, basically escaping any
        check performed during command dispatch: read only slave, in that case.
      * At step "5" the slave (that was the master), serves the blocked client
        consuming a list element, which is not consumed on the master side.
      
      This scenario is technically likely to happen during failovers, however
      since Redis Sentinel already disconnects clients using the CLIENT
      command when changing the role of the instance, the bug is avoided in
      Sentinel deployments.
      
      Closes #2473.
      96aa6106
  17. 08 Mar, 2015 1 commit
  18. 04 Mar, 2015 1 commit
    • antirez's avatar
      Fix iterator for issue #2438. · f8f40afd
      antirez authored
      Itereator misuse due to analyzeLatencyForEvent() accessing the
      dictionary during the iteration, without the iterator being
      reclared as safe.
      f8f40afd
  19. 10 Feb, 2015 2 commits