1. 25 Nov, 2014 1 commit
    • antirez's avatar
      Avoid valgrind memory leak false positive in processInlineBuffer(). · a8f9a989
      antirez authored
      zmalloc(0) cauesd to actually trigger a non-zero allocation since with
      standard libc malloc we have our own zmalloc header for memory tracking,
      but at the same time the returned pointer is at the end of the block and
      not in the middle. This triggers a false positive when testing with
      valgrind.
      
      When the inline protocol args count is 0, we now avoid reallocating
      c->argv, preventing the issue to happen.
      a8f9a989
  2. 24 Nov, 2014 1 commit
  3. 14 Nov, 2014 10 commits
  4. 12 Nov, 2014 3 commits
  5. 11 Nov, 2014 2 commits
    • antirez's avatar
      Diskless SYNC: fix RDB EOF detection. · bb7fea0d
      antirez authored
      RDB EOF detection was relying on the final part of the RDB transfer to
      be a magic 40 bytes EOF marker. However as the slave is put online
      immediately, and because of sockets timeouts, the replication stream is
      actually contiguous with the RDB file.
      
      This means that to detect the EOF correctly we should either:
      
      1) Scan all the stream searching for the mark. Sucks CPU-wise.
      2) Start to send the replication stream only after an acknowledge.
      3) Implement a proper chunked encoding.
      
      For now solution "2" was picked, so the master does not start to send
      ASAP the stream of commands in the case of diskless replication. We wait
      for the first REPLCONF ACK command from the slave, that certifies us
      that the slave correctly loaded the RDB file and is ready to get more
      data.
      bb7fea0d
    • antirez's avatar
  6. 31 Oct, 2014 2 commits
  7. 30 Oct, 2014 1 commit
  8. 29 Oct, 2014 6 commits
  9. 27 Oct, 2014 6 commits
  10. 24 Oct, 2014 3 commits
  11. 23 Oct, 2014 1 commit
  12. 22 Oct, 2014 3 commits
  13. 17 Oct, 2014 1 commit