1. 17 Dec, 2014 7 commits
  2. 16 Dec, 2014 1 commit
  3. 15 Dec, 2014 1 commit
  4. 13 Dec, 2014 3 commits
  5. 12 Dec, 2014 5 commits
  6. 11 Dec, 2014 17 commits
  7. 10 Dec, 2014 6 commits
    • Pierre-Yves Ritschard's avatar
      b5686c1a
    • antirez's avatar
      Better read-only behavior for expired keys in slaves. · 06e76bc3
      antirez authored
      Slaves key expire is orchestrated by the master. Sometimes the master
      will send the synthesized DEL to expire keys on the slave with a non
      trivial delay (when the key is not accessed, only the incremental expiry
      algorithm will expire it in background).
      
      During that time, a key is logically expired, but slaves still return
      the key if you GET (or whatever) it. This is a bad behavior.
      
      However we can't simply trust the slave view of the key, since we need
      the master to be able to send write commands to update the slave data
      set, and DELs should only happen when the key is expired in the master
      in order to ensure consistency.
      
      However 99.99% of the issues with this behavior is when a client which
      is not a master sends a read only command. In this case we are safe and
      can consider the key as non existing.
      
      This commit does a few changes in order to make this sane:
      
      1. lookupKeyRead() is modified in order to return NULL if the above
      conditions are met.
      2. Calls to lookupKeyRead() in commands actually writing to the data set
      are repliaced with calls to lookupKeyWrite().
      
      There are redundand checks, so for example, if in "2" something was
      overlooked, we should be still safe, since anyway, when the master
      writes the behavior is to don't care about what expireIfneeded()
      returns.
      
      This commit is related to  #1768, #1770, #2131.
      06e76bc3
    • Salvatore Sanfilippo's avatar
      Merge pull request #2133 from chooper/histfile-override · 3da87b70
      Salvatore Sanfilippo authored
      override histfile from env - fixes #831 and copies #833
      3da87b70
    • antirez's avatar
      Sentinel: INFO-CACHE comments reworked a bit. · d8158771
      antirez authored
      Changed in order to make them more review friendly, based on the
      experience of reviewing the code myself.
      d8158771
    • antirez's avatar
      Sentinel: INFO-CACHE GCC minior code cleanup. · c83a9172
      antirez authored
      I guess the initial goal of the initialization was to suppress GCC
      warning, but if we have to initialize, we can do it with the base-case
      value instead of NULL which is never retained.
      c83a9172
    • antirez's avatar
      04223216