1. 11 Mar, 2013 1 commit
    • antirez's avatar
      serverCron() frequency is now a runtime parameter (was REDIS_HZ). · aec5ea5d
      antirez authored
      REDIS_HZ is the frequency our serverCron() function is called with.
      A more frequent call to this function results into less latency when the
      server is trying to handle very expansive background operations like
      mass expires of a lot of keys at the same time.
      
      Redis 2.4 used to have an HZ of 10. This was good enough with almost
      every setup, but the incremental key expiration algorithm was working a
      bit better under *extreme* pressure when HZ was set to 100 for Redis
      2.6.
      
      However for most users a latency spike of 30 milliseconds when million
      of keys are expiring at the same time is acceptable, on the other hand a
      default HZ of 100 in Redis 2.6 was causing idle instances to use some
      CPU time compared to Redis 2.4. The CPU usage was in the order of 0.3%
      for an idle instance, however this is a shame as more energy is consumed
      by the server, if not important resources.
      
      This commit introduces HZ as a runtime parameter, that can be queried by
      INFO or CONFIG GET, and can be modified with CONFIG SET. At the same
      time the default frequency is set back to 10.
      
      In this way we default to a sane value of 10, but allows users to
      easily switch to values up to 500 for near real-time applications if
      needed and if they are willing to pay this small CPU usage penalty.
      aec5ea5d
  2. 06 Mar, 2013 10 commits
  3. 04 Mar, 2013 3 commits
  4. 12 Feb, 2013 1 commit
  5. 11 Feb, 2013 7 commits
  6. 08 Feb, 2013 1 commit
  7. 07 Feb, 2013 1 commit
  8. 05 Feb, 2013 3 commits
    • antirez's avatar
      cf0191dc
    • charsyam's avatar
      Turn off TCP_NODELAY on the slave socket after SYNC. · 45b1b2f7
      charsyam authored
      Further details from @antirez:
      
      It was reported by @StopForumSpam on Twitter that the Redis replication
      link was strangely using multiple TCP packets for multiple commands.
      This wastes a lot of bandwidth and is due to the TCP_NODELAY option we
      enable on the socket after accepting a new connection.
      
      However the master -> slave channel is a one-way channel since Redis
      replication is asynchronous, so there is no point in trying to reduce
      the latency, we should aim to reduce the bandwidth. For this reason this
      commit introduces the ability to disable the nagle algorithm on the
      socket after a successful SYNC.
      
      This feature is off by default because the delay can be up to 40
      milliseconds with normally configured Linux kernels.
      45b1b2f7
    • Rock Li's avatar
      retval doesn't initalized · 8c0b9f77
      Rock Li authored
      If each if conditions are all fail, variable retval will under uninitlized
      8c0b9f77
  9. 04 Feb, 2013 1 commit
    • Gengliang Wang's avatar
      Fix a bug in srandmemberWithCountCommand() · 9ddd0f77
      Gengliang Wang authored
      In CASE 2, the call sunionDiffGenericCommand will involve the string "srandmember"
      > sadd foo one
      (integer 1)
      > sadd srandmember two
      (integer 2)
      > srandmember foo 3
      1)"one"
      2)"two"
      9ddd0f77
  10. 21 Jan, 2013 4 commits
    • antirez's avatar
      bfad381f
    • antirez's avatar
      UNSUBSCRIBE and PUNSUBSCRIBE: always provide a reply. · 742e580f
      antirez authored
      UNSUBSCRIBE and PUNSUBSCRIBE commands are designed to mass-unsubscribe
      the client respectively all the channels and patters if called without
      arguments.
      
      However when these functions are called without arguments, but there are
      no channels or patters we are subscribed to, the old behavior was to
      don't reply at all.
      
      This behavior is broken, as every command should always reply.
      Also it is possible that we are no longer subscribed to a channels but we
      are subscribed to patters or the other way around, and the client should
      be notified with the correct number of subscriptions.
      
      Also it is not pretty that sometimes we did not receive a reply at all
      in a redis-cli session from these commands, blocking redis-cli trying
      to read the reply.
      
      This fixes issue #714.
      742e580f
    • antirez's avatar
      Fixed a bug in memtest progress bar, that had no actual effects. · 1b0f2445
      antirez authored
      This closes issue #859, thanks to @erbenmo.
      1b0f2445
    • antirez's avatar
      Not every __sun has backtrace(). · 580f65a5
      antirez authored
      I don't know how to test for Open Solaris that has support for
      backtrace() so for now removing the #ifdef that breaks compilation under
      other Solaris flavors.
      580f65a5
  11. 19 Jan, 2013 8 commits