1. 29 Nov, 2012 1 commit
    • antirez's avatar
      On crash memory test rewrote so that it actaully works. · b1b602a9
      antirez authored
      1) We no longer test location by location, otherwise the CPU write cache
      completely makes our business useless.
      2) We still need a memory test that operates in steps from the first to
      the last location in order to never hit the cache, but that is still
      able to retain the memory content.
      
      This was tested using a Linux box containing a bad memory module with a
      zingle bit error (always zero).
      
      So the final solution does has an error propagation step that is:
      
      1) Invert bits at every location.
      2) Swap adiacent locations.
      3) Swap adiacent locations again.
      4) Invert bits at every location.
      5) Swap adiacent locations.
      6) Swap adiacent locations again.
      
      Before and after these steps, and after step 4, a CRC64 checksum is computed.
      If the three CRC64 checksums don't match, a memory error was detected.
      b1b602a9
  2. 28 Nov, 2012 1 commit
  3. 22 Nov, 2012 2 commits
  4. 21 Nov, 2012 1 commit
  5. 08 Nov, 2012 1 commit
  6. 24 Aug, 2012 1 commit
    • antirez's avatar
      Better Out of Memory handling. · 6fdc6354
      antirez authored
      The previous implementation of zmalloc.c was not able to handle out of
      memory in an application-specific way. It just logged an error on
      standard error, and aborted.
      
      The result was that in the case of an actual out of memory in Redis
      where malloc returned NULL (In Linux this actually happens under
      specific overcommit policy settings and/or with no or little swap
      configured) the error was not properly logged in the Redis log.
      
      This commit fixes this problem, fixing issue #509.
      Now the out of memory is properly reported in the Redis log and a stack
      trace is generated.
      
      The approach used is to provide a configurable out of memory handler
      to zmalloc (otherwise the default one logging the event on the
      standard output is used).
      6fdc6354
  7. 11 Jun, 2012 1 commit
    • antirez's avatar
      Dump ziplist hex value on failed assertion. · ee789e15
      antirez authored
      The ziplist -> hashtable conversion code is triggered every time an hash
      value must be promoted to a full hash table because the number or size of
      elements reached the threshold.
      
      If a problem in the ziplist causes the same field to be present
      multiple times, the assertion of successful addition of the element
      inside the hash table will fail, crashing server with a failed
      assertion, but providing little information about the problem.
      
      This code adds a new logging function to perform the hex dump of binary
      data, and makes sure that the ziplist -> hashtable conversion code uses
      this new logging facility to dump the content of the ziplist when the
      assertion fails.
      
      This change was originally made in order to investigate issue #547.
      ee789e15
  8. 13 May, 2012 1 commit
    • antirez's avatar
      Impovements for: Redis timer, hashes rehashing, keys collection. · 61daf891
      antirez authored
      A previous commit introduced REDIS_HZ define that changes the frequency
      of calls to the serverCron() Redis function. This commit improves
      different related things:
      
      1) Software watchdog: now the minimal period can be set according to
      REDIS_HZ. The minimal period is two times the timer period, that is:
      
          (1000/REDIS_HZ)*2 milliseconds
      
      2) The incremental rehashing is now performed in the expires dictionary
      as well.
      
      3) The activeExpireCycle() function was improved in different ways:
      
      - Now it checks if it already used too much time using microseconds
        instead of milliseconds for better precision.
      - The time limit is now calculated correctly, in the previous version
        the division was performed before of the multiplication resulting in
        a timelimit of 0 if HZ was big enough.
      - Databases with less than 1% of buckets fill in the hash table are
        skipped, because getting random keys is too expensive in this
        condition.
      
      4) tryResizeHashTables() is now called at every timer call, we need to
         match the number of calls we do to the expired keys colleciton cycle.
      
      5) REDIS_HZ was raised to 100.
      61daf891
  9. 26 Apr, 2012 1 commit
  10. 24 Apr, 2012 1 commit
    • antirez's avatar
      Fix and refactoring of code used to get registers on crash. · a66a4963
      antirez authored
      This fixes compilation on FreeBSD (and possibly other systems) by
      not using ucontext_t at all if HAVE_BACKTRACE is not defined.
      Also the ifdefs to get the registers are modified to explicitly test for the
      operating system in the first level, and the arch in the second level
      of nesting.
      a66a4963
  11. 02 Apr, 2012 1 commit
  12. 28 Mar, 2012 1 commit
  13. 27 Mar, 2012 4 commits
  14. 18 Mar, 2012 1 commit
  15. 21 Feb, 2012 1 commit
  16. 08 Feb, 2012 1 commit
  17. 21 Jan, 2012 1 commit
  18. 20 Jan, 2012 4 commits
  19. 12 Jan, 2012 1 commit
  20. 21 Dec, 2011 2 commits
  21. 20 Dec, 2011 1 commit
  22. 24 Nov, 2011 1 commit
  23. 12 Nov, 2011 1 commit
  24. 08 Nov, 2011 1 commit
  25. 14 Oct, 2011 1 commit
  26. 04 Oct, 2011 2 commits
  27. 30 Jun, 2011 1 commit
  28. 25 Jun, 2011 1 commit
  29. 10 May, 2011 1 commit
  30. 06 Apr, 2011 1 commit
  31. 14 Mar, 2011 1 commit