- 06 Jul, 2016 5 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
Normally we used to update it from time to time. Too fragile... better to generate dependencies at every run and delete them on 'make clean'.
-
antirez authored
-
antirez authored
strict_strtoll() has a bug that reports the empty string as ok and parses it as zero. Apparently nobody ever replaced this old call with the faster/saner string2ll() which is used otherwise in the rest of the Redis core. This commit close #3333.
-
- 05 Jul, 2016 2 commits
-
-
antirez authored
In issues #3361 / #3365 a problem was reported / fixed with redis-cli not updating correctly the current DB on error after SELECT. In theory this bug was fixed in 0042fb0e, but actually the commit only fixed the prompt updating, not the fact the state was set in a wrong way. This commit removes the check in the prompt update, now that hopefully it is the state that is correct, there is no longer need for this check.
-
Salvatore Sanfilippo authored
Fix for redis_cli printing default DB when select command fails. #3361
-
- 04 Jul, 2016 4 commits
-
-
antirez authored
This commit both fixes the crash reported with issue #3364 and also properly closes the old links after the Sentinel address for the other masters gets updated. The two problems where: 1. The Sentinel that switched address may not monitor all the masters, it is possible that there is no match, and the 'match' variable is NULL. Now we check for no match and 'continue' to the next master. 2. By ispecting the code because of issue "1" I noticed that there was a problem in the code that disconnects the link of the Sentinel that needs the address update. Basically link->disconnected is non-zero even if just *a single link* (cc -- command link or pc -- pubsub link) are disconnected, so to check with if (link->disconnected) in order to close the links risks to leave one link connected. I was able to manually reproduce the crash at "1" and verify that the commit resolves the issue. Close #3364.
-
antirez authored
Like CONFIG SET always was. Close #3369.
-
antirez authored
-
antirez authored
We already changed the default in the redis.conf template, but I forgot to change the internal config as well.
-
- 01 Jul, 2016 7 commits
- 30 Jun, 2016 1 commit
-
-
antirez authored
So far we used an external program (later executed within Redis) and parser in order to check RDB files for correctness. This forces, at each RDB format update, to have two copies of the same format implementation that are hard to keep in sync. Morover the former RDB checker only checked the very high-level format of the file, without actually trying to load things in memory. Certain corruptions can only be handled by really loading key-value pairs. This first commit attempts to unify the Redis RDB loadig code with the task of checking the RDB file for correctness. More work is needed but it looks like a sounding direction so far.
-
- 28 Jun, 2016 3 commits
- 27 Jun, 2016 2 commits
-
-
antirez authored
-
antirez authored
The quicklist takes a cached version of the ziplist representation size in bytes. The implementation must update this length every time the underlying ziplist changes. However quicklistReplaceAtIndex() failed to fix the length. During LSET calls, the size of the ziplist blob and the cached size inside the quicklist diverged. Later, when this size is used in an authoritative way, for example during nodes splitting in order to copy the nodes, we end with a duplicated node that may contain random garbage. This commit should fix issue #3343, however several problems were found reviewing the quicklist.c code in search of this bug that should be addressed soon or later. For example: 1. To take a cached ziplist length is fragile since failing to update it leads to this kind of issues. 2. The node splitting code needs auditing. For example it works just for a side effect of ziplistDeleteRange() to be able to cope with a wrong count of elements to remove. The code inside quicklist.c assumes that -1 means "delete till the end" while actually it's just a count of how many elements to delete, and is an unsigned count. So -1 gets converted into the maximum integer, and just by chance the ziplist code stops deleting elements after there are no more to delete. 3. Node splitting is extremely inefficient, it copies the node and removes elements from both nodes even when actually there is to move a single entry from one node to the other, or when the new resulting node is empty at all so there is nothing to copy but just to create a new node. However at least for Redis 3.2 to introduce fresh code inside quicklist.c may be even more risky, so instead I'm writing a better fuzzy tester to stress the internals a bit more in order to anticipate other possible bugs. This bug was found using a fuzzy tester written after having some clue about where the bug could be. The tester eventually created a ~2000 commands sequence able to always crash Redis. I wrote a better version of the tester that searched for the smallest sequence that could crash Redis automatically. Later this smaller sequence was minimized by removing random commands till it still crashed the server. This resulted into a sequence of 7 commands. With this small sequence it was just a matter of filling the code with enough printf() to understand enough state to fix the bug.
-
- 24 Jun, 2016 1 commit
-
-
Salvatore Sanfilippo authored
Fix RedisModule_Calloc() definition typo.
-
- 23 Jun, 2016 15 commits
-
-
Yossi Gottlieb authored
-
Salvatore Sanfilippo authored
Fix incorrect comment for checkForSentinelMode function
-
antirez authored
-
Salvatore Sanfilippo authored
added RM_Calloc implementation
-
antirez authored
-
antirez authored
I forgot -a when amending in the previous commit.
-
Salvatore Sanfilippo authored
Add RedisModule_CreateStringFromString().
-
antirez authored
Also avoid "static" in order to have symbols during crashes.
-
Salvatore Sanfilippo authored
Fix occasional RM_OpenKey() crashes.
-
Salvatore Sanfilippo authored
A string with 21 chars is not representable as a 64-bit integer.
-
tielei authored
-
Salvatore Sanfilippo authored
Use const in Redis Module API where possible.
-
antirez authored
This commit changes what provided by PR #3315 (merged) in order to let the user specify the log level as a string. The define could be also used, but when this happens, they must be decoupled from the defines in the Redis core, like in the other part of the Redis modules implementations, so that a switch statement (or a function) remaps between the two, otherwise we are no longer free to change the internal Redis defines.
-
Yossi Gottlieb authored
-
antirez authored
It's more natural to call the last entry added as "last", the original commet got me confused until I actually read the code.
-