- 08 Dec, 2014 3 commits
-
-
Jan-Erik Rediger authored
This allows shell pipes to correctly end redis-cli. Ref #2066
-
Sun He authored
-
Sun He authored
-
- 05 Dec, 2014 1 commit
-
-
- 04 Dec, 2014 1 commit
-
-
antirez authored
-
- 03 Dec, 2014 3 commits
- 02 Dec, 2014 3 commits
-
-
antirez authored
Ref: issue #2175
-
antirez authored
-
antirez authored
PFCOUNT is technically speaking a write command, since the cached value of the HLL is exposed in the data structure (design error, mea culpa), and can be modified by PFCOUNT. However if we flag PFCOUNT as "w", read only slaves can't execute the command, which is a problem since there are environments where slaves are used to scale PFCOUNT reads. Nor it is possible to just prevent PFCOUNT to modify the data structure in slaves, since without the cache we lose too much efficiency. So while this commit allows slaves to create a temporary inconsistency (the strings representing the HLLs in the master and slave can be different in certain moments) it is actually harmless. In the long run this should be probably fixed by turning the HLL into a more opaque representation, for example by storing the cached value in the part of the string which is not exposed (this should be possible with SDS strings).
-
- 28 Nov, 2014 3 commits
-
-
antirez authored
bulk_data field size was not removed from the count. It is not possible to declare it simply as 'char bulk_data[]' since the structure is nested into another structure.
-
antirez authored
10000 completes in a too short time and may easily provide unreliable figures because of tiny duration.
-
Matthias Petschick authored
-
- 26 Nov, 2014 1 commit
-
-
antirez authored
Because of (not so) recent Redis changes, now the LRU internally reported unit is milliseconds, not seconds, but the DEBUG OBJECT output was still claiming seconds while providing milliseconds. However OBJECT IDLETIME was working as expected, which is the correct API to use.
-
- 25 Nov, 2014 2 commits
-
-
antirez authored
-
antirez authored
zmalloc(0) cauesd to actually trigger a non-zero allocation since with standard libc malloc we have our own zmalloc header for memory tracking, but at the same time the returned pointer is at the end of the block and not in the middle. This triggers a false positive when testing with valgrind. When the inline protocol args count is 0, we now avoid reallocating c->argv, preventing the issue to happen.
-
- 14 Nov, 2014 1 commit
-
-
antirez authored
-
- 12 Nov, 2014 3 commits
- 11 Nov, 2014 2 commits
-
-
antirez authored
RDB EOF detection was relying on the final part of the RDB transfer to be a magic 40 bytes EOF marker. However as the slave is put online immediately, and because of sockets timeouts, the replication stream is actually contiguous with the RDB file. This means that to detect the EOF correctly we should either: 1) Scan all the stream searching for the mark. Sucks CPU-wise. 2) Start to send the replication stream only after an acknowledge. 3) Implement a proper chunked encoding. For now solution "2" was picked, so the master does not start to send ASAP the stream of commands in the case of diskless replication. We wait for the first REPLCONF ACK command from the slave, that certifies us that the slave correctly loaded the RDB file and is ready to get more data.
-
antirez authored
-
- 29 Oct, 2014 5 commits
-
-
Matt Stancliff authored
Same as the original bind fixes (we just missed these the first time around). This helps Redis not automatically send connections from the first IP on an interface if we are bound to a specific IP address (e.g. with multiple IP aliases on one interface, you want to send from _your_ IP, not from the first IP on the interface).
-
Matt Stancliff authored
We need to pick the port based on the _last_ colon, not the first one.
-
Matt Stancliff authored
IP format is now any of: - 127.0.0.1:6379 - ::1:6379
-
Matt Stancliff authored
Closes #2066
-
antirez authored
This caused BGSAVE to be triggered a second time without any need when we switch from socket to disk target via the command CONFIG SET repl-diskless-sync no and there is already a slave waiting for the BGSAVE to start. Also comments clarified about what is happening.
-
- 27 Oct, 2014 5 commits
- 24 Oct, 2014 1 commit
-
-
antirez authored
-
- 23 Oct, 2014 1 commit
-
-
antirez authored
Child now reports full info to the parent including IDs of slaves in failure state and exit code.
-
- 22 Oct, 2014 3 commits
-
-
antirez authored
EWOULDBLOCK with the fdset rio target is returned when we try to write but the send timeout socket option triggered an error. Better to translate the error in something the user can actually recognize as a timeout.
-
antirez authored
We need to avoid that a child -> slaves transfer can continue forever. We use the same timeout used as global replication timeout, which is documented to also affect I/O operations during bulk transfers.
-
antirez authored
-
- 17 Oct, 2014 2 commits