1. 05 Feb, 2013 3 commits
    • antirez's avatar
      b70b459b
    • charsyam's avatar
      Turn off TCP_NODELAY on the slave socket after SYNC. · c85647f3
      charsyam authored
      Further details from @antirez:
      
      It was reported by @StopForumSpam on Twitter that the Redis replication
      link was strangely using multiple TCP packets for multiple commands.
      This wastes a lot of bandwidth and is due to the TCP_NODELAY option we
      enable on the socket after accepting a new connection.
      
      However the master -> slave channel is a one-way channel since Redis
      replication is asynchronous, so there is no point in trying to reduce
      the latency, we should aim to reduce the bandwidth. For this reason this
      commit introduces the ability to disable the nagle algorithm on the
      socket after a successful SYNC.
      
      This feature is off by default because the delay can be up to 40
      milliseconds with normally configured Linux kernels.
      c85647f3
    • Rock Li's avatar
      retval doesn't initalized · 8063155c
      Rock Li authored
      If each if conditions are all fail, variable retval will under uninitlized
      8063155c
  2. 04 Feb, 2013 1 commit
    • Gengliang Wang's avatar
      Fix a bug in srandmemberWithCountCommand() · 00274733
      Gengliang Wang authored
      In CASE 2, the call sunionDiffGenericCommand will involve the string "srandmember" 
      > sadd foo one
      (integer 1)
      > sadd srandmember two
      (integer 2)
      > srandmember foo 3
      1)"one"
      2)"two"
      00274733
  3. 31 Jan, 2013 1 commit
  4. 29 Jan, 2013 2 commits
  5. 28 Jan, 2013 12 commits
  6. 21 Jan, 2013 4 commits
    • antirez's avatar
      88015b89
    • antirez's avatar
      UNSUBSCRIBE and PUNSUBSCRIBE: always provide a reply. · 2039f1a3
      antirez authored
      UNSUBSCRIBE and PUNSUBSCRIBE commands are designed to mass-unsubscribe
      the client respectively all the channels and patters if called without
      arguments.
      
      However when these functions are called without arguments, but there are
      no channels or patters we are subscribed to, the old behavior was to
      don't reply at all.
      
      This behavior is broken, as every command should always reply.
      Also it is possible that we are no longer subscribed to a channels but we
      are subscribed to patters or the other way around, and the client should
      be notified with the correct number of subscriptions.
      
      Also it is not pretty that sometimes we did not receive a reply at all
      in a redis-cli session from these commands, blocking redis-cli trying
      to read the reply.
      
      This fixes issue #714.
      2039f1a3
    • antirez's avatar
      Fixed a bug in memtest progress bar, that had no actual effects. · 93f61bb2
      antirez authored
      This closes issue #859, thanks to @erbenmo.
      93f61bb2
    • antirez's avatar
      Not every __sun has backtrace(). · cd892d01
      antirez authored
      I don't know how to test for Open Solaris that has support for
      backtrace() so for now removing the #ifdef that breaks compilation under
      other Solaris flavors.
      cd892d01
  7. 19 Jan, 2013 6 commits
    • antirez's avatar
      Additionally two typos fixed thanks to @jodal · e50cdbe4
      antirez authored
      e50cdbe4
    • antirez's avatar
      Whitelist SIGUSR1 to avoid auto-triggering errors. · 79a0ef62
      antirez authored
      This commit fixes issue #875 that was caused by the following events:
      
      1) There is an active child doing BGSAVE.
      2) flushall is called (or any other condition that makes Redis killing
      the saving child process).
      3) An error is sensed by Redis as the child exited with an error (killed
      by a singal), that stops accepting write commands until a BGSAVE happens
      to be executed with success.
      
      Whitelisting SIGUSR1 and making sure Redis always uses this signal in
      order to kill its own children fixes the issue.
      79a0ef62
    • antirez's avatar
      Clear server.shutdown_asap on failed shutdown. · ab247fc1
      antirez authored
      When a SIGTERM is received Redis schedules a shutdown. However if it
      fails to perform the shutdown it must be clear the shutdown_asap flag
      otehrwise it will try again and again possibly making the server
      unusable.
      ab247fc1
    • antirez's avatar
      Slowlog: don't log EXEC but just the executed commands. · 08d200ba
      antirez authored
      The Redis Slow Log always used to log the slow commands executed inside
      a MULTI/EXEC block. However also EXEC was logged at the end, which is
      perfectly useless.
      
      Now EXEC is no longer logged and a test was added to test this behavior.
      
      This fixes issue #759.
      08d200ba
    • guiquanz's avatar
      Fixed many typos. · 9d09ce39
      guiquanz authored
      9d09ce39
    • bitterb's avatar
      Fix an error reply for CLIENT command · c2dc172a
      bitterb authored
      c2dc172a
  8. 18 Jan, 2013 2 commits
    • Jan-Erik Rediger's avatar
      Always exit if connection fails. · 59046a73
      Jan-Erik Rediger authored
      This avoids unnecessary core dumps. Fixes antirez/redis#894
      59046a73
    • Nathan Parry's avatar
      redis-cli --rdb fails if server sends a ping · 1920cab3
      Nathan Parry authored
      Redis pings slaves in "pre-synchronization stage" with newlines. (See
      https://github.com/antirez/redis/blob/2.6.9/src/replication.c#L814)
      However, redis-cli does not expect this - it sees the newline as the end
      of the bulk length line, and ends up returning 0 as bulk the length.
      This manifests as the following when running redis-cli:
      
          $ ./src/redis-cli --rdb some_file
          SYNC sent to master, writing 0 bytes to 'some_file'
          Transfer finished with success.
      
      With this commit, we just ignore leading newlines while reading the bulk
      length line.
      
      To reproduce the problem, load enough data into Redis so that the
      preparation of the RDB snapshot takes long enough for a ping to occur
      while redis-cli is waiting for the data.
      1920cab3
  9. 17 Jan, 2013 1 commit
  10. 16 Jan, 2013 2 commits
  11. 15 Jan, 2013 3 commits
    • antirez's avatar
      Typo fixed, ASCI -> ASCII. · 9b89ab06
      antirez authored
      9b89ab06
    • antirez's avatar
      CLIENT GETNAME and CLIENT SETNAME introduced. · 1971740f
      antirez authored
      Sometimes it is much simpler to debug complex Redis installations if it
      is possible to assign clients a name that is displayed in the CLIENT
      LIST output.
      
      This is the case, for example, for "leaked" connections. The ability to
      provide a name to the client makes it quite trivial to understand what
      is the part of the code implementing the client not releasing the
      resources appropriately.
      
      Behavior:
      
          CLIENT SETNAME: set a name for the client, or remove the current
                          name if an empty name is set.
          CLIENT GETNAME: get the current name, or a nil.
          CLIENT LIST: now displays the client name if any.
      
      Thanks to Mark Gravell for pushing this idea forward.
      1971740f
    • antirez's avatar
      Undo slave-master handshake when SLAVEOF sets a new slave. · ef99e146
      antirez authored
      Issue #828 shows how Redis was not correctly undoing a non-blocking
      connection attempt with the previous master when the master was set to a
      new address using the SLAVEOF command.
      
      This was also a result of lack of refactoring, so now there is a
      function to cancel the non blocking handshake with the master.
      The new function is now used when SLAVEOF NO ONE is called or when
      SLAVEOF is used to set the master to a different address.
      ef99e146
  12. 11 Jan, 2013 1 commit
  13. 10 Jan, 2013 2 commits