1. 11 Jun, 2014 1 commit
    • Matt Stancliff's avatar
      Scripting: Fix regression from #1118 · ba76daa4
      Matt Stancliff authored
      The new check-for-number behavior of Lua arguments broke
      users who use large strings of just integers.
      
      The Lua number check would convert the string to a number, but
      that breaks user data because
      Lua numbers have limited precision compared to an arbitrarily
      precise number wrapped in a string.
      
      Regression fixed and new test added.
      
      Fixes #1118 again.
      ba76daa4
  2. 09 Jun, 2014 3 commits
    • Matt Stancliff's avatar
      Fix lack of strtold under Cygwin · 8f774ee7
      Matt Stancliff authored
      Renaming strtold to strtod then casting
      the result is the standard way of dealing with
      no strtold in Cygwin.
      8f774ee7
    • Matt Stancliff's avatar
      Fix lack of SA_ONSTACK under Cygwin · 2af24143
      Matt Stancliff authored
      Fixes #232
      2af24143
    • Matt Stancliff's avatar
      Fix blocking operations from missing new lists · b4f9761d
      Matt Stancliff authored
      Behrad Zari discovered [1] and Josiah reported [2]: if you block
      and wait for a list to exist, but the list creates from
      a non-push command, the blocked client never gets notified.
      
      This commit adds notification of blocked clients into
      the DB layer and away from individual commands.
      
      Lists can be created by [LR]PUSH, SORT..STORE, RENAME, MOVE,
      and RESTORE.  Previously, blocked client notifications were
      only triggered by [LR]PUSH.  Your client would never get
      notified if a list were created by SORT..STORE or RENAME or
      a RESTORE, etc.
      
      Blocked client notification now happens in one unified place:
        - dbAdd() triggers notification when adding a list to the DB
      
      Two new tests are added that fail prior to this commit.
      
      All test pass.
      
      Fixes #1668
      
      [1]: https://groups.google.com/forum/#!topic/redis-db/k4oWfMkN1NU
      [2]: #1668
      b4f9761d
  3. 06 Jun, 2014 4 commits
  4. 05 Jun, 2014 3 commits
  5. 04 Jun, 2014 3 commits
    • antirez's avatar
      Fixed dbuf variable scope in luaRedisGenericCommand(). · 42504169
      antirez authored
      I'm not sure if while the visibility is the inner block, the fact we
      point to 'dbuf' is a problem or not, probably the stack var isx
      guaranteed to live until the function returns. However obvious code is
      better anyway.
      42504169
    • antirez's avatar
      Regression test for issue #1118. · 26359d57
      antirez authored
      26359d57
    • antirez's avatar
      Scripting: better Lua number -> string conversion in luaRedisGenericCommand(). · 768994b6
      antirez authored
      The lua_to*string() family of functions use a non optimal format
      specifier when converting integers to strings. This has both the problem
      of the number being converted in exponential notation, which we don't
      use as a Redis return value when floating point numbers are involed,
      and, moreover, there is a loss of precision since the default format
      specifier is not able to represent numbers that must be represented
      exactly in the IEEE 754 number mantissa.
      
      The new code handles it as a special case using a saner conversion.
      
      This fixes issue #1118.
      768994b6
  6. 28 May, 2014 1 commit
  7. 26 May, 2014 2 commits
  8. 22 May, 2014 4 commits
    • antirez's avatar
      Test: fixed scripting.tcl test false positive. · 1a14eba2
      antirez authored
      1a14eba2
    • antirez's avatar
      Process events with processEventsWhileBlocked() when blocked. · f4823497
      antirez authored
      When we are blocked and a few events a processed from time to time, it
      is smarter to call the event handler a few times in order to handle the
      accept, read, write, close cycle of a client in a single pass, otherwise
      there is too much latency added for clients to receive a reply while the
      server is busy in some way (for example during the DB loading).
      f4823497
    • antirez's avatar
      Accept multiple clients per iteration. · f3d3c606
      antirez authored
      When the listening sockets readable event is fired, we have the chance
      to accept multiple clients instead of accepting a single one. This makes
      Redis more responsive when there is a mass-connect event (for example
      after the server startup), and in workloads where a connect-disconnect
      pattern is used often, so that multiple clients are waiting to be
      accepted continuously.
      
      As a side effect, this commit makes the LOADING, BUSY, and similar
      errors much faster to deliver to the client, making Redis more
      responsive when there is to return errors to inform the clients that the
      server is blocked in an not interruptible operation.
      f3d3c606
    • antirez's avatar
      41134739
  9. 20 May, 2014 4 commits
  10. 19 May, 2014 2 commits
  11. 14 May, 2014 1 commit
  12. 12 May, 2014 3 commits
  13. 09 May, 2014 1 commit
  14. 08 May, 2014 2 commits
    • antirez's avatar
      Sentinel: log when a failover will be attempted again. · 13d8b2b0
      antirez authored
      When a Sentinel performs a failover (successful or not), or when a
      Sentinel votes for a different Sentinel trying to start a failover, it
      sets a min delay before it will try to get elected for a failover.
      
      While not strictly needed, because if multiple Sentinels will try
      to failover the same master at the same time, only one configuration
      will eventually win, this serialization is practically very useful.
      Normal failovers are cleaner: one Sentinel starts to failover, the
      others update their config when the Sentinel performing the failover
      is able to get the selected slave to move from the role of slave to the
      one of master.
      
      However currently this timeout was implicit, so users could see
      Sentinels not reacting, after a failed failover, for some time, without
      giving any feedback in the logs to the poor sysadmin waiting for clues.
      
      This commit makes Sentinels more verbose about the delay: when a master
      is down and a failover attempt is not performed because the delay has
      still not elaped, something like that will be logged:
      
          Next failover delay: I will not start a failover
          before Thu May  8 16:48:59 2014
      13d8b2b0
    • antirez's avatar
      Sentinel: generate +config-update-from event when a new config is received. · 909d1883
      antirez authored
      This event makes clear, before the switch-master event is generated,
      that a Sentinel received a configuration update from another Sentinel.
      909d1883
  15. 07 May, 2014 6 commits
    • antirez's avatar
      Scripting test: check that Lua can call commands rewirting argv. · 80b96bc4
      antirez authored
      SPOP, tested in the new test, is among the commands rewritng the
      client->argv argument vector (it gets rewritten as SREM) for command
      replication purposes.
      
      Because of recent optimizations to client->argv caching in the context
      of the Lua internal Redis client, it is important to test for SPOP to be
      callable from Lua without bad effects to the other commands.
      80b96bc4
    • antirez's avatar
      Test: handle new osx 'leaks' error. · 093eab56
      antirez authored
      Sometimes the process is still there but no longer in a state that can
      be checked (after being killed). This used to happen after a call to
      SHUTDOWN NOSAVE in the scripting unit, causing a false positive.
      093eab56
    • antirez's avatar
      Scripting: objects caching for Lua c->argv creation. · 32971f62
      antirez authored
      Reusing small objects when possible is a major speedup under certain
      conditions, since it is able to avoid the malloc/free pattern that
      otherwise is performed for every argument in the client command vector.
      32971f62
    • antirez's avatar
      Scripting: Use faster API for Lua client c->argv creation. · 87516f1a
      antirez authored
      Replace the three calls to Lua API lua_tostring, lua_lua_strlen,
      and lua_isstring, with a single call to lua_tolstring.
      
      ~ 5% consistent speed gain measured.
      87516f1a
    • antirez's avatar
      Scripting: don't call lua_gc() after Lua script run. · 1b5524f6
      antirez authored
      Calling lua_gc() after every script execution is too expensive, and
      apparently does not make the execution smoother: the same peak latency
      was measured before and after the commit.
      
      This change accounts for scripts execution speedup in the order of 10%.
      1b5524f6
    • antirez's avatar
      Scripting: cache argv in luaRedisGenericCommand(). · 8237d88f
      antirez authored
      ~ 4% consistently measured speed improvement.
      8237d88f