- 08 Nov, 2017 1 commit
-
-
kmiku7 authored
-
- 06 Nov, 2017 1 commit
-
-
antirez authored
Normally in modern Redis you can't create zero-len lists, however it's possible to load them from old RDB files generated, for instance, using Redis 2.8 (see issue #4409). The "Right Thing" would be not loading such lists at all, but this requires to hook in rdb.c random places in a not great way, for a problem that is at this point, at best, minor. Here in this commit instead I just fix the fact that zero length lists, materialized as quicklists with the first node set to NULL, were iterated in the wrong way while they are saved, leading to a crash. The other parts of the list implementation are apparently able to deal with empty lists correctly, even if they are no longer a thing.
-
- 31 Oct, 2017 1 commit
-
-
antirez authored
There was not enough sanity checking in the code loading the slots of Redis Cluster from the nodes.conf file, this resulted into the attacker's ability to write data at random addresses in the process memory, by manipulating the index of the array. The bug seems exploitable using the following techique: the config file may be altered so that one of the nodes gets, as node ID (which is the first field inside the structure) some data that is actually executable: then by writing this address in selected places, this node ID part can be executed after a jump. So it is mostly just a matter of effort in order to exploit the bug. In practice however the issue is not very critical because the bug requires an unprivileged user to be able to modify the Redis cluster nodes configuration, and at the same time this should result in some gain. However Redis normally is unprivileged as well. Yet much better to have this fixed indeed. Fix #4278.
-
- 21 Sep, 2017 1 commit
-
-
antirez authored
-
- 18 Sep, 2017 1 commit
-
-
Oran Agra authored
when SHUTDOWN command is recived it is possible that some of the recent command were not yet flushed from the AOF buffer, and the server experiences data loss at shutdown.
-
- 28 Jul, 2017 1 commit
-
-
antirez authored
-
- 24 Jul, 2017 8 commits
-
-
Jan-Erik Rediger authored
Fixes #2258
-
WuYunlong authored
-
Byron Grobe authored
-
Jan-Erik Rediger authored
It's not POSIX (BSD systems have -E instead) and we don't actually need it. Closes #1922
-
Leon Chen authored
-
Leon Chen authored
-
liangsijian authored
-
antirez authored
This function failed when an internal-only flag was set as an only flag in a node: the string was trimmed expecting a final comma before exiting the function, causing a crash. See issue #4142. Moreover generation of flags representation only needed at DEBUG log level was always performed: a waste of CPU time. This is fixed as well by this commit.
-
- 11 Jul, 2017 1 commit
-
-
antirez authored
Close #3766.
-
- 30 Jun, 2017 2 commits
-
-
antirez authored
-
antirez authored
Issue #4084 shows how for a design error, GEORADIUS is a write command because of the STORE option. Because of this it does not work on readonly slaves, gets redirected to masters in Redis Cluster even when the connection is in READONLY mode and so forth. To break backward compatibility at this stage, with Redis 4.0 to be in advanced RC state, is problematic for the user base. The API can be fixed into the unstable branch soon if we'll decide to do so in order to be more consistent, and reease Redis 5.0 with this incompatibility in the future. This is still unclear. However, the ability to scale GEO queries in slaves easily is too important so this commit adds two read-only variants to the GEORADIUS and GEORADIUSBYMEMBER command: GEORADIUS_RO and GEORADIUSBYMEMBER_RO. The commands are exactly as the original commands, but they do not accept the STORE and STOREDIST options.
-
- 27 Jun, 2017 6 commits
-
-
Suraj Narkhede authored
1. brpop last key index, thus checking all keys for slots. 2. Memory leak in clusterRedirectBlockedClientIfNeeded. 3. Remove while loop in clusterRedirectBlockedClientIfNeeded.
-
Suraj Narkhede authored
-
antirez authored
-
Antonio Mallia authored
-
Zachary Marquez authored
Proposed fix to https://github.com/antirez/redis/issues/4027
-
antirez authored
-
- 22 Jun, 2017 4 commits
- 20 Jun, 2017 4 commits
-
-
minghang.zmh authored
-
xuchengxuan authored
-
cbgbt authored
-
Aric Huang authored
Fix a few typos/adjust wording in `create-cluster` README
-
- 14 Jun, 2017 1 commit
-
-
Salvatore Sanfilippo authored
Implement getKeys procedure for georadius and georadiusbymember commands
-
- 17 May, 2017 1 commit
-
-
antirez authored
-
- 15 May, 2017 1 commit
-
-
antirez authored
Close #3993.
-
- 21 Apr, 2017 4 commits
- 20 Apr, 2017 1 commit
-
-
张文康 authored
-
- 14 Apr, 2017 1 commit
-
-
antirez authored
And many other related Github issues... all reporting the same problem. There was probably just not enough backlog in certain unlucky runs. I'll ask people that can reporduce if they see now this as fixed as well.
-