1. 09 Feb, 2016 1 commit
    • David Cavar's avatar
      Reverse redirect address parse · c30ffaab
      David Cavar authored
      Fix issue in case the redirect address is in ipv6 format. Parse from behind to extract last part of the response which represents actual port.
      c30ffaab
  2. 05 Feb, 2016 1 commit
  3. 03 Feb, 2016 1 commit
  4. 02 Feb, 2016 4 commits
  5. 01 Feb, 2016 3 commits
  6. 29 Jan, 2016 9 commits
  7. 28 Jan, 2016 1 commit
  8. 27 Jan, 2016 2 commits
    • antirez's avatar
      5bbb09ed
    • antirez's avatar
      Sentinel: improve handling of known Sentinel instances. · 751b5666
      antirez authored
      1. Bug #3035 is fixed (NULL pointer access). This was happening with the
         folling set of conditions:
      
      * For some reason one of the Sentinels, let's call it Sentinel_A, changed ID (reconfigured from scratch), but is as the same address at which it used to be.
      
      * Sentinel_A performs a failover and/or has a newer configuration compared to another Sentinel, that we call, Sentinel_B.
      
      * Sentinel_B receives an HELLO message from Sentinel_A, where the address and/or ID is mismatched, but it is reporting a newer configuration for the master they are both monitoring.
      
      2. Sentinels now must have an ID otherwise they are not loaded nor persisted in the configuration. This allows to have conflicting Sentinels with the same address since now the master->sentinels dictionary is indexed by Sentinel ID.
      
      3. The code now detects if a Sentinel is annoucing itself with an IP/port pair already busy (of another Sentinel). The old Sentinel that had the same port/pair is set as having port 0, that means, the address is invalid. We may discover the right address later via HELLO messages.
      751b5666
  9. 26 Jan, 2016 4 commits
  10. 25 Jan, 2016 2 commits
  11. 20 Jan, 2016 2 commits
  12. 19 Jan, 2016 2 commits
    • antirez's avatar
      Minor MIGRATE refactoring. · 83b862a3
      antirez authored
      Centralize cleanup of newargv in a single place.
      Add more comments to help a bit following a complex function.
      
      Related to issue #3016.
      83b862a3
    • antirez's avatar
      More variadic MIGRATE fixes. · f5a1e608
      antirez authored
      Another leak was fixed in the case of syntax error by restructuring the
      allocation strategy for the two dynamic vectors.
      
      We also make sure to always close the cached socket on I/O errors so that
      all the I/O errors are handled the same, even if we had a previously
      queued error of a different kind from the destination server.
      
      Thanks to Kevin McGehee. Related to issue #3016.
      f5a1e608
  13. 18 Jan, 2016 1 commit
    • antirez's avatar
      Various fixes to MIGRATE with multiple keys. · 00d3a40f
      antirez authored
      In issue #3016 Kevin McGehee identified multiple very serious issues in
      the new implementation of MIGRATE. This commit attempts to restructure
      the code in oder to avoid mistakes, an analysis of the new
      implementation is in progress in order to check for possible edge cases.
      00d3a40f
  14. 15 Jan, 2016 4 commits
  15. 14 Jan, 2016 2 commits
    • antirez's avatar
      Cluster: fix setting nodes slaveof pointer to NULL on node release. · fc3ca8ff
      antirez authored
      With this commit we preserve the list of nodes that have .slaveof set
      to the node, even when the node is turned into a slave, and make sure to
      fix the .slaveof pointers to NULL when a node is freed from memory,
      regardless of the fact it's a slave or a master.
      
      Basically we try to remember the logical master in the current
      configuration even if the logical master advertised it as a slave
      already. However we still remember the associations, so that when a node
      is freed we can fix them.
      
      This should fix issue #3002.
      fc3ca8ff
    • antirez's avatar
      Cluster: clarify node->slave may be NULL. · a411d557
      antirez authored
      a411d557
  16. 13 Jan, 2016 1 commit