- 09 Feb, 2016 1 commit
-
-
David Cavar authored
Fix issue in case the redirect address is in ipv6 format. Parse from behind to extract last part of the response which represents actual port.
-
- 05 Feb, 2016 1 commit
-
-
Salvatore Sanfilippo authored
Adds keyspace notifications for LREM
-
- 03 Feb, 2016 1 commit
-
-
Itamar Haber authored
-
- 02 Feb, 2016 4 commits
-
-
Itamar Haber authored
-
antirez authored
-
antirez authored
-
antirez authored
We need to be able to correctly parse the node address in the case of IPv6 addresses.
-
- 01 Feb, 2016 3 commits
- 29 Jan, 2016 9 commits
-
-
antirez authored
-
antirez authored
CLUSTER SLOTS now includes IDs in the nodes description associated with a given slot range. Certain client libraries implementations need a way to reference a node in an unique way, so they were relying on CLUSTER NODES, that is not a stable API and may change frequently depending on Redis Cluster future requirements.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
- 28 Jan, 2016 1 commit
-
-
antirez authored
-
- 27 Jan, 2016 2 commits
-
-
antirez authored
-
antirez authored
1. Bug #3035 is fixed (NULL pointer access). This was happening with the folling set of conditions: * For some reason one of the Sentinels, let's call it Sentinel_A, changed ID (reconfigured from scratch), but is as the same address at which it used to be. * Sentinel_A performs a failover and/or has a newer configuration compared to another Sentinel, that we call, Sentinel_B. * Sentinel_B receives an HELLO message from Sentinel_A, where the address and/or ID is mismatched, but it is reporting a newer configuration for the master they are both monitoring. 2. Sentinels now must have an ID otherwise they are not loaded nor persisted in the configuration. This allows to have conflicting Sentinels with the same address since now the master->sentinels dictionary is indexed by Sentinel ID. 3. The code now detects if a Sentinel is annoucing itself with an IP/port pair already busy (of another Sentinel). The old Sentinel that had the same port/pair is set as having port 0, that means, the address is invalid. We may discover the right address later via HELLO messages.
-
- 26 Jan, 2016 4 commits
-
-
antirez authored
Reported here: https://www.reddit.com/r/redis/comments/42r0i0/avg_ttl_varies_a_lot/
-
antirez authored
-
antirez authored
-
antirez authored
The change covers the case where: 1. There is a node we can't reach (in fail or pfail state). 2. We see a different address for this node, in the gossip section sent to us by a node that, instead, is able to talk with the node we cannot talk to. In this case it's a good bet to switch to the address reported by this node, since there was an address switch and it is able to talk with the node and we are not. However previosuly this was done in a dangerous way, by initiating an handshake. The handshake, using the MEET packet, forces the receiver to join our cluster, and this is not a good idea. If the node in question really just switched address, but is the same node, it already knows about us, so we just need to perform an address update and a reconnection. So with this commit instead we just update the address of the node, release the node link if any, and attempt to reconnect in the next clusterCron() cycle. The commit also improves debugging messages printed by Cluster during address or ID switches.
-
- 25 Jan, 2016 2 commits
- 20 Jan, 2016 2 commits
-
-
Salvatore Sanfilippo authored
Removes an extra space in protected mode message
-
Itamar Haber authored
-
- 19 Jan, 2016 2 commits
-
-
antirez authored
Centralize cleanup of newargv in a single place. Add more comments to help a bit following a complex function. Related to issue #3016.
-
antirez authored
Another leak was fixed in the case of syntax error by restructuring the allocation strategy for the two dynamic vectors. We also make sure to always close the cached socket on I/O errors so that all the I/O errors are handled the same, even if we had a previously queued error of a different kind from the destination server. Thanks to Kevin McGehee. Related to issue #3016.
-
- 18 Jan, 2016 1 commit
-
-
antirez authored
In issue #3016 Kevin McGehee identified multiple very serious issues in the new implementation of MIGRATE. This commit attempts to restructure the code in oder to avoid mistakes, an analysis of the new implementation is in progress in order to check for possible edge cases.
-
- 15 Jan, 2016 4 commits
-
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
Fix race condition in unit/introspection
-
antirez authored
-
- 14 Jan, 2016 2 commits
-
-
antirez authored
With this commit we preserve the list of nodes that have .slaveof set to the node, even when the node is turned into a slave, and make sure to fix the .slaveof pointers to NULL when a node is freed from memory, regardless of the fact it's a slave or a master. Basically we try to remember the logical master in the current configuration even if the logical master advertised it as a slave already. However we still remember the associations, so that when a node is freed we can fix them. This should fix issue #3002.
-
antirez authored
-
- 13 Jan, 2016 1 commit
-
-
antirez authored
Because of rounding error even with weight=0 sometimes a node was left with an assigned slot. Close #3001.
-