1. 07 Apr, 2020 3 commits
    • Guy Benoish's avatar
      streamReplyWithRange: Redundant XSETIDs to replica · c35a5316
      Guy Benoish authored
      propagate_last_id is declared outside of the loop but used
      only from within the loop. Once it's '1' it will never go
      back to '0' and will replicate XSETID even for IDs that
      don't actually change the last_id.
      While not a serious bug (XSETID always used group->last_id
      so there's no risk), it does causes redundant traffic
      between master and its replicas
      c35a5316
    • antirez's avatar
      6fe66e09
    • Guy Benoish's avatar
      Fix memory corruption in moduleHandleBlockedClients · 193fc241
      Guy Benoish authored
      By using a "circular BRPOPLPUSH"-like scenario it was
      possible the get the same client on db->blocking_keys
      twice (See comment in moduleTryServeClientBlockedOnKey)
      
      The fix was actually already implememnted in
      moduleTryServeClientBlockedOnKey but it had a bug:
      the funxction should return 0 or 1 (not OK or ERR)
      
      Other changes:
      1. Added two commands to blockonkeys.c test module (To
         reproduce the case described above)
      2. Simplify blockonkeys.c in order to make testing easier
      3. cast raxSize() to avoid warning with format spec
      193fc241
  2. 31 Mar, 2020 21 commits
  3. 25 Mar, 2020 16 commits