- 28 Jul, 2020 1 commit
-
-
Wen Hui authored
valsize was not modified during the for loop below instead of getting from c->argv[4], therefore there is no need to put inside the for loop.. Moreover, putting the check outside loop will also avoid memory leaking, decrRefCount(key) should be called in the original code if we put the check in for loop
-
- 15 Jul, 2020 1 commit
-
-
Developer-Ecosystem-Engineering authored
Export following environment variables before building on macOS on Apple silicon export ARCH_FLAGS="-arch arm64" export SDK_NAME=macosx export SDK_PATH=$(xcrun --show-sdk-path --sdk $SDK_NAME) export CFLAGS="$ARCH_FLAGS -isysroot $SDK_PATH -I$SDK_PATH/usr/include" export CXXFLAGS=$CFLAGS export LDFLAGS="$ARCH_FLAGS" export CC="$(xcrun -sdk $SDK_PATH --find clang) $CFLAGS" export CXX="$(xcrun -sdk $SDK_PATH --find clang++) $CXXFLAGS" export LD="$(xcrun -sdk $SDK_PATH --find ld) $LDFLAGS" make make test .. All tests passed without errors! Backtrack logging assumes x86 and required updating
-
- 10 Jul, 2020 2 commits
-
-
Oran Agra authored
* tests/valgrind: don't use debug restart DEBUG REATART causes two issues: 1. it uses execve which replaces the original process and valgrind doesn't have a chance to check for errors, so leaks go unreported. 2. valgrind report invalid calls to close() which we're unable to resolve. So now the tests use restart_server mechanism in the tests, that terminates the old server and starts a new one, new PID, but same stdout, stderr. since the stderr can contain two or more valgrind report, it is not enough to just check for the absence of leaks, we also need to check for some known errors, we do both, and fail if we either find an error, or can't find a report saying there are no leaks. other changes: - when killing a server that was already terminated we check for leaks too. - adding DEBUG LEAK which was used to test it. - adding --trace-children to valgrind, although no longer needed. - since the stdout contains two or more runs, we need slightly different way of checking if the new process is up (explicitly looking for the new PID) - move the code that handles --wait-server to happen earlier (before watching the startup message in the log), and serve the restarted server too. * squashme - CR fixes
-
Oran Agra authored
-
- 20 May, 2020 1 commit
-
-
Oran Agra authored
also support: debug mallctl-str thread.tcache.flush VOID
-
- 04 May, 2020 1 commit
-
-
Oran Agra authored
* fix memlry leaks with diskless replica short read. * fix a few timing issues with valgrind runs * fix issue with valgrind and watchdog schedule signal about the valgrind WD issue: the stack trace test in logging.tcl, has issues with valgrind: ==28808== Can't extend stack to 0x1ffeffdb38 during signal delivery for thread 1: ==28808== too small or bad protection modes it seems to be some valgrind bug with SA_ONSTACK. SA_ONSTACK seems unneeded since WD is not recursive (SA_NODEFER was removed), also, not sure if it's even valid without a call to sigaltstack()
-
- 21 Apr, 2020 1 commit
-
-
antirez authored
-
- 09 Apr, 2020 1 commit
-
-
antirez authored
Related to #3243.
-
- 31 Mar, 2020 1 commit
-
-
Guy Benoish authored
Other changes: Support stream in serverLogObjectDebugInfo
-
- 07 Mar, 2020 1 commit
-
-
David Carlier authored
-
- 18 Feb, 2020 1 commit
-
-
hwware authored
-
- 06 Feb, 2020 1 commit
-
-
Oran Agra authored
-
- 30 Jan, 2020 1 commit
-
-
Guy Benoish authored
-
- 16 Jan, 2020 2 commits
- 29 Oct, 2019 1 commit
-
-
Oran Agra authored
* replication hooks: role change, master link status, replica online/offline * persistence hooks: saving, loading, loading progress * misc hooks: cron loop, shutdown, module loaded/unloaded * change the way hooks test work, and add tests for all of the above startLoading() now gets flag indicating what is loaded. stopLoading() now gets an indication of success or failure. adding startSaving() and stopSaving() with similar args and role.
-
- 07 Oct, 2019 2 commits
-
-
Oran Agra authored
-
Yossi Gottlieb authored
* Introduce a connection abstraction layer for all socket operations and integrate it across the code base. * Provide an optional TLS connections implementation based on OpenSSL. * Pull a newer version of hiredis with TLS support. * Tests, redis-cli updates for TLS support.
-
- 18 Sep, 2019 1 commit
-
-
antirez authored
-
- 31 Aug, 2019 1 commit
-
-
zhudacai 00228490 authored
of aarch64. The content comes from the definition of the sigcontext and tested on my aarch64 server. sigcontext defined at the linux kernel code: arch/arm64/include/uapi/asm/sigcontext.h
-
- 24 Jul, 2019 1 commit
-
-
Oran Agra authored
this implements #6012
-
- 03 Jul, 2019 1 commit
-
-
antirez authored
-
- 02 Jun, 2019 1 commit
-
-
Oran Agra authored
jemalloc 5 doesn't immediately release memory back to the OS, instead there's a decaying mechanism, which doesn't work when there's no traffic (no allocations). this is most evident if there's no traffic after flushdb, the RSS will remain high. 1) enable jemalloc background purging 2) explicitly purge in flushdb
-
- 11 Feb, 2019 1 commit
-
-
Chris Lamb authored
__x86_64__ is defined on the on the x32 architecture and the conditionals in debug.c therefore assume the size of (void*) etc: debug.c: In function 'getMcontextEip': debug.c:757:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] return (void*) uc->uc_mcontext.gregs[16]; /* Linux 64 */ ^ debug.c: In function 'logRegisters': debug.c:920:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] logStackContent((void**)uc->uc_mcontext.gregs[15]); We can remedy this by checking for __ILP32__ first. See: https://wiki.debian.org/ArchitectureSpecificsMemo ... for more info.
-
- 09 Jan, 2019 7 commits
- 11 Dec, 2018 1 commit
-
-
antirez authored
Verified to be able to trigger at least #5632. Does not report other issues.
-
- 07 Dec, 2018 2 commits
- 30 Nov, 2018 1 commit
-
-
zhaozhao.zz authored
-
- 25 Nov, 2018 2 commits
-
-
David Carlier authored
Special treatment here as backtrace support is optional, cannot be found via pkg-config and similar neither.
-
David Carlier authored
FreeBSD/DragonFlyBSD does have backtrace only it does not belong to libc.
-
- 08 Nov, 2018 1 commit
-
-
David Carlier authored
-
- 09 Oct, 2018 1 commit
-
-
antirez authored
Related to #4804.
-
- 30 Jul, 2018 1 commit
-
-
Oran Agra authored
-